[expr] [patch] Fix AAA::ALPHA regression after FSF GDB merge

[expr] [patch] Fix AAA::ALPHA regression after FSF GDB merge

[Jan Kratochvil]

Hi,

Sami has noticed after my merge bf44eca4f02a48aae593b2394ba6e0d633bdf840 there
is a regression on [expr-cumulative] against new FSF GDB testcase:
-PASS: gdb.cp/namespace.exp: print AAA::ALPHA
+FAIL: gdb.cp/namespace.exp: print AAA::ALPHA

FYI: fix PR c++/8000
http://sourceware.org/ml/gdb-patches/2010-01/msg00478.html

The patch below in fact exactly reverts a change of [expr-cumulative].

OK to check-in?

No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.


Thanks,
Jan


2010-01-27  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* dwarf2read.c (new_symbol <DW_TAG_enumerator>): Call dwarf2_full_name.

--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -8628,7 +8628,7 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu)
 	  add_symbol_to_list (sym, cu->list_in_scope);
 	  break;
 	case DW_TAG_enumerator:
-	  SYMBOL_LINKAGE_NAME (sym) = (char *) dwarf2_name (die, cu);
+	  SYMBOL_LINKAGE_NAME (sym) = (char *) dwarf2_full_name (die, cu);
 	  attr = dwarf2_attr (die, DW_AT_const_value, cu);
 	  if (attr)
 	    {

Re: [expr] [patch] Fix AAA::ALPHA regression after FSF GDB merge

[Sami Wagiaalla]

On 01/27/2010 01:33 PM, Jan Kratochvil wrote:
> Hi,
>
> Sami has noticed after my merge bf44eca4f02a48aae593b2394ba6e0d633bdf840 there
> is a regression on [expr-cumulative] against new FSF GDB testcase:
> -PASS: gdb.cp/namespace.exp: print AAA::ALPHA
> +FAIL: gdb.cp/namespace.exp: print AAA::ALPHA
>

Thanks for the prompt reply.

> FYI: fix PR c++/8000
> http://sourceware.org/ml/gdb-patches/2010-01/msg00478.html
>
> The patch below in fact exactly reverts a change of [expr-cumulative].
>

A change by Keith ? If so then maybe he has some concerns. Probably that 
linkage name is being used during lookup not that it is being set here.

> OK to check-in?
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
>

Okay by me if keith has no objections

Re: [expr] [patch] Fix AAA::ALPHA regression after FSF GDB merge

[Keith Seitz]

On 01/27/2010 10:54 AM, Sami Wagiaalla wrote:
> On 01/27/2010 01:33 PM, Jan Kratochvil wrote:
>> The patch below in fact exactly reverts a change of [expr-cumulative].
>>
>
> A change by Keith ? If so then maybe he has some concerns. Probably that
> linkage name is being used during lookup not that it is being set here.
>
>> OK to check-in?
>>
>> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
>>
>
> Okay by me if keith has no objections

I think that the change that I made (from May 2009) from 
dwarf2_full_name was probably a workaround to a problem that has since 
been solved.

Since your patch causes no regressions in realcpp.exp, I would say that 
your patch should be committed. Thanks!

Keith

Re: [expr] [patch] Fix AAA::ALPHA regression after FSF GDB merge

[Jan Kratochvil]

On Wed, 27 Jan 2010 20:15:36 +0100, Keith Seitz wrote:
> Since your patch causes no regressions in realcpp.exp, I would say
> that your patch should be committed. Thanks!

Checked-in:
	52044583b7d8bff79f0380ea3aec30c9ae4edaef


Thanks,
Jan