From: Jan Beulich <jbeulich@suse.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: binutils@sourceware.org, Cary Coutant <ccoutant@gmail.com>
Subject: Re: [PATCH v2] gas: Fix a testcase broken by new ZSTD support
Date: Fri, 5 Aug 2022 10:24:49 +0200 [thread overview]
Message-ID: <05632efb-f73e-ff0d-5414-d66dce90b8e8@suse.com> (raw)
In-Reply-To: <2b7fa463eb7c9a6b78c8d02fd61c2a243bc3a9ea.1659685511.git.research_trasio@irq.a4lg.com>
On 05.08.2022 09:45, Tsukasa OI wrote:
> The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF
> compression type for ZSTD.") added the new ELF compression type but it
> accidentally broke a GAS testcase. Since testing for the section type
> "2048" (SHF_COMPRESSED) is not going to be portable in the long term, it
> now tests SHF_STRINGS ("32") instead. ".word 0" should be okay to
> represent no null-terminated strings.
>
> gas/ChangeLog:
>
> * testsuite/gas/elf/section10.s: Use SHF_STRINGS to test. Put an
> empty string in it.
> * testsuite/gas/elf/section10.d: Reflect the changes above.
Hmm, but SHF_STRINGS requires sh_entsize to be set, so the resulting
object file is, strictly speaking, not valid. Perhaps use
SHF_LINK_ORDER then (where the spec leaves room for sh_link being zero),
or SHF_OS_NONCONFORMING (since we don't mean to actually link this
object file into anywhere), or SHF_TLS?
Jan
next prev parent reply other threads:[~2022-08-05 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 7:12 [PATCH] " Tsukasa OI
2022-08-05 7:29 ` Jan Beulich
2022-08-05 7:45 ` Tsukasa OI
2022-08-05 7:45 ` [PATCH v2] " Tsukasa OI
2022-08-05 8:24 ` Jan Beulich [this message]
2022-08-05 8:54 ` Tsukasa OI
2022-08-05 8:52 ` [PATCH v3] " Tsukasa OI
2022-08-05 8:59 ` Jan Beulich
2022-08-05 20:27 ` [PATCH] " Cary Coutant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05632efb-f73e-ff0d-5414-d66dce90b8e8@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=ccoutant@gmail.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).