From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Jan Beulich <jbeulich@suse.com>,
Cary Coutant <ccoutant@gmail.com>
Cc: binutils@sourceware.org
Subject: [PATCH v2] gas: Fix a testcase broken by new ZSTD support
Date: Fri, 5 Aug 2022 16:45:30 +0900 [thread overview]
Message-ID: <2b7fa463eb7c9a6b78c8d02fd61c2a243bc3a9ea.1659685511.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <88262e9dfc11097d08b552171f1af2e8e026f554.1659683506.git.research_trasio@irq.a4lg.com>
The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF
compression type for ZSTD.") added the new ELF compression type but it
accidentally broke a GAS testcase. Since testing for the section type
"2048" (SHF_COMPRESSED) is not going to be portable in the long term, it
now tests SHF_STRINGS ("32") instead. ".word 0" should be okay to
represent no null-terminated strings.
gas/ChangeLog:
* testsuite/gas/elf/section10.s: Use SHF_STRINGS to test. Put an
empty string in it.
* testsuite/gas/elf/section10.d: Reflect the changes above.
---
gas/testsuite/gas/elf/section10.d | 3 +--
gas/testsuite/gas/elf/section10.s | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/gas/testsuite/gas/elf/section10.d b/gas/testsuite/gas/elf/section10.d
index d51bd4e36e5..4ab3e8e56e9 100644
--- a/gas/testsuite/gas/elf/section10.d
+++ b/gas/testsuite/gas/elf/section10.d
@@ -13,8 +13,7 @@
[ ]*\[.*6000000\]: OS \(.*6000000\)
[ ]*\[.*\][ ]+sec2
[ ]*PROGBITS.*
-[ ]*\[0+00806\]: ALLOC, EXEC, COMPRESSED
-[ ]*\[<unknown>: 0x[0-9]+\], .*
+[ ]*\[0+00026\]: ALLOC, EXEC, STRINGS
#...
[ ]*\[.*\][ ]+sec3
[ ]*PROGBITS.*
diff --git a/gas/testsuite/gas/elf/section10.s b/gas/testsuite/gas/elf/section10.s
index d52b3458fb1..8b140715fb0 100644
--- a/gas/testsuite/gas/elf/section10.s
+++ b/gas/testsuite/gas/elf/section10.s
@@ -3,8 +3,8 @@
.word 1
# Make sure that a numeric value can be mixed with alpha values.
- .section sec2, "a2048x"
- .word 2
+ .section sec2, "a32x"
+ .word 0
# Make sure that specifying further arguments to .sections is still supported
.section sec3, "0xfedff000MS", %progbits, 32
base-commit: 731d2cc1d5106c077584bd83e96dbba4f7e11118
--
2.34.1
next prev parent reply other threads:[~2022-08-05 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 7:12 [PATCH] " Tsukasa OI
2022-08-05 7:29 ` Jan Beulich
2022-08-05 7:45 ` Tsukasa OI
2022-08-05 7:45 ` Tsukasa OI [this message]
2022-08-05 8:24 ` [PATCH v2] " Jan Beulich
2022-08-05 8:54 ` Tsukasa OI
2022-08-05 8:52 ` [PATCH v3] " Tsukasa OI
2022-08-05 8:59 ` Jan Beulich
2022-08-05 20:27 ` [PATCH] " Cary Coutant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b7fa463eb7c9a6b78c8d02fd61c2a243bc3a9ea.1659685511.git.research_trasio@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=binutils@sourceware.org \
--cc=ccoutant@gmail.com \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).