Re: [PATCH] gas: Fix a testcase broken by new ZSTD support

[Jan Beulich <jbeulich@suse.com>]

On 05.08.2022 09:12, Tsukasa OI wrote:
> The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF
> compression type for ZSTD.") added the new ELF compression type but it
> accidentally broke a GAS testcase.  Since 2 is now a valid compression type
> ELFCOMPRESS_ZSTD, the ".word 2" line in section10.s which expects an
> **unknown** compression type needs to be changed to another unknown value.
> 
> gas/ChangeLog:
> 
> 	* testsuite/gas/elf/section10.s: Use unknown ELF compression type.
> ---
>  gas/testsuite/gas/elf/section10.s | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gas/testsuite/gas/elf/section10.s b/gas/testsuite/gas/elf/section10.s
> index d52b3458fb1..6a252fb6334 100644
> --- a/gas/testsuite/gas/elf/section10.s
> +++ b/gas/testsuite/gas/elf/section10.s
> @@ -4,7 +4,7 @@
>  
>  	# Make sure that a numeric value can be mixed with alpha values.
>  	.section sec2, "a2048x"
> -	.word 2
> +	.word 9

Hmm, in N years time this will become an issue again. Since it's not
really connected to the purpose of the test, would it make sense to
instead simply drop that one line from section10.d?

Jan