public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: binutils@sourceware.org, Cary Coutant <ccoutant@gmail.com>
Subject: Re: [PATCH v3] gas: Fix a testcase broken by new ZSTD support
Date: Fri, 5 Aug 2022 10:59:41 +0200	[thread overview]
Message-ID: <27c99eeb-2a7c-a982-8cd3-9b8d0f7d7e0e@suse.com> (raw)
In-Reply-To: <3b979360e60f3669ccecd68abeb6cd38aeaab858.1659689524.git.research_trasio@irq.a4lg.com>

On 05.08.2022 10:52, Tsukasa OI wrote:
> The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF
> compression type for ZSTD.") added the new ELF compression type but it
> accidentally broke a GAS testcase.  Since testing for the section type
> "2048" (SHF_COMPRESSED) is not going to be portable in the long term, it
> now tests SHF_LINK_ORDER ("128") instead.
> 
> Using SHF_LINK_ORDER (with possibly sh_link == 0) is an idea by Jan Beulich.
> 
> gas/ChangeLog:
> 
> 	* testsuite/gas/elf/section10.s: Use SHF_LINK_ORDER to test
> 	mixed numeric and alpha values.
> 	* testsuite/gas/elf/section10.d: Reflect the change above.
> ---
>  gas/testsuite/gas/elf/section10.d | 3 +--
>  gas/testsuite/gas/elf/section10.s | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)

Okay.

Thanks, Jan

  reply	other threads:[~2022-08-05  8:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  7:12 [PATCH] " Tsukasa OI
2022-08-05  7:29 ` Jan Beulich
2022-08-05  7:45   ` Tsukasa OI
2022-08-05  7:45 ` [PATCH v2] " Tsukasa OI
2022-08-05  8:24   ` Jan Beulich
2022-08-05  8:54     ` Tsukasa OI
2022-08-05  8:52   ` [PATCH v3] " Tsukasa OI
2022-08-05  8:59     ` Jan Beulich [this message]
2022-08-05 20:27 ` [PATCH] " Cary Coutant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27c99eeb-2a7c-a982-8cd3-9b8d0f7d7e0e@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=ccoutant@gmail.com \
    --cc=research_trasio@irq.a4lg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).