From: Simon Marchi <simark@simark.ca>
To: Simon Marchi <simon.marchi@polymtl.ca>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] Import mklog.py from gcc repo
Date: Fri, 25 Sep 2020 10:25:39 -0400 [thread overview]
Message-ID: <13ec4b5c-5489-ecbb-0300-e606d1c8ad92@simark.ca> (raw)
In-Reply-To: <f3a0d6c9-9a67-bb9b-3aae-22829ba9fcbb@polymtl.ca>
On 2020-09-21 11:31 a.m., Simon Marchi via Gdb-patches wrote:
> On 2020-09-17 4:29 p.m., Simon Marchi wrote:
>> I've been using the mklog utility from the gcc repo for a while to
>> generate skeleton of ChangeLog entries. It recently got a rewrite as a
>> Python script. Unfortunately, to find the repository root, and
>> eventually to find in which ChangeLog file each entry goes, the new
>> script assumes it is located in the same git repository that it
>> generates ChangeLog entries for.
>>
>> This means that if you make a change in the gcc source tree and run
>> mklog.py from that same source tree, it works. But if you make changes
>> in your ~/src/binutils-gdb tree and run ~/src/gcc/contrib/mklog.py, it
>> won't work.
>>
>> IIRC, the old script required that you ran it with the project's root
>> directory as the CWD.
>>
>> The simplest way to fix this is to import the script in binutils-gdb and
>> use it from there. It's also nice because we can use it without having
>> a clone of the gcc repo.
>>
>> I also thought of adding a "--root" switch to the script to override the
>> project's base directory. However:
>>
>> 1) It is more work.
>> 2) If the script still lives in the gcc repo, it's less convenient than
>> having it in binutils-gdb.
>>
>> This patch imports contrib/mklog.py from the gcc repo, revision
>> c560591408440f441b8b327f5b41f9328d20b67b.
>>
>> contrib/ChangeLog:
>>
>> * mklog.py: New file, imported from gcc.
>>
>> Note: the ChangeLog entry above was generated using
>> `git show | ./mklog.py`!
>
> I'll push this at the end of the week if nobody disagrees.
>
> Simon
>
I pushed this patch.
Simon
prev parent reply other threads:[~2020-09-25 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 20:29 Simon Marchi
2020-09-18 14:27 ` Christian Biesinger
2020-09-18 14:48 ` Alex Coplan
2020-09-18 14:50 ` Simon Marchi
2020-09-21 12:45 ` Martin Liška
2020-09-21 14:33 ` Simon Marchi
2020-09-21 15:31 ` Simon Marchi
2020-09-25 14:25 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13ec4b5c-5489-ecbb-0300-e606d1c8ad92@simark.ca \
--to=simark@simark.ca \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).