From: "Martin Liška" <mliska@suse.cz>
To: Simon Marchi <simon.marchi@polymtl.ca>,
Christian Biesinger <cbiesinger@google.com>
Cc: binutils@sourceware.org, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Import mklog.py from gcc repo
Date: Mon, 21 Sep 2020 14:45:11 +0200 [thread overview]
Message-ID: <1a02745d-b063-d146-5e81-fb1e5cd41b8a@suse.cz> (raw)
In-Reply-To: <ba007054-b247-f0e4-ff46-8f6d138d5a52@polymtl.ca>
On 9/18/20 4:50 PM, Simon Marchi via Binutils wrote:
> On 2020-09-18 10:27 a.m., Christian Biesinger wrote:
>> I like this in principle, but the one annoying part is that no longer
>> prints the patch author/date line, so you have to manually create it.
>> I suppose one could make their own script for that (or maybe emacs
>> users have a macro for that or something)...
>
> I think you could add an option to the script to do this, I don't see
> why they would reject that. I don't know what the workflow of the gcc
> devs is regarding this.
I removed it as author and timestamp lines are automatically generated
based on git commit information.
>
> But it's not a problem from my point of view. I prefer to write my
> ChangeLog entries in the commit message without the header. I think
> it's pointless to put a date there, because the final date will be the
> date where I actually push the patch on the upstream master branch. And
> the name/email is redundant with the author name/email of the commit.
>
> I use a script [1] to insert the entries in the ChangeLog files and
> amend the commit when I'm about to push to upstream master. The script
> automatically generates the date/name/email line at that moment.
Note that some time ago I offered the gcc-changelog script to binutils community
and it was basically rejected. [1] is a motivation example as anybody has it's
own script to mechanically modify a timestamp and apply ChangeLog entries.
It's a legwork.
Martin
>
> Simon
>
> [1] https://github.com/simark/gnu-changelog-tools/blob/master/changelog-git-amend/changelog-git-amend.py
>
next prev parent reply other threads:[~2020-09-21 12:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 20:29 Simon Marchi
2020-09-18 14:27 ` Christian Biesinger
2020-09-18 14:48 ` Alex Coplan
2020-09-18 14:50 ` Simon Marchi
2020-09-21 12:45 ` Martin Liška [this message]
2020-09-21 14:33 ` Simon Marchi
2020-09-21 15:31 ` Simon Marchi
2020-09-25 14:25 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a02745d-b063-d146-5e81-fb1e5cd41b8a@suse.cz \
--to=mliska@suse.cz \
--cc=binutils@sourceware.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).