From: jiawei@iscas.ac.cn
To: "Jan Beulich" <jbeulich@suse.com>
Cc: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com,
philipp.tomsich@vrull.eu, mjos@pqshield.com,
ben.marshall@pqshield.com, cmuellner@ventanamicro.com,
palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com,
siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org,
binutils@sourceware.org
Subject: Re: Re: [PATCH v4 1/3] RISC-V: Minimal support of scalar crypto extension
Date: Mon, 21 Feb 2022 22:14:04 +0800 (GMT+08:00) [thread overview]
Message-ID: <1490a2a8.1571c.17f1ca1de44.Coremail.jiawei@iscas.ac.cn> (raw)
In-Reply-To: <fcdadbce-9c91-e934-3fd8-157f403f8315@suse.com>
> -----原始邮件-----
> 发件人: "Jan Beulich" <jbeulich@suse.com>
> 发送时间: 2022-02-21 21:24:11 (星期一)
> 收件人: jiawei <jiawei@iscas.ac.cn>
> 抄送: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, binutils@sourceware.org
> 主题: Re: [PATCH v4 1/3] RISC-V: Minimal support of scalar crypto extension
>
> On 15.11.2021 04:03, jiawei wrote:
> > Minimal support of scalar crypto extension, add "k" in riscv_supported_std_ext[] to make the order check right with "zk" behind "zb". "zbk*" is sub-extension for k-ext, so it added behind "zbs" in riscv_supported_std_z_ext[].
> > ---
> > bfd/elfxx-riscv.c | 28 ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> > index 3ffbaad66dd..152fbe3d160 100644
> > --- a/bfd/elfxx-riscv.c
> > +++ b/bfd/elfxx-riscv.c
> > @@ -1075,6 +1075,20 @@ static struct riscv_implicit_subset riscv_implicit_subsets[] =
> > {"q", "d", check_implicit_always},
> > {"d", "f", check_implicit_always},
> > {"f", "zicsr", check_implicit_always},
> > + {"zk", "zkn", check_implicit_always},
> > + {"zk", "zkr", check_implicit_always},
> > + {"zk", "zkt", check_implicit_always},
> > + {"zkn", "zbkb", check_implicit_always},
> > + {"zkn", "zbkc", check_implicit_always},
> > + {"zkn", "zbkx", check_implicit_always},
> > + {"zkn", "zkne", check_implicit_always},
> > + {"zkn", "zknd", check_implicit_always},
> > + {"zkn", "zknh", check_implicit_always},
> > + {"zks", "zbkb", check_implicit_always},
> > + {"zks", "zbkc", check_implicit_always},
> > + {"zks", "zbkx", check_implicit_always},
> > + {"zks", "zksed", check_implicit_always},
> > + {"zks", "zksh", check_implicit_always},
> > {NULL, NULL, NULL}
> > };
> >
> > @@ -1127,6 +1141,7 @@ static struct riscv_supported_ext riscv_supported_std_ext[] =
> > {"c", ISA_SPEC_CLASS_20190608, 2, 0, 0 },
> > {"c", ISA_SPEC_CLASS_2P2, 2, 0, 0 },
> > {"b", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSION, RISCV_UNKNOWN_VERSION, 0 },
> > + {"k", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSION, RISCV_UNKNOWN_VERSION, 0 },
>
> May I ask what purpose this addition serves? Without its use enabling
> smaller scope extensions implicitly, I find it at best unhelpful that
> ".option arch, +k" is accepted without having any effect.
>
> Jan
It's same like bitmanip extension, add this will make k extension as a subextension
and set it's canonical order as ISA spec defined.
BR,
Jiawei
>
> > @@ -1146,6 +1161,19 @@ static struct riscv_supported_ext riscv_supported_std_z_ext[] =
> > {"zba", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > {"zbc", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > {"zbs", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zbkb", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zbkc", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zbkx", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zk", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zkn", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zknd", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zkne", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zknh", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zkr", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zks", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zksed", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zksh", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > + {"zkt", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> > {NULL, 0, 0, 0, 0}
> > };
> >
</jiawei@iscas.ac.cn></jbeulich@suse.com>
next prev parent reply other threads:[~2022-02-21 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 3:03 [PATCH v4 0/3] RISC-V: Support Scalar Cryptography extension jiawei
2021-11-15 3:03 ` [PATCH v4 1/3] RISC-V: Minimal support of scalar crypto extension jiawei
2022-02-21 13:24 ` Jan Beulich
2022-02-21 14:14 ` jiawei [this message]
2022-02-21 14:16 ` Philipp Tomsich
2022-02-21 14:25 ` Jan Beulich
2022-02-21 14:44 ` Tsukasa OI
2022-02-21 14:50 ` Kito Cheng
2021-11-15 3:03 ` [PATCH v4 2/3] RISC-V: Scalar crypto instructions and operand set jiawei
2022-01-04 8:04 ` Jan Beulich
2022-01-04 8:38 ` 陈嘉炜
2022-01-04 8:49 ` Jan Beulich
2022-01-04 13:13 ` Markku-Juhani O. Saarinen
2021-11-15 3:03 ` [PATCH v4 3/3] RISC-V: Scalar crypto instruction and Entropy Source CSR testcases jiawei
2021-12-21 16:06 ` Jan Beulich
2021-11-16 4:07 ` [PATCH v4 0/3] RISC-V: Support Scalar Cryptography extension Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490a2a8.1571c.17f1ca1de44.Coremail.jiawei@iscas.ac.cn \
--to=jiawei@iscas.ac.cn \
--cc=andrew@sifive.com \
--cc=ben.marshall@pqshield.com \
--cc=binutils@sourceware.org \
--cc=cmuellner@ventanamicro.com \
--cc=jbeulich@suse.com \
--cc=jimw@sifive.com \
--cc=kito.cheng@sifive.com \
--cc=lazyparser@gmail.com \
--cc=mjos@pqshield.com \
--cc=nelson.chu@sifive.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=schwab@linux-m68k.org \
--cc=siyu@isrc.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).