From: Jan Beulich <jbeulich@suse.com>
To: 陈嘉炜 <jiawei@iscas.ac.cn>
Cc: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com,
philipp.tomsich@vrull.eu, mjos@pqshield.com,
ben.marshall@pqshield.com, cmuellner@ventanamicro.com,
palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com,
siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org,
binutils@sourceware.org
Subject: Re: [PATCH v4 2/3] RISC-V: Scalar crypto instructions and operand set
Date: Tue, 4 Jan 2022 09:49:08 +0100 [thread overview]
Message-ID: <ed40c8b7-b48c-5b36-0f36-fb2bbb76f76b@suse.com> (raw)
In-Reply-To: <3fabe6df.10ef.17e243dcae6.Coremail.jiawei@iscas.ac.cn>
On 04.01.2022 09:38, 陈嘉炜 wrote:
> > -----原始邮件-----
> > 发件人: "Jan Beulich" <jbeulich@suse.com>
> > 发送时间: 2022-01-04 16:04:31 (星期二)
> > 收件人: jiawei <jiawei@iscas.ac.cn>
> > 抄送: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, binutils@sourceware.org
> > 主题: Re: [PATCH v4 2/3] RISC-V: Scalar crypto instructions and operand set
> >
> > On 15.11.2021 04:03, jiawei wrote:
> > > @@ -847,6 +856,49 @@ const struct riscv_opcode riscv_opcodes[] =
> > > {"bext", 0, INSN_CLASS_ZBS, "d,s,t", MATCH_BEXT, MASK_BEXT, match_opcode, 0 },
> > > {"bext", 0, INSN_CLASS_ZBS, "d,s,>", MATCH_BEXTI, MASK_BEXTI, match_opcode, INSN_ALIAS },
> > >
> > > +/* Zbkx instructions */
> > > +{"xperm4", 0, INSN_CLASS_ZBKX, "d,s,t", MATCH_XPERM4, MASK_XPERM4, match_opcode, 0 },
> > > +{"xperm8", 0, INSN_CLASS_ZBKX, "d,s,t", MATCH_XPERM8, MASK_XPERM8, match_opcode, 0 },
> > > +
> > > +/* Zknd instructions */
> > > +{"aes32dsi", 32, INSN_CLASS_ZKND, "d,s,t,y", MATCH_AES32DSI, MASK_AES32DSI, match_opcode, 0 },
> > > +{"aes32dsmi", 32, INSN_CLASS_ZKND, "d,s,t,y", MATCH_AES32DSMI, MASK_AES32DSMI, match_opcode, 0 },
> >
> > For these two and a few more with immediate operands and a trailing 'i'
> > in the mnemonics: Shouldn't they have i-suffix-less pseudos, matching
> > other insns with immediate operands?
> >
> > Jan
>
> I think the 'i' trailing is just a dinstinguishing symbol in zknd extension, there are no i-suffix-less pseudo definitions in the cryptogrpah extension spec, please check it.
Perhaps I should have said explicitly that this is a question not so much
on the implementation, but on the spec itself.
Jan
next prev parent reply other threads:[~2022-01-04 8:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 3:03 [PATCH v4 0/3] RISC-V: Support Scalar Cryptography extension jiawei
2021-11-15 3:03 ` [PATCH v4 1/3] RISC-V: Minimal support of scalar crypto extension jiawei
2022-02-21 13:24 ` Jan Beulich
2022-02-21 14:14 ` jiawei
2022-02-21 14:16 ` Philipp Tomsich
2022-02-21 14:25 ` Jan Beulich
2022-02-21 14:44 ` Tsukasa OI
2022-02-21 14:50 ` Kito Cheng
2021-11-15 3:03 ` [PATCH v4 2/3] RISC-V: Scalar crypto instructions and operand set jiawei
2022-01-04 8:04 ` Jan Beulich
2022-01-04 8:38 ` 陈嘉炜
2022-01-04 8:49 ` Jan Beulich [this message]
2022-01-04 13:13 ` Markku-Juhani O. Saarinen
2021-11-15 3:03 ` [PATCH v4 3/3] RISC-V: Scalar crypto instruction and Entropy Source CSR testcases jiawei
2021-12-21 16:06 ` Jan Beulich
2021-11-16 4:07 ` [PATCH v4 0/3] RISC-V: Support Scalar Cryptography extension Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed40c8b7-b48c-5b36-0f36-fb2bbb76f76b@suse.com \
--to=jbeulich@suse.com \
--cc=andrew@sifive.com \
--cc=ben.marshall@pqshield.com \
--cc=binutils@sourceware.org \
--cc=cmuellner@ventanamicro.com \
--cc=jiawei@iscas.ac.cn \
--cc=jimw@sifive.com \
--cc=kito.cheng@sifive.com \
--cc=lazyparser@gmail.com \
--cc=mjos@pqshield.com \
--cc=nelson.chu@sifive.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=schwab@linux-m68k.org \
--cc=siyu@isrc.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).