Re: [PATCH 1/2] RISC-V: Add 'H' to canonical extension ordering

[Tsukasa OI <research_trasio@irq.a4lg.com>]

On 2022/06/22 19:39, Nelson Chu wrote:
> Sorry for being late, I have been busy recently.  I didn't notice that
> the isa spec had been updated, anyway, the h is a single extension
> after v, rather than the multi-letter extension for now.  So LGTM,
> committed.
> 
> Besides, please give me some time to review other patches, I've been
> busy with other things for a while...

Merging smallest one will be great but I understand the situation.
Besides, some of my patchsets are not only large but complex.

And... since you added 'H' support to GNU Binutils, I think I need to
rewrite my old CSR patchset (yes, it's going to be big).

Anyway, I will submit following patchsets later (so you don't need
patchsets below until I submit newer ones):

1a. Combined floating point enhancements and fixes
1b. Minimal Zfinx fixes (incompatible with 1a)
2.  CSR addition (Smstateen/Sscofpmf/Sstc)

Thanks,
Tsukasa

> 
> Thanks
> Nelson
> 
> On Sun, Jun 5, 2022 at 12:43 PM Tsukasa OI <research_trasio@irq.a4lg.com> wrote:
>>
>> This commit adds 'H' to canonical extension ordering based on current
>> consensus (not officially ratified as a new ISA specification manual
>> but discussion for software compatibility is made).
>>
>> bfd/ChangeLog
>>
>>         * elfxx-riscv.c (riscv_ext_canonical_order): Add 'H' for
>>         canonical extension ordering based on current consensus.
>> ---
>>  bfd/elfxx-riscv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
>> index 92ad03feea0..5c2c616a760 100644
>> --- a/bfd/elfxx-riscv.c
>> +++ b/bfd/elfxx-riscv.c
>> @@ -1345,7 +1345,7 @@ riscv_recognized_prefixed_ext (const char *ext)
>>  }
>>
>>  /* Canonical order for single letter extensions.  */
>> -static const char riscv_ext_canonical_order[] = "eigmafdqlcbkjtpvn";
>> +static const char riscv_ext_canonical_order[] = "eigmafdqlcbkjtpvnh";
>>
>>  /* Array is used to compare the orders of standard extensions quickly.  */
>>  static int riscv_ext_order[26] = {0};
>> --
>> 2.34.1
>>
>