From: Nick Clifton <nickc@redhat.com>
To: Paul Iannetta <piannetta@kalrayinc.com>, binutils@sourceware.org
Subject: Re: [PATCH 0/7] kvx: New port.
Date: Mon, 24 Jul 2023 10:53:04 +0100 [thread overview]
Message-ID: <1a2fe285-ff82-eeb1-4671-ae21aa802711@redhat.com> (raw)
In-Reply-To: <20230721074956.7188-1-piannetta@kalrayinc.com>
Hi Paul,
First a request: please could you add updates to the gas/NEWS and ld/NEWS
files mentioning the fact that the KVX architecture is now supported.
Next some code review. I am going to skip over code formatting and comment
structure issues for now, and also my favourite bugbear (calls to abort() in
library code which stops the user of the library from handling error conditions),
and instead focus on potential bugs and coding problems. Except that I cannot
find any! Visual inspection may not be a perfect tool, but I have looked over
your code and it all looks good to me.
I will still need to check that the next set of patches compile and that the
assembler and linker work, but I have to say that the contribution is looking
very good so far.
Cheers
Nick
PS. It might me nice to have a few more KVX specific test files added to the
assembler testsuite. One at least that checks that each of the instructions
assembles as expected...
next prev parent reply other threads:[~2023-07-24 9:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 7:49 Paul Iannetta
2023-07-21 7:49 ` [PATCH 1/7] kvx: Add bf files Paul Iannetta
2023-07-21 7:49 ` [PATCH 2/7] kvx: Add binutils files Paul Iannetta
2023-07-21 7:49 ` [PATCH 3/7] kvx: Add gas file Paul Iannetta
2023-07-21 7:49 ` [PATCH 4/7] kvx: Add ld files Paul Iannetta
2023-07-21 7:49 ` [PATCH 5/7] kvx: Add include files Paul Iannetta
2023-07-21 7:49 ` [PATCH 6/7] kvx: Add opcodes file Paul Iannetta
2023-07-21 7:49 ` [PATCH 7/7] kvx: Add toplevel files Paul Iannetta
2023-07-21 8:29 ` [PATCH 0/7] kvx: New port Nick Clifton
[not found] ` <20230721090932.pspnpq2q2wjnshrh@ws2202.lin.mbt.kalray.eu>
[not found] ` <2050791e-38ee-5719-037f-c03c456f3e3d@redhat.com>
2023-07-21 16:47 ` Paul Iannetta
2023-07-21 17:00 ` Paul Iannetta
2023-07-21 8:57 ` YunQiang Su
2023-07-21 16:51 ` Paul Iannetta
2023-07-24 9:04 ` Nick Clifton
2023-07-24 9:38 ` Paul Iannetta
2023-07-24 9:28 ` Nick Clifton
2023-07-24 12:33 ` Paul Iannetta
2023-07-24 14:30 ` Paul Iannetta
2023-07-25 14:13 ` Nick Clifton
2023-07-26 7:36 ` Paul Iannetta
2023-07-26 13:32 ` Michael Matz
2023-07-26 21:46 ` Paul Iannetta
2023-07-26 21:24 ` [PATCH v2] " Paul Iannetta
2023-07-31 14:52 ` Nick Clifton
2023-08-02 14:38 ` [PATCH v3] " Paul Iannetta
2023-08-16 13:24 ` Nick Clifton
2023-08-17 9:45 ` Luis Machado
2023-08-17 15:09 ` Paul Iannetta
2023-08-17 16:28 ` Luis Machado
2023-08-17 23:20 ` Alan Modra
2023-08-18 7:13 ` Paul Iannetta
2023-08-17 12:46 ` Paul Iannetta
2023-07-24 9:53 ` Nick Clifton [this message]
2023-07-24 12:27 ` [PATCH 0/7] " Paul Iannetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a2fe285-ff82-eeb1-4671-ae21aa802711@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=piannetta@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).