From: Nick Clifton <nickc@redhat.com>
To: Paul Iannetta <piannetta@kalrayinc.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2] kvx: New port.
Date: Mon, 31 Jul 2023 15:52:31 +0100 [thread overview]
Message-ID: <e04dc97d-24b3-79dc-3b21-3684cd84a421@redhat.com> (raw)
In-Reply-To: <20230726212435.bd5zf3azsj55ejme@ws2202.lin.mbt.kalray.eu>
Hi Paul,
> I've taken into account the points you raised in your review,
Thank you very much.
Just a couple more small issues:
* The kvx-linux target does not appear to be supported by the
assembler. In particular when running the gas testsuite I
found messages like this:
failed with: <Assembler messages:
Fatal error: selected target format 'elf32-kvx' unknown>, no expected output
FAIL: gas/kvx/kv3-1-insns-32
The linker and binutils testsuites also have failures with
similar messages.
I am assuming that "kvx-linux" is a valid configuration target.
If not, then it ought to be rejected by bfd/config.bfd.
* The copyright dates on some of the new files are wrong/old.
For example ld/emultempl/kvxelf.em has:
# Copyright (C) 2009-2016 Free Software Foundation, Inc.
This ought to be "...2009-2023...". I have not checked all the
other files in the patch, but if there any others will out of date
copyright notices then I hope that you will fix them.
Cheers
Nick
next prev parent reply other threads:[~2023-07-31 14:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 7:49 [PATCH 0/7] " Paul Iannetta
2023-07-21 7:49 ` [PATCH 1/7] kvx: Add bf files Paul Iannetta
2023-07-21 7:49 ` [PATCH 2/7] kvx: Add binutils files Paul Iannetta
2023-07-21 7:49 ` [PATCH 3/7] kvx: Add gas file Paul Iannetta
2023-07-21 7:49 ` [PATCH 4/7] kvx: Add ld files Paul Iannetta
2023-07-21 7:49 ` [PATCH 5/7] kvx: Add include files Paul Iannetta
2023-07-21 7:49 ` [PATCH 6/7] kvx: Add opcodes file Paul Iannetta
2023-07-21 7:49 ` [PATCH 7/7] kvx: Add toplevel files Paul Iannetta
2023-07-21 8:29 ` [PATCH 0/7] kvx: New port Nick Clifton
[not found] ` <20230721090932.pspnpq2q2wjnshrh@ws2202.lin.mbt.kalray.eu>
[not found] ` <2050791e-38ee-5719-037f-c03c456f3e3d@redhat.com>
2023-07-21 16:47 ` Paul Iannetta
2023-07-21 17:00 ` Paul Iannetta
2023-07-21 8:57 ` YunQiang Su
2023-07-21 16:51 ` Paul Iannetta
2023-07-24 9:04 ` Nick Clifton
2023-07-24 9:38 ` Paul Iannetta
2023-07-24 9:28 ` Nick Clifton
2023-07-24 12:33 ` Paul Iannetta
2023-07-24 14:30 ` Paul Iannetta
2023-07-25 14:13 ` Nick Clifton
2023-07-26 7:36 ` Paul Iannetta
2023-07-26 13:32 ` Michael Matz
2023-07-26 21:46 ` Paul Iannetta
2023-07-26 21:24 ` [PATCH v2] " Paul Iannetta
2023-07-31 14:52 ` Nick Clifton [this message]
2023-08-02 14:38 ` [PATCH v3] " Paul Iannetta
2023-08-16 13:24 ` Nick Clifton
2023-08-17 9:45 ` Luis Machado
2023-08-17 15:09 ` Paul Iannetta
2023-08-17 16:28 ` Luis Machado
2023-08-17 23:20 ` Alan Modra
2023-08-18 7:13 ` Paul Iannetta
2023-08-17 12:46 ` Paul Iannetta
2023-07-24 9:53 ` [PATCH 0/7] " Nick Clifton
2023-07-24 12:27 ` Paul Iannetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e04dc97d-24b3-79dc-3b21-3684cd84a421@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=piannetta@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).