Re: [PATCH v3] kvx: New port.

[Luis Machado <luis.machado@arm.com>]

Hi Paul,

On 8/17/23 16:09, Paul Iannetta wrote:
> On Thu, Aug 17, 2023 at 10:45:09AM +0100, Luis Machado wrote:
>>
>> The builders have caught a few hiccups related to printf modifiers for 32-bit architectures.
>>
>> Could you please take a look at those? A build with --enable-targets=all is recommended
>> to catch those.
>>
>> See https://builder.sourceware.org/buildbot/#/builders/170/builds/3977.
>>
>> --
>>
>> In file included from ../../binutils-gdb/bfd/elfnn-kvx.c:22:
>> ../../binutils-gdb/bfd/elfxx-kvx-relocs.h:74:3: error: conversion from ‘long long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Werror=overflow]
>>    74 |   0xffffffffffffffff,   /* dst_mask */
>>       |   ^~~~~~~~~~~~~~~~~~
>> bfd.h:3204:15: note: in definition of macro ‘HOWTO’
>>  3204 |     src_mask, dst_mask, func, name }
>>       |               ^~~~~~~~
>> ../../binutils-gdb/bfd/elfnn-kvx.c: In function ‘elf32_kvx_stub_name’:
>> ../../binutils-gdb/bfd/elfnn-kvx.c:740:28: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 6 has type ‘bfd_vma’ {aka ‘const unsigned int’} [-Werror=format=]
>>   740 |  snprintf (stub_name, len, "%08x_%s+%" PRIx64 "x",
>>       |                            ^~~~~~~~~~~
>> ......
>>   743 |     rel->r_addend);
>>       |     ~~~~~~~~~~~~~
>>       |        |
>>       |        bfd_vma {aka const unsigned int}
>> cc1: all warnings being treated as errors
>> make[3]: *** [Makefile:1758: elf32-kvx.lo] Error 1
>>
> 
> Hi,
> 
> I was not able to fully reproduce but the attached patch should fix
> the build errors.  However, we did not do any validation on 32 bits
> hosts, so I think that even with this patch it will not be enough to
> pass `mack check'.  I'll work on it so that everything pass by the end
> of the week, so you may want to wait until I have also fixed the
> validation before applying the patch.

Thanks! If 32-bit is supported for kvx, you might want to give the testsuite for that particular mode, just to make sure things are sane.

After pushing the changes, you may want to keep an eye out for the following:

https://builder.sourceware.org/buildbot/#/builders?tags=binutils
https://builder.sourceware.org/buildbot/#/builders?tags=gdb

You should see some going back to green.

> 
> Paul
> 
>