public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Paul Iannetta <piannetta@kalrayinc.com>, binutils@sourceware.org
Subject: Re: [PATCH 0/7] kvx: New port.
Date: Mon, 24 Jul 2023 10:28:07 +0100	[thread overview]
Message-ID: <7a676623-4084-c210-3dcd-37e813aeb32d@redhat.com> (raw)
In-Reply-To: <20230721074956.7188-1-piannetta@kalrayinc.com>

Hi Paul,

   I tried compiling the binutils for a kvx-elf target with your
   patches applied and I ran across a compile time warning/error:

gas/config/kvx-parse.c: In function 'parse_with_restarts':
gas/config/kvx-parse.c:766:3: error: using a dangling pointer to '__buf_tok' [-Werror=dangling-pointer=]
   766 |   printf_debug (1, "\nEntering rule: %d (Trying to match: %s (%s)[%d])\n", jump_target,
       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   767 |                 TOKEN_NAME (CLASS_ID (tok)), TOKEN_STR (tok), CLASS_ID (tok));
       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gas/config/kvx-parse.c:391:6: note: '__buf_tok' declared here
   391 | char __buf_##token[256] = { 0 }; \
       |      ^~~~~~
gas/config/kvx-parse.c:767:46: note: in expansion of macro 'TOKEN_STR'
   767 |                 TOKEN_NAME (CLASS_ID (tok)), TOKEN_STR (tok), CLASS_ID (tok));
       |                                              ^~~~~~~~~
cc1: all warnings being treated as errors

   This is with gcc v13 on a Fedora 38 box...

   It looks like the TOKEN_STR macro is doing some funky things that are not fully
   supported by gcc 13...


   On a related note, building a toolchain configure as --enable-64-bit-bfd --enable-targets=all
   results in:

/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.rodata+0xbc8): undefined reference to `kvx_elf64_vec'
/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.rodata+0x1b98): undefined reference to `kvx_elf64_vec'
/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.rodata+0x1ba0): undefined reference to `kvx_elf64_linux_vec'
collect2: error: ld returned 1 exit status

   I believe that this is because you are missing an entry for elf64-kvx.lo
   from the BFD64_BACKENDS list defined in bfd/Makefile.am...

Cheers
   Nick



  parent reply	other threads:[~2023-07-24  9:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21  7:49 Paul Iannetta
2023-07-21  7:49 ` [PATCH 1/7] kvx: Add bf files Paul Iannetta
2023-07-21  7:49 ` [PATCH 2/7] kvx: Add binutils files Paul Iannetta
2023-07-21  7:49 ` [PATCH 3/7] kvx: Add gas file Paul Iannetta
2023-07-21  7:49 ` [PATCH 4/7] kvx: Add ld files Paul Iannetta
2023-07-21  7:49 ` [PATCH 5/7] kvx: Add include files Paul Iannetta
2023-07-21  7:49 ` [PATCH 6/7] kvx: Add opcodes file Paul Iannetta
2023-07-21  7:49 ` [PATCH 7/7] kvx: Add toplevel files Paul Iannetta
2023-07-21  8:29 ` [PATCH 0/7] kvx: New port Nick Clifton
     [not found]   ` <20230721090932.pspnpq2q2wjnshrh@ws2202.lin.mbt.kalray.eu>
     [not found]     ` <2050791e-38ee-5719-037f-c03c456f3e3d@redhat.com>
2023-07-21 16:47       ` Paul Iannetta
2023-07-21 17:00       ` Paul Iannetta
2023-07-21  8:57 ` YunQiang Su
2023-07-21 16:51   ` Paul Iannetta
2023-07-24  9:04 ` Nick Clifton
2023-07-24  9:38   ` Paul Iannetta
2023-07-24  9:28 ` Nick Clifton [this message]
2023-07-24 12:33   ` Paul Iannetta
2023-07-24 14:30     ` Paul Iannetta
2023-07-25 14:13     ` Nick Clifton
2023-07-26  7:36       ` Paul Iannetta
2023-07-26 13:32         ` Michael Matz
2023-07-26 21:46           ` Paul Iannetta
2023-07-26 21:24         ` [PATCH v2] " Paul Iannetta
2023-07-31 14:52           ` Nick Clifton
2023-08-02 14:38             ` [PATCH v3] " Paul Iannetta
2023-08-16 13:24               ` Nick Clifton
2023-08-17  9:45                 ` Luis Machado
2023-08-17 15:09                   ` Paul Iannetta
2023-08-17 16:28                     ` Luis Machado
2023-08-17 23:20                     ` Alan Modra
2023-08-18  7:13                       ` Paul Iannetta
2023-08-17 12:46                 ` Paul Iannetta
2023-07-24  9:53 ` [PATCH 0/7] " Nick Clifton
2023-07-24 12:27   ` Paul Iannetta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a676623-4084-c210-3dcd-37e813aeb32d@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=piannetta@kalrayinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).