From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jan Beulich <jbeulich@suse.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4
Date: Mon, 17 Feb 2020 01:32:00 -0000 [thread overview]
Message-ID: <20200217013156.GB5570@bubble.grove.modra.org> (raw)
In-Reply-To: <CAMe9rOpGnK4wHiiOqG_V4jMo3jpjxT=+XMykGhZBKw3PdexYqg@mail.gmail.com>
On Sun, Feb 16, 2020 at 05:19:39PM -0800, H.J. Lu wrote:
> On Sun, Feb 16, 2020 at 5:06 PM Alan Modra <amodra@gmail.com> wrote:
> >
> > On Sun, Feb 16, 2020 at 08:47:56AM -0800, H.J. Lu wrote:
> > > commit 7deea9aad8 changed nosse4 to include CpuSSE4a. But AMD SSE4a is
> > > a superset of SSE3 and Intel SSE4 is a superset of SSSE3. Disable Intel
> > > SSE4 shouldn't disable AMD SSE4a. This patch restores nosse4. It also
> > > adds .sse4a and nosse4a.
> >
> > diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c
> > index 79f4cc9d25..45106bcf6d 100644
> > --- a/opcodes/i386-gen.c
> > +++ b/opcodes/i386-gen.c
> > @@ -326,6 +326,8 @@ static initializer cpu_flag_init[] =
> > { "CPU_ANY_SSE2_FLAGS",
> > "CPU_ANY_SSE3_FLAGS|CpuSSE2" },
> > { "CPU_ANY_SSE3_FLAGS",
> > + { "CPU_ANY_SSE4A_FLAGS",
> > + "CPU_ANY_SSE3_FLAGS|CpuSSE4a" },
> > "CPU_ANY_SSSE3_FLAGS|CpuSSE3|CpuSSE4a" },
> > { "CPU_ANY_SSSE3_FLAGS",
> > "CPU_ANY_SSE4_1_FLAGS|CpuSSSE3" },
> > @@ -333,8 +335,6 @@ static initializer cpu_flag_init[] =
> > "CPU_ANY_SSE4_2_FLAGS|CpuSSE4_1" },
> > { "CPU_ANY_SSE4_2_FLAGS",
> > "CpuSSE4_2" },
> > - { "CPU_ANY_SSE4_FLAGS",
> > - "CPU_ANY_SSE4_1_FLAGS|CpuSSE4a" },
> > { "CPU_ANY_AVX_FLAGS",
> > "CPU_ANY_AVX2_FLAGS|CpuF16C|CpuFMA|CpuFMA4|CpuXOP|CpuAVX" },
> > { "CPU_ANY_AVX2_FLAGS",
> >
> > Merge error?
>
> Is there anything wrong?
It doesn't compile. The CPU_ANY_SSE4A_FLAGS entry is added inside the
CPU_ANY_SSE3_FLAGS entry. Take a look at the diff.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-02-17 1:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 17:08 [PATCH] x86: fix SSE4a dependencies of ".arch .nosse*" Jan Beulich
2020-02-12 17:19 ` H.J. Lu
2020-02-16 16:48 ` [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4 H.J. Lu
2020-02-17 1:06 ` Alan Modra
2020-02-17 1:20 ` H.J. Lu
2020-02-17 1:32 ` Alan Modra [this message]
2020-02-17 3:12 ` Alan Modra
2020-02-17 4:16 ` [committed, PATCH] Don't disable SSE3 when disabling SSE4a H.J. Lu
2020-02-17 15:27 ` [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4 Jan Beulich
2020-02-17 15:30 ` H.J. Lu
2020-02-17 15:32 ` Jan Beulich
2020-02-17 15:45 ` H.J. Lu
2020-02-17 15:49 ` Jan Beulich
2020-02-17 16:53 ` H.J. Lu
2020-02-17 17:01 ` Jan Beulich
2020-02-17 17:05 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217013156.GB5570@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).