From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4
Date: Mon, 17 Feb 2020 15:27:00 -0000 [thread overview]
Message-ID: <4f3e5233-fb2f-a957-2788-8ffde3939ce2@suse.com> (raw)
In-Reply-To: <CAMe9rOrfhifWFpVKh8i37x6LY8ggkALK8ck4BcLxnT5P616rpA@mail.gmail.com>
On 16.02.2020 17:47, H.J. Lu wrote:
> On Wed, Feb 12, 2020 at 9:18 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> On Wed, Feb 12, 2020 at 9:08 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>
>>> Since ".arch sse4a" enables SSE3 and earlier, disabling SSE3 should also
>>> disable SSE4a. And as per its name, ".arch .nosse4" should also do so.
>>>
>>> gas/
>>> 2020-02-XX Jan Beulich <jbeulich@suse.com>
>>>
>>> * config/tc-i386.c (cpu_noarch): Use CPU_ANY_SSE4_FLAGS in
>>> "nosse4" entry.
>>>
>>> opcodes/
>>> 2020-02-XX Jan Beulich <jbeulich@suse.com>
>>>
>>> * i386-gen.c (cpu_flag_init): Move CpuSSE4a from
>>> CPU_ANY_SSE_FLAGS entry to CPU_ANY_SSE3_FLAGS one. Add
>>> CPU_ANY_SSE4_FLAGS entry.
>>> * i386-init.h: Re-generate.
>>>
>>
>> OK.
>>
>> Thanks.
>
> commit 7deea9aad8 changed nosse4 to include CpuSSE4a. But AMD SSE4a is
> a superset of SSE3 and Intel SSE4 is a superset of SSSE3. Disable Intel
> SSE4 shouldn't disable AMD SSE4a. This patch restores nosse4. It also
> adds .sse4a and nosse4a.
And where is it said that "nosse4" means only the Intel flavors? As
said in the commit message of said change, to me the clear implication
is that anything called SSE4* will get disabled.
Jan
next prev parent reply other threads:[~2020-02-17 15:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 17:08 [PATCH] x86: fix SSE4a dependencies of ".arch .nosse*" Jan Beulich
2020-02-12 17:19 ` H.J. Lu
2020-02-16 16:48 ` [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4 H.J. Lu
2020-02-17 1:06 ` Alan Modra
2020-02-17 1:20 ` H.J. Lu
2020-02-17 1:32 ` Alan Modra
2020-02-17 3:12 ` Alan Modra
2020-02-17 4:16 ` [committed, PATCH] Don't disable SSE3 when disabling SSE4a H.J. Lu
2020-02-17 15:27 ` Jan Beulich [this message]
2020-02-17 15:30 ` [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4 H.J. Lu
2020-02-17 15:32 ` Jan Beulich
2020-02-17 15:45 ` H.J. Lu
2020-02-17 15:49 ` Jan Beulich
2020-02-17 16:53 ` H.J. Lu
2020-02-17 17:01 ` Jan Beulich
2020-02-17 17:05 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3e5233-fb2f-a957-2788-8ffde3939ce2@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).