public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4
Date: Sun, 16 Feb 2020 16:48:00 -0000	[thread overview]
Message-ID: <CAMe9rOrfhifWFpVKh8i37x6LY8ggkALK8ck4BcLxnT5P616rpA@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOprBKRvUA5=KANDewxtdc+-N=1R7DnziB8x=LiW9TECsA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On Wed, Feb 12, 2020 at 9:18 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Wed, Feb 12, 2020 at 9:08 AM Jan Beulich <jbeulich@suse.com> wrote:
> >
> > Since ".arch sse4a" enables SSE3 and earlier, disabling SSE3 should also
> > disable SSE4a. And as per its name, ".arch .nosse4" should also do so.
> >
> > gas/
> > 2020-02-XX  Jan Beulich  <jbeulich@suse.com>
> >
> >         * config/tc-i386.c (cpu_noarch): Use CPU_ANY_SSE4_FLAGS in
> >         "nosse4" entry.
> >
> > opcodes/
> > 2020-02-XX  Jan Beulich  <jbeulich@suse.com>
> >
> >         * i386-gen.c (cpu_flag_init): Move CpuSSE4a from
> >         CPU_ANY_SSE_FLAGS entry to CPU_ANY_SSE3_FLAGS one. Add
> >         CPU_ANY_SSE4_FLAGS entry.
> >         * i386-init.h: Re-generate.
> >
>
> OK.
>
> Thanks.

commit 7deea9aad8 changed nosse4 to include CpuSSE4a.  But AMD SSE4a is
a superset of SSE3 and Intel SSE4 is a superset of SSSE3.  Disable Intel
SSE4 shouldn't disable AMD SSE4a.  This patch restores nosse4.  It also
adds .sse4a and nosse4a.

-- 
H.J.

[-- Attachment #2: 0001-x86-Don-t-disable-SSE4a-when-disabling-SSE4.patch --]
[-- Type: application/x-patch, Size: 5736 bytes --]

  reply	other threads:[~2020-02-16 16:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 17:08 [PATCH] x86: fix SSE4a dependencies of ".arch .nosse*" Jan Beulich
2020-02-12 17:19 ` H.J. Lu
2020-02-16 16:48   ` H.J. Lu [this message]
2020-02-17  1:06     ` [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4 Alan Modra
2020-02-17  1:20       ` H.J. Lu
2020-02-17  1:32         ` Alan Modra
2020-02-17  3:12           ` Alan Modra
2020-02-17  4:16             ` [committed, PATCH] Don't disable SSE3 when disabling SSE4a H.J. Lu
2020-02-17 15:27     ` [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4 Jan Beulich
2020-02-17 15:30       ` H.J. Lu
2020-02-17 15:32         ` Jan Beulich
2020-02-17 15:45           ` H.J. Lu
2020-02-17 15:49             ` Jan Beulich
2020-02-17 16:53               ` H.J. Lu
2020-02-17 17:01                 ` Jan Beulich
2020-02-17 17:05                   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOrfhifWFpVKh8i37x6LY8ggkALK8ck4BcLxnT5P616rpA@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).