public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] binutils/readelf: fix indentation in process_dynamic_section
@ 2022-02-25 22:24 Simon Marchi
  2022-03-04 15:58 ` Simon Marchi
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Marchi @ 2022-02-25 22:24 UTC (permalink / raw)
  To: binutils; +Cc: Simon Marchi

Clangd shows a warning about misleading indentation in this file, fix
it.

Change-Id: I43a7f4f4c75dd080af614222b980526f5debf297
---
 binutils/readelf.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/binutils/readelf.c b/binutils/readelf.c
index b208db593342..16efe1dfd2db 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -11297,12 +11297,12 @@ the .dynstr section doesn't match the DT_STRTAB and DT_STRSZ tags\n"));
 		filedata->file_name,
 		filedata->dynamic_addr,
 		(unsigned long) filedata->dynamic_nent);
-	  else
-	    printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n",
-			      "\nDynamic section at offset 0x%lx contains %lu entries:\n",
-			      (unsigned long) filedata->dynamic_nent),
-		    filedata->dynamic_addr,
-		    (unsigned long) filedata->dynamic_nent);
+      else
+	printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n",
+			  "\nDynamic section at offset 0x%lx contains %lu entries:\n",
+			  (unsigned long) filedata->dynamic_nent),
+		filedata->dynamic_addr,
+		(unsigned long) filedata->dynamic_nent);
     }
   if (do_dynamic)
     printf (_("  Tag        Type                         Name/Value\n"));

base-commit: 820ed8af6a757408873d8955a2db03b0989fdaeb
-- 
2.35.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] binutils/readelf: fix indentation in process_dynamic_section
  2022-02-25 22:24 [PATCH] binutils/readelf: fix indentation in process_dynamic_section Simon Marchi
@ 2022-03-04 15:58 ` Simon Marchi
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2022-03-04 15:58 UTC (permalink / raw)
  To: binutils

I pushed this, since it's quite trivial.  I added a ChangeLog entry, which I initially
forgot.

Simon

On 2022-02-25 17:24, Simon Marchi wrote:
> Clangd shows a warning about misleading indentation in this file, fix
> it.
> 
> Change-Id: I43a7f4f4c75dd080af614222b980526f5debf297
> ---
>  binutils/readelf.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/binutils/readelf.c b/binutils/readelf.c
> index b208db593342..16efe1dfd2db 100644
> --- a/binutils/readelf.c
> +++ b/binutils/readelf.c
> @@ -11297,12 +11297,12 @@ the .dynstr section doesn't match the DT_STRTAB and DT_STRSZ tags\n"));
>  		filedata->file_name,
>  		filedata->dynamic_addr,
>  		(unsigned long) filedata->dynamic_nent);
> -	  else
> -	    printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n",
> -			      "\nDynamic section at offset 0x%lx contains %lu entries:\n",
> -			      (unsigned long) filedata->dynamic_nent),
> -		    filedata->dynamic_addr,
> -		    (unsigned long) filedata->dynamic_nent);
> +      else
> +	printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n",
> +			  "\nDynamic section at offset 0x%lx contains %lu entries:\n",
> +			  (unsigned long) filedata->dynamic_nent),
> +		filedata->dynamic_addr,
> +		(unsigned long) filedata->dynamic_nent);
>      }
>    if (do_dynamic)
>      printf (_("  Tag        Type                         Name/Value\n"));
> 
> base-commit: 820ed8af6a757408873d8955a2db03b0989fdaeb

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-04 15:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25 22:24 [PATCH] binutils/readelf: fix indentation in process_dynamic_section Simon Marchi
2022-03-04 15:58 ` Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).