Re: [PATCH v2] ld: Turn on --error-execstack/--error-rwx-segments

[Jan Beulich <jbeulich@suse.com>]

On 26.01.2024 22:45, H.J. Lu wrote:
> --- a/ld/lexsup.c
> +++ b/ld/lexsup.c
> @@ -1947,6 +1947,17 @@ parse_args (unsigned argc, char **argv)
>        && command_line.check_section_addresses < 0)
>      command_line.check_section_addresses = 0;
>  
> +  /* Override --no-error-execstack and --no-warn-execstack and turn on
> +     --error-execstack for --warn-execstack and --error-rwx-segments for
> +     --warn-rwx-segments if --fatal-warnings is used.  */
> +  if (config.fatal_warnings)
> +    {
> +      if (link_info.warn_execstack)
> +	link_info.error_execstack = 1;
> +      if (!link_info.no_warn_rwx_segments)
> +	link_info.warn_is_error_for_rwx_segments = 1;
> +    }
> +
>    if (export_list)
>      {
>        struct bfd_elf_version_expr *head = export_list->head.list;

If I'm not mistaken and if the comment is properly describing things,
this placement of the addition means --no-* last on the command line
wouldn't be honored anymore, when later arguments ought to override
earlier ones.

Jan