From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2] ld: Turn on --error-execstack/--error-rwx-segments
Date: Mon, 29 Jan 2024 04:59:39 -0800 [thread overview]
Message-ID: <CAMe9rOr1Du9OytqUbV885UG9soaF=4-XU5CTCgM-sViiaHGq_g@mail.gmail.com> (raw)
In-Reply-To: <bee2976a-0128-4efd-af2d-553e76520194@suse.com>
On Sun, Jan 28, 2024 at 11:33 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 28.01.2024 16:04, H.J. Lu wrote:
> > If there is no objection, I will check it tomorrow.
>
> I'm surprised here: Shouldn't a non-trivial (small != trivial) change
> like this require active approval? At the very least I can only once
> again mention that waiting for just a single day is too little, imo.
>
My patch changes a "warning":
[hjl@gnu-cfl-3 ld]$ touch x.s
[hjl@gnu-cfl-3 ld]$ gcc -c x.s
[hjl@gnu-cfl-3 ld]$ ld -shared -z stack-size=0x123400 --fatal-warnings
--warn-execstack --no-error-execstack x.o
ld: warning: x.o: missing .note.GNU-stack section implies executable stack
ld: NOTE: This behaviour is deprecated and will be removed in a future
version of the linker
[hjl@gnu-cfl-3 ld]$ echo $?
1
[hjl@gnu-cfl-3 ld]$
to an error:
[hjl@gnu-cfl-3 ld]$ ./ld-new -shared -z stack-size=0x123400
--fatal-warnings --warn-execstack --no-error-execstack x.o
./ld-new: error: x.o: is triggering the generation of an executable
stack because it does not have a .note.GNU-stack section
./ld-new: failed to set dynamic section sizes: file format not recognized
[hjl@gnu-cfl-3 ld]$
I view it as trivial since it only corrects the incorrect linker
message.
--
H.J.
next prev parent reply other threads:[~2024-01-29 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 21:45 H.J. Lu
2024-01-28 15:04 ` H.J. Lu
2024-01-29 7:33 ` Jan Beulich
2024-01-29 12:59 ` H.J. Lu [this message]
2024-01-29 7:30 ` Jan Beulich
2024-01-29 13:03 ` H.J. Lu
2024-01-29 14:03 ` Jan Beulich
2024-01-29 14:10 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOr1Du9OytqUbV885UG9soaF=4-XU5CTCgM-sViiaHGq_g@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).