Re: [PATCH] opcodes/riscv: style csr names as registers

[Tsukasa OI <research_trasio@irq.a4lg.com>]

On 2022/10/03 19:13, Andrew Burgess via Binutils wrote:
> While reviewing another patch I noticed that RISC-V CSR names are
> given the text style, not the register style.  This patch fixes this
> mistake.

LGTM, from the author of "another patch".

I felt it's not obvious as the rest and did not include in the first
batch of my patchset.  But I can definitely say that it is worth
discussing about it and I agree with the change.

Thanks,
Tsukasa

> ---
>  opcodes/riscv-dis.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
> index 6ac69490b78..031c19334fa 100644
> --- a/opcodes/riscv-dis.c
> +++ b/opcodes/riscv-dis.c
> @@ -547,7 +547,8 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info
>  	      }
>  
>  	    if (riscv_csr_hash[csr] != NULL)
> -	      print (info->stream, dis_style_text, "%s", riscv_csr_hash[csr]);
> +	      print (info->stream, dis_style_register, "%s",
> +		     riscv_csr_hash[csr]);
>  	    else
>  	      print (info->stream, dis_style_text, "0x%x", csr);
>  	    break;