public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Nelson Chu <nelson@rivosinc.com>,
	Kito Cheng <kito.cheng@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Cc: binutils@sourceware.org
Subject: [PATCH 4/5] opcodes/riscv-dis.c: Make XLEN variable static
Date: Sat,  8 Oct 2022 04:34:26 +0000	[thread overview]
Message-ID: <6e3a9c235e317f441b4383b3daa68f2051bdc149.1665203660.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1665203660.git.research_trasio@irq.a4lg.com>

Before changing the core disassembler, we take care of minor code clarity
issues and improve readability.

Since xlen variable is not (and should not) used outside riscv-dis.c,
this commit makes this variable static.

opcodes/ChangeLog:

	* riscv-dis.c (xlen): Make this variable static.
---
 opcodes/riscv-dis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
index 608670bed7f..27e1978d428 100644
--- a/opcodes/riscv-dis.c
+++ b/opcodes/riscv-dis.c
@@ -33,7 +33,7 @@
 #include <ctype.h>
 
 /* Current XLEN for the disassembler.  */
-unsigned xlen = 0;
+static unsigned xlen = 0;
 
 /* Default ISA specification version (constant as of now).  */
 static enum riscv_spec_class default_isa_spec = ISA_SPEC_CLASS_DRAFT - 1;
-- 
2.34.1


  parent reply	other threads:[~2022-10-08  4:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08  4:34 [PATCH 0/5] RISC-V: Requirements for disassembler optimizations 1 (Tidying part) Tsukasa OI
2022-10-08  4:34 ` [PATCH 1/5] opcodes/riscv-dis.c: Tidying with comments/clarity Tsukasa OI
2022-10-08  4:34 ` [PATCH 2/5] opcodes/riscv-dis.c: Tidying with spacing Tsukasa OI
2022-10-08  4:34 ` [PATCH 3/5] opcodes/riscv-dis.c: Use bool type whenever possible Tsukasa OI
2022-10-08  4:34 ` Tsukasa OI [this message]
2022-10-08  4:34 ` [PATCH 5/5] opcodes/riscv-dis.c: Remove last_map_state Tsukasa OI
2022-10-14  3:47 ` [PATCH 0/5] RISC-V: Requirements for disassembler optimizations 1 (Tidying part) Nelson Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e3a9c235e317f441b4383b3daa68f2051bdc149.1665203660.git.research_trasio@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=binutils@sourceware.org \
    --cc=kito.cheng@sifive.com \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).