From: Xi Ruoyao <xry111@xry111.site>
To: caiyinyu <caiyinyu@loongson.cn>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
WANG Xuerui <i.swmail@xen0n.name>,
Fangrui Song <maskray@google.com>, Alan Modra <amodra@gmail.com>
Cc: Carlos O'Donell <carlos@redhat.com>,
libc-alpha <libc-alpha@sourceware.org>,
binutils@sourceware.org, liuzhensong <liuzhensong@loongson.cn>
Subject: Re: glibc 2.36 - Slushy freeze (3 weeks to release)
Date: Tue, 12 Jul 2022 21:00:52 +0800 [thread overview]
Message-ID: <77282eda63ea435d21eb38485651fc5551b4c7e6.camel@xry111.site> (raw)
In-Reply-To: <12b025a3-7d10-a9c6-d9e1-54bd3fdca5fe@loongson.cn>
On Tue, 2022-07-12 at 20:48 +0800, caiyinyu wrote:
> I can add R_LARCH_NONE handling in boostraping, but there is another
> problem:
>
> binutils 2.38 generates R_LARCH_IRELATIVEs in .rela.plt and now glibc
> loongarch ld.so has no R_LARCH_IRELATIVEs handling in elf_machine_lazy_rel, this will
> cause ifunc tests to fail.
>
> I did not find the way to disable ifunc tests by adding configure
> options (if glibc community can accept loongarch port being tested without ifunc tests),
> so we have to wait until related patches are merged into binutils community.
"libc_cv_ld_gnu_indirect_function=no" (just append it into configure
command line, not "--libc_cv_...", nor "--disable-...") will do the job.
I'm not sure how much effort is needed to fix R_LARCH_IRELATIVE issue.
If it's trivial I still suggests to get it reviewed and accepted by
binutils ASAP. But if it's very tricky (like R_LARCH_NONE) we can
disable ifunc support for now by setting
libc_cv_ld_gnu_indirect_function=no in machine-specific configure.ac
(use commit 600c13b "hurd: disable ifunc for now" as a reference).
> Or maybe we can add the following patch back now, and remove it when
> binutils fix R_LARCH_IRELATIVE's problems.
I don't think it's an option: if a shared object is loaded fine with
Glibc-2.36 but rejected by 2.37, we call it a "regression" or "bug".
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-07-12 13:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fef8c3c7-fd30-d8b5-e539-f0f21d562c51@redhat.com>
2022-07-11 16:06 ` Xi Ruoyao
2022-07-11 19:10 ` Adhemerval Zanella Netto
2022-07-12 0:48 ` Xi Ruoyao
2022-07-12 1:02 ` Xi Ruoyao
2022-07-12 2:32 ` Alan Modra
2022-07-12 4:24 ` Fangrui Song
2022-07-12 6:19 ` Jan Beulich
2022-07-12 6:42 ` WANG Xuerui
2022-07-12 7:33 ` Florian Weimer
2022-07-12 8:49 ` Xi Ruoyao
2022-07-12 8:58 ` Florian Weimer
2022-07-12 9:24 ` Xi Ruoyao
2022-07-12 10:21 ` Adhemerval Zanella Netto
2022-07-12 11:01 ` Adhemerval Zanella Netto
2022-07-12 12:15 ` Michael Matz
2022-07-12 13:17 ` Florian Weimer
2022-07-12 13:28 ` Michael Matz
2022-07-15 22:34 ` Hans-Peter Nilsson
2022-07-12 12:48 ` caiyinyu
2022-07-12 13:00 ` Xi Ruoyao [this message]
2022-07-12 7:33 ` Andrew Waterman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77282eda63ea435d21eb38485651fc5551b4c7e6.camel@xry111.site \
--to=xry111@xry111.site \
--cc=adhemerval.zanella@linaro.org \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=caiyinyu@loongson.cn \
--cc=carlos@redhat.com \
--cc=i.swmail@xen0n.name \
--cc=libc-alpha@sourceware.org \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).