* [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
@ 2023-08-03 20:33 vladimir.mezentsev
2023-08-17 4:22 ` YunQiang Su
0 siblings, 1 reply; 10+ messages in thread
From: vladimir.mezentsev @ 2023-08-03 20:33 UTC (permalink / raw)
To: binutils; +Cc: Vladimir Mezentsev
From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
gprofng/ChangeLog
2023-08-03 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
PR gprofng/30700
* testsuite/gprofng.display/gp-collect-app_F.exp: Fix -name argument
for sub-experiment filtering.
---
gprofng/testsuite/gprofng.display/gp-collect-app_F.exp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
index f791b0f7a95..02bcc8e5b49 100644
--- a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
+++ b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
@@ -46,11 +46,11 @@ proc run_gp_collect_app { subExpCnt F_opt } {
return -code break
}
- set output [run_native_host_cmd "find $tdir -name '*x1.er' | wc -l"]
+ set output [run_native_host_cmd "find $tdir -name '*_x?.er' | wc -l"]
set subExp [lindex $output 1]
if { $subExp != $subExpCnt } then {
set out [lindex $output 1]
- send_log "Test failed for -F $F_opt. subExp=$subExp. Shold be $subExpCnt\n"
+ send_log "Test failed for -F $F_opt. subExp=$subExp. Should be $subExpCnt\n"
fail $tdir
return -code break
}
--
2.31.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-03 20:33 [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails vladimir.mezentsev
@ 2023-08-17 4:22 ` YunQiang Su
2023-08-17 18:44 ` Vladimir Mezentsev
0 siblings, 1 reply; 10+ messages in thread
From: YunQiang Su @ 2023-08-17 4:22 UTC (permalink / raw)
To: vladimir.mezentsev; +Cc: binutils
Vladimir Mezentsev via Binutils <binutils@sourceware.org> 于2023年8月4日周五 04:34写道：
>
> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> gprofng/ChangeLog
> 2023-08-03 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> PR gprofng/30700
> * testsuite/gprofng.display/gp-collect-app_F.exp: Fix -name argument
> for sub-experiment filtering.
With your patch, It seems that this test still fails.
And in fact there are 3 failures for Gprofng on x86_64-linux ( I test
it on Debian):
testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/display.exp
completed in 7 seconds
Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-archive.exp
...
mkdir -p tmpdir/gp-archive
% timeout 300 sh -c 'mkdir -p tmpdir/gp-archive' 2>&1
cd tmpdir/gp-archive && cat
/home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
/home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
collect app -p on -a off -O exp.er ./a.out
% timeout 300 sh -c 'cd tmpdir/gp-archive && cat
/home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
/home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
collect app -p on -a off -O exp.er ./a.out' 2>&1
Experiment is not created in tmpdir/gp-archive
FAIL: tmpdir/gp-archive
testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-archive.exp
completed in 0 seconds
Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
...
mkdir -p tmpdir/gp-collect-app_F
% timeout 300 sh -c 'mkdir -p tmpdir/gp-collect-app_F' 2>&1
cd tmpdir/gp-collect-app_F &&
/home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
collect app -p on -a off -F 'off' -O exp.er sh -c 'mkdir t && touch
t/x; rm -rf t'
% timeout 300 sh -c 'cd tmpdir/gp-collect-app_F &&
/home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
collect app -p on -a off -F 'off' -O exp.er sh -c 'mkdir t && touch
t/x; rm -rf t' ' 2>&1
Experiment is not created in tmpdir/gp-collect-app_F
FAIL: tmpdir/gp-collect-app_F
testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
completed in 0 seconds
Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/setpath_map.exp
...
mkdir -p tmpdir/setpath_map/src
% timeout 300 sh -c 'mkdir -p tmpdir/setpath_map/src' 2>&1
cd tmpdir/setpath_map && cat
/home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
/home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
collect app -p on -a off -O exp.er ./a.out
% timeout 300 sh -c 'cd tmpdir/setpath_map && cat
/home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
/home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
collect app -p on -a off -O exp.er ./a.out' 2>&1
Experiment is not created in tmpdir/setpath_map
FAIL: tmpdir/setpath_map
> ---
> gprofng/testsuite/gprofng.display/gp-collect-app_F.exp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> index f791b0f7a95..02bcc8e5b49 100644
> --- a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> +++ b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> @@ -46,11 +46,11 @@ proc run_gp_collect_app { subExpCnt F_opt } {
> return -code break
> }
>
> - set output [run_native_host_cmd "find $tdir -name '*x1.er' | wc -l"]
> + set output [run_native_host_cmd "find $tdir -name '*_x?.er' | wc -l"]
> set subExp [lindex $output 1]
> if { $subExp != $subExpCnt } then {
> set out [lindex $output 1]
> - send_log "Test failed for -F $F_opt. subExp=$subExp. Shold be $subExpCnt\n"
> + send_log "Test failed for -F $F_opt. subExp=$subExp. Should be $subExpCnt\n"
> fail $tdir
> return -code break
> }
> --
> 2.31.1
>
--
YunQiang Su
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-17 4:22 ` YunQiang Su
@ 2023-08-17 18:44 ` Vladimir Mezentsev
2023-08-18 2:11 ` YunQiang Su
0 siblings, 1 reply; 10+ messages in thread
From: Vladimir Mezentsev @ 2023-08-17 18:44 UTC (permalink / raw)
To: YunQiang Su; +Cc: binutils
I cannot reproduce the problem on this Debian:
% uname -a
Linux gcc14 6.1.0-11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4
(2023-08-08) x86_64 GNU/Linux
% make check
...
Test run by vmezents on Thu Aug 17 18:32:49 2023
Native configuration is x86_64-pc-linux-gnu
=== gprofng tests ===
Schedule of variations:
unix
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file
for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for
target.
Using
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/display.exp
...
Running
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-archive.exp
...
Running
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
...
Running
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/setpath_map.exp
...
=== gprofng Summary ===
# of expected passes 6
make[2]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
make[1]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
How did you configure your build ?
Could you send me gprofng/gprofng.log from your build directory.
Thank you,
-Vladimir
On 8/16/23 21:22, YunQiang Su wrote:
> Vladimir Mezentsev via Binutils <binutils@sourceware.org> 于2023年8月4日周五 04:34写道：
>> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>
>> gprofng/ChangeLog
>> 2023-08-03 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>
>> PR gprofng/30700
>> * testsuite/gprofng.display/gp-collect-app_F.exp: Fix -name argument
>> for sub-experiment filtering.
> With your patch, It seems that this test still fails.
> And in fact there are 3 failures for Gprofng on x86_64-linux ( I test
> it on Debian):
>
> testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/display.exp
> completed in 7 seconds
> Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-archive.exp
> ...
> mkdir -p tmpdir/gp-archive
> % timeout 300 sh -c 'mkdir -p tmpdir/gp-archive' 2>&1
> cd tmpdir/gp-archive && cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out
> % timeout 300 sh -c 'cd tmpdir/gp-archive && cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out' 2>&1
> Experiment is not created in tmpdir/gp-archive
> FAIL: tmpdir/gp-archive
> testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-archive.exp
> completed in 0 seconds
> Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> ...
> mkdir -p tmpdir/gp-collect-app_F
> % timeout 300 sh -c 'mkdir -p tmpdir/gp-collect-app_F' 2>&1
> cd tmpdir/gp-collect-app_F &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -F 'off' -O exp.er sh -c 'mkdir t && touch
> t/x; rm -rf t'
> % timeout 300 sh -c 'cd tmpdir/gp-collect-app_F &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -F 'off' -O exp.er sh -c 'mkdir t && touch
> t/x; rm -rf t' ' 2>&1
> Experiment is not created in tmpdir/gp-collect-app_F
> FAIL: tmpdir/gp-collect-app_F
> testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> completed in 0 seconds
> Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/setpath_map.exp
> ...
> mkdir -p tmpdir/setpath_map/src
> % timeout 300 sh -c 'mkdir -p tmpdir/setpath_map/src' 2>&1
> cd tmpdir/setpath_map && cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out
> % timeout 300 sh -c 'cd tmpdir/setpath_map && cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out' 2>&1
> Experiment is not created in tmpdir/setpath_map
> FAIL: tmpdir/setpath_map
>
>> ---
>> gprofng/testsuite/gprofng.display/gp-collect-app_F.exp | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>> index f791b0f7a95..02bcc8e5b49 100644
>> --- a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>> +++ b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>> @@ -46,11 +46,11 @@ proc run_gp_collect_app { subExpCnt F_opt } {
>> return -code break
>> }
>>
>> - set output [run_native_host_cmd "find $tdir -name '*x1.er' | wc -l"]
>> + set output [run_native_host_cmd "find $tdir -name '*_x?.er' | wc -l"]
>> set subExp [lindex $output 1]
>> if { $subExp != $subExpCnt } then {
>> set out [lindex $output 1]
>> - send_log "Test failed for -F $F_opt. subExp=$subExp. Shold be $subExpCnt\n"
>> + send_log "Test failed for -F $F_opt. subExp=$subExp. Should be $subExpCnt\n"
>> fail $tdir
>> return -code break
>> }
>> --
>> 2.31.1
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-17 18:44 ` Vladimir Mezentsev
@ 2023-08-18 2:11 ` YunQiang Su
2023-08-18 5:01 ` Vladimir Mezentsev
0 siblings, 1 reply; 10+ messages in thread
From: YunQiang Su @ 2023-08-18 2:11 UTC (permalink / raw)
To: Vladimir Mezentsev; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 3436 bytes --]
Vladimir Mezentsev <vladimir.mezentsev@oracle.com> 于2023年8月18日周五 02:44写道：
>
> I cannot reproduce the problem on this Debian:
> % uname -a
> Linux gcc14 6.1.0-11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4
> (2023-08-08) x86_64 GNU/Linux
>
$ uname -a
Linux vm-1 6.0.0-0.deb11.6-amd64 #1 SMP PREEMPT_DYNAMIC Debian
6.0.12-1~bpo11+1 (2022-12-19) x86_64 GNU/Linux
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/12/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian
12.2.0-14' --with-bugurl=file:///usr/share/doc/gcc-12/README.Bugs
--enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2
--prefix=/usr --with-gcc-major-version-only --program-suffix=-12
--program-prefix=x86_64-linux-gnu- --enable-shared
--enable-linker-build-id --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix --libdir=/usr/lib
--enable-nls --enable-clocale=gnu --enable-libstdcxx-debug
--enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new
--enable-gnu-unique-object --disable-vtable-verify --enable-plugin
--enable-default-pie --with-system-zlib
--enable-libphobos-checking=release --with-target-system-zlib=auto
--enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet
--with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32
--enable-multilib --with-tune=generic
--enable-offload-targets=nvptx-none=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-gcn/usr
--enable-offload-defaulted --without-cuda-driver
--enable-checking=release --build=x86_64-linux-gnu
--host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.2.0 (Debian 12.2.0-14)
> % make check
> ...
> Test run by vmezents on Thu Aug 17 18:32:49 2023
> Native configuration is x86_64-pc-linux-gnu
>
> === gprofng tests ===
>
> Schedule of variations:
> unix
>
> Running target unix
> Using /usr/share/dejagnu/baseboards/unix.exp as board description file
> for target.
> Using /usr/share/dejagnu/config/unix.exp as generic interface file for
> target.
> Using
> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/config/default.exp
> as tool-and-target-specific interface file.
> Running
> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/display.exp
> ...
> Running
> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-archive.exp
> ...
> Running
> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> ...
> Running
> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/setpath_map.exp
> ...
>
> === gprofng Summary ===
>
> # of expected passes 6
> make[2]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
> make[1]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
>
>
>
> How did you configure your build ?
mkdir x86_64-linux-gnu
cd x86_64-linux-gnu
../configure --target=x86_64-linux-gnu --disable-gdb --disable-sim
> Could you send me gprofng/gprofng.log from your build directory.
>
See the attachment.
> Thank you,
> -Vladimir
>
>
[-- Attachment #2: gprofng.log.gz --]
[-- Type: application/x-gzip, Size: 1141 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-18 2:11 ` YunQiang Su
@ 2023-08-18 5:01 ` Vladimir Mezentsev
2023-08-18 5:09 ` YunQiang Su
2023-08-18 5:10 ` Sam James
0 siblings, 2 replies; 10+ messages in thread
From: Vladimir Mezentsev @ 2023-08-18 5:01 UTC (permalink / raw)
To: YunQiang Su; +Cc: binutils
On 8/17/23 19:11, YunQiang Su wrote:
> Vladimir Mezentsev <vladimir.mezentsev@oracle.com> 于2023年8月18日周五 02:44写道：
>> I cannot reproduce the problem on this Debian:
>> % uname -a
>> Linux gcc14 6.1.0-11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4
>> (2023-08-08) x86_64 GNU/Linux
>>
> $ uname -a
> Linux vm-1 6.0.0-0.deb11.6-amd64 #1 SMP PREEMPT_DYNAMIC Debian
> 6.0.12-1~bpo11+1 (2022-12-19) x86_64 GNU/Linux
>
> $ gcc -v
> Using built-in specs.
> COLLECT_GCC=gcc
> COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/12/lto-wrapper
> OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
> OFFLOAD_TARGET_DEFAULT=1
> Target: x86_64-linux-gnu
> Configured with: ../src/configure -v --with-pkgversion='Debian
> 12.2.0-14' --with-bugurl=file:///usr/share/doc/gcc-12/README.Bugs
> --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2
> --prefix=/usr --with-gcc-major-version-only --program-suffix=-12
> --program-prefix=x86_64-linux-gnu- --enable-shared
> --enable-linker-build-id --libexecdir=/usr/lib
> --without-included-gettext --enable-threads=posix --libdir=/usr/lib
> --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug
> --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new
> --enable-gnu-unique-object --disable-vtable-verify --enable-plugin
> --enable-default-pie --with-system-zlib
> --enable-libphobos-checking=release --with-target-system-zlib=auto
> --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet
> --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32
> --enable-multilib --with-tune=generic
> --enable-offload-targets=nvptx-none=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-gcn/usr
> --enable-offload-defaulted --without-cuda-driver
> --enable-checking=release --build=x86_64-linux-gnu
> --host=x86_64-linux-gnu --target=x86_64-linux-gnu
> Thread model: posix
> Supported LTO compression algorithms: zlib zstd
> gcc version 12.2.0 (Debian 12.2.0-14)
>
>> % make check
>> ...
>> Test run by vmezents on Thu Aug 17 18:32:49 2023
>> Native configuration is x86_64-pc-linux-gnu
>>
>> === gprofng tests ===
>>
>> Schedule of variations:
>> unix
>>
>> Running target unix
>> Using /usr/share/dejagnu/baseboards/unix.exp as board description file
>> for target.
>> Using /usr/share/dejagnu/config/unix.exp as generic interface file for
>> target.
>> Using
>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/config/default.exp
>> as tool-and-target-specific interface file.
>> Running
>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/display.exp
>> ...
>> Running
>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-archive.exp
>> ...
>> Running
>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>> ...
>> Running
>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/setpath_map.exp
>> ...
>>
>> === gprofng Summary ===
>>
>> # of expected passes 6
>> make[2]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
>> make[1]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
>>
>>
>>
>> How did you configure your build ?
> mkdir x86_64-linux-gnu
> cd x86_64-linux-gnu
> ../configure --target=x86_64-linux-gnu --disable-gdb --disable-sim
Is it legal to create a build directory inside a source tree?
Anyway, I found a bug in our script.
I haven't found yet why the test passes if I create the build directory
outside of the source tree.
Thank you,
-Vladimir
>
>> Could you send me gprofng/gprofng.log from your build directory.
>>
> See the attachment.
>
>> Thank you,
>> -Vladimir
>>
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-18 5:01 ` Vladimir Mezentsev
@ 2023-08-18 5:09 ` YunQiang Su
2023-08-18 5:10 ` Sam James
1 sibling, 0 replies; 10+ messages in thread
From: YunQiang Su @ 2023-08-18 5:09 UTC (permalink / raw)
To: Vladimir Mezentsev; +Cc: binutils
> >> How did you configure your build ?
> > mkdir x86_64-linux-gnu
> > cd x86_64-linux-gnu
> > ../configure --target=x86_64-linux-gnu --disable-gdb --disable-sim
>
> Is it legal to create a build directory inside a source tree?
>
I guess so, since most of software support it, and we use this way to build
and test binutils for years.
> Anyway, I found a bug in our script.
> I haven't found yet why the test passes if I create the build directory
> outside of the source tree.
>
Ohh, interesting problem ;)
--
YunQiang Su
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-18 5:01 ` Vladimir Mezentsev
2023-08-18 5:09 ` YunQiang Su
@ 2023-08-18 5:10 ` Sam James
2023-08-18 6:38 ` Matthias Klose
1 sibling, 1 reply; 10+ messages in thread
From: Sam James @ 2023-08-18 5:10 UTC (permalink / raw)
To: Vladimir Mezentsev; +Cc: YunQiang Su, binutils
Vladimir Mezentsev via Binutils <binutils@sourceware.org> writes:
> On 8/17/23 19:11, YunQiang Su wrote:
>> Vladimir Mezentsev <vladimir.mezentsev@oracle.com> 于2023年8月18日周五 02:44写道：
>>> I cannot reproduce the problem on this Debian:
>>> % uname -a
>>> Linux gcc14 6.1.0-11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4
>>> (2023-08-08) x86_64 GNU/Linux
>>>
>> $ uname -a
>> Linux vm-1 6.0.0-0.deb11.6-amd64 #1 SMP PREEMPT_DYNAMIC Debian
>> 6.0.12-1~bpo11+1 (2022-12-19) x86_64 GNU/Linux
>>
>> $ gcc -v
>> Using built-in specs.
>> COLLECT_GCC=gcc
>> COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/12/lto-wrapper
>> OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
>> OFFLOAD_TARGET_DEFAULT=1
>> Target: x86_64-linux-gnu
>> Configured with: ../src/configure -v --with-pkgversion='Debian
>> 12.2.0-14' --with-bugurl=file:///usr/share/doc/gcc-12/README.Bugs
>> --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2
>> --prefix=/usr --with-gcc-major-version-only --program-suffix=-12
>> --program-prefix=x86_64-linux-gnu- --enable-shared
>> --enable-linker-build-id --libexecdir=/usr/lib
>> --without-included-gettext --enable-threads=posix --libdir=/usr/lib
>> --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug
>> --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new
>> --enable-gnu-unique-object --disable-vtable-verify --enable-plugin
>> --enable-default-pie --with-system-zlib
>> --enable-libphobos-checking=release --with-target-system-zlib=auto
>> --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet
>> --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32
>> --enable-multilib --with-tune=generic
>> --enable-offload-targets=nvptx-none=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-gcn/usr
>> --enable-offload-defaulted --without-cuda-driver
>> --enable-checking=release --build=x86_64-linux-gnu
>> --host=x86_64-linux-gnu --target=x86_64-linux-gnu
>> Thread model: posix
>> Supported LTO compression algorithms: zlib zstd
>> gcc version 12.2.0 (Debian 12.2.0-14)
>>
>>> % make check
>>> ...
>>> Test run by vmezents on Thu Aug 17 18:32:49 2023
>>> Native configuration is x86_64-pc-linux-gnu
>>>
>>> === gprofng tests ===
>>>
>>> Schedule of variations:
>>> unix
>>>
>>> Running target unix
>>> Using /usr/share/dejagnu/baseboards/unix.exp as board description file
>>> for target.
>>> Using /usr/share/dejagnu/config/unix.exp as generic interface file for
>>> target.
>>> Using
>>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/config/default.exp
>>> as tool-and-target-specific interface file.
>>> Running
>>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/display.exp
>>> ...
>>> Running
>>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-archive.exp
>>> ...
>>> Running
>>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>>> ...
>>> Running
>>> /home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/setpath_map.exp
>>> ...
>>>
>>> === gprofng Summary ===
>>>
>>> # of expected passes 6
>>> make[2]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
>>> make[1]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
>>>
>>>
>>>
>>> How did you configure your build ?
>> mkdir x86_64-linux-gnu
>> cd x86_64-linux-gnu
>> ../configure --target=x86_64-linux-gnu --disable-gdb --disable-sim
>
I suspect this discussion might work better as a bug report - would
be easier to follow and reference later.
> Is it legal to create a build directory inside a source tree?
>
No, the source tree should be treated as immutable please. It's ok
to create directories within the build dir, but not the source tree.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-18 5:10 ` Sam James
@ 2023-08-18 6:38 ` Matthias Klose
2023-08-18 6:45 ` Sam James
[not found] ` <f4c4c9956ccb5bc55fe95f51ee858e3558aa6acbe8d0d0ca0e8716bafbc1fbab@mu.id>
0 siblings, 2 replies; 10+ messages in thread
From: Matthias Klose @ 2023-08-18 6:38 UTC (permalink / raw)
To: Sam James, Vladimir Mezentsev; +Cc: YunQiang Su, binutils
On 18.08.23 07:10, Sam James via Binutils wrote:
>> Is it legal to create a build directory inside a source tree?
>>
>
> No, the source tree should be treated as immutable please. It's ok
> to create directories within the build dir, but not the source tree.
you are confusing things. In general you have the option to build within the
source tree or with a separate build tree. Some projects like GCC discourage to
build within the source tree and recommend building in a separate build tree.
There is no restriction where the build tree can be located. In the past I have
seen some issue when specifying the build tree relatively to the source tree,
but in general it's the same to configure the build tree with a relative path or
an absolute path. Now if you have a separate build tree, then the source tree
should not be modified, there is no restriction to create a sub-directory for
the build. This works for ages, i.e. dpkg based packaging has no other choice
than using the root of the source tree for builds, and that works for at least
27 years.
Matthias
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
2023-08-18 6:38 ` Matthias Klose
@ 2023-08-18 6:45 ` Sam James
[not found] ` <f4c4c9956ccb5bc55fe95f51ee858e3558aa6acbe8d0d0ca0e8716bafbc1fbab@mu.id>
1 sibling, 0 replies; 10+ messages in thread
From: Sam James @ 2023-08-18 6:45 UTC (permalink / raw)
To: Matthias Klose; +Cc: Sam James, Vladimir Mezentsev, YunQiang Su, binutils
Matthias Klose <doko@debian.org> writes:
> On 18.08.23 07:10, Sam James via Binutils wrote:
>>> Is it legal to create a build directory inside a source tree?
>>>
>> No, the source tree should be treated as immutable please. It's ok
>> to create directories within the build dir, but not the source tree.
>
> you are confusing things. In general you have the option to build
I don't think I am. I just took the question to be generally about
whether you can modify the source tree. If the build tree is within
that, then it doesn't really count modulo the issue you mention below.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails
[not found] ` <f4c4c9956ccb5bc55fe95f51ee858e3558aa6acbe8d0d0ca0e8716bafbc1fbab@mu.id>
@ 2023-08-18 6:49 ` Sam James
0 siblings, 0 replies; 10+ messages in thread
From: Sam James @ 2023-08-18 6:49 UTC (permalink / raw)
To: Sam James; +Cc: Matthias Klose, Vladimir Mezentsev, YunQiang Su, binutils
Sam James <sam@gentoo.org> writes:
> Matthias Klose <doko@debian.org> writes:
>
>> On 18.08.23 07:10, Sam James via Binutils wrote:
>>>> Is it legal to create a build directory inside a source tree?
>>>>
>>> No, the source tree should be treated as immutable please. It's ok
>>> to create directories within the build dir, but not the source tree.
>>
>> you are confusing things. In general you have the option to build
>
> I don't think I am. I just took the question to be generally about
> whether you can modify the source tree. If the build tree is within
> that, then it doesn't really count modulo the issue you mention below.
Right, I get your point now -- you were saying that YunQiang Su's use
case should be fine (because it's a build dir within the source tree).
I was just saying that Vladimir can't make his own directories during
the build in the source tree.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-08-18 6:49 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 20:33 [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails vladimir.mezentsev
2023-08-17 4:22 ` YunQiang Su
2023-08-17 18:44 ` Vladimir Mezentsev
2023-08-18 2:11 ` YunQiang Su
2023-08-18 5:01 ` Vladimir Mezentsev
2023-08-18 5:09 ` YunQiang Su
2023-08-18 5:10 ` Sam James
2023-08-18 6:38 ` Matthias Klose
2023-08-18 6:45 ` Sam James
[not found] ` <f4c4c9956ccb5bc55fe95f51ee858e3558aa6acbe8d0d0ca0e8716bafbc1fbab@mu.id>
2023-08-18 6:49 ` Sam James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).