[PATCH v2] configure: remove dependencies on gmp and mpfr when gdb is disabled

[PATCH v2] configure: remove dependencies on gmp and mpfr when gdb is disabled

[Clément Chigot]

Since 991180627851801f1999d1ebbc0e569a17e47c74, the configure checks
about GMP and MPFR for gdb builds have been moved to the toplevel
configure.
However, it doesn't take into account the --disable-gdb option. Meaning
that a build without gdb will require these libraries even if not
needed.

ChangeLog:

	* configure.ac: Skip GMP and MPFR when --disable-gdb is
	provided.
	* configure: Regenerate.
---
 configure    | 4 +++-
 configure.ac | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 417fc5a970c..9cb953a197e 100755
--- a/configure
+++ b/configure
@@ -8032,7 +8032,9 @@ if test -d ${srcdir}/gcc ; then
   require_mpc=yes
 fi
 if test -d ${srcdir}/gdb ; then
-  require_gmp=yes
+  if test "x$enable_gdb" != xno; then
+   require_gmp=yes
+  fi
 fi
 
 gmplibs="-lmpfr -lgmp"
diff --git a/configure.ac b/configure.ac
index 3a1eb0357e5..e95a9ed116e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1585,7 +1585,9 @@ if test -d ${srcdir}/gcc ; then
   require_mpc=yes
 fi
 if test -d ${srcdir}/gdb ; then
-  require_gmp=yes
+  if test "x$enable_gdb" != xno; then
+   require_gmp=yes
+  fi
 fi
 
 gmplibs="-lmpfr -lgmp"
-- 
2.25.1

Re: [PATCH v2] configure: remove dependencies on gmp and mpfr when gdb is disabled

[Clément Chigot]

Hi Nick, Andrew,

On Tue, Jan 3, 2023 at 5:25 PM Clément Chigot <chigot@adacore.com> wrote:
>
> Since 991180627851801f1999d1ebbc0e569a17e47c74, the configure checks
> about GMP and MPFR for gdb builds have been moved to the toplevel
> configure.
> However, it doesn't take into account the --disable-gdb option. Meaning
> that a build without gdb will require these libraries even if not
> needed.
>
> ChangeLog:
>
>         * configure.ac: Skip GMP and MPFR when --disable-gdb is
>         provided.
>         * configure: Regenerate.
> ---
>  configure    | 4 +++-
>  configure.ac | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 417fc5a970c..9cb953a197e 100755
> --- a/configure
> +++ b/configure
> @@ -8032,7 +8032,9 @@ if test -d ${srcdir}/gcc ; then
>    require_mpc=yes
>  fi
>  if test -d ${srcdir}/gdb ; then
> -  require_gmp=yes
> +  if test "x$enable_gdb" != xno; then
> +   require_gmp=yes
> +  fi
>  fi
>
>  gmplibs="-lmpfr -lgmp"
> diff --git a/configure.ac b/configure.ac
> index 3a1eb0357e5..e95a9ed116e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1585,7 +1585,9 @@ if test -d ${srcdir}/gcc ; then
>    require_mpc=yes
>  fi
>  if test -d ${srcdir}/gdb ; then
> -  require_gmp=yes
> +  if test "x$enable_gdb" != xno; then
> +   require_gmp=yes
> +  fi
>  fi
>
>  gmplibs="-lmpfr -lgmp"
> --
> 2.25.1

Would you mind reviewing/approving this patch, please ?

Thanks in advance,
Clément

Re: [PATCH v2] configure: remove dependencies on gmp and mpfr when gdb is disabled

[Tom Tromey]

>>>>> "Clément" == Clément Chigot via Binutils <binutils@sourceware.org> writes:

Clément> Since 991180627851801f1999d1ebbc0e569a17e47c74, the configure checks
Clément> about GMP and MPFR for gdb builds have been moved to the toplevel
Clément> configure.
Clément> However, it doesn't take into account the --disable-gdb option. Meaning
Clément> that a build without gdb will require these libraries even if not
Clément> needed.

Thank you for the patch.  This is ok, please check it in.  It should go
in GCC as well, you'll have to send it to gcc-patches.

Tom