* [PATCH 1/2] x86: Don't use .insn with '/'
@ 2023-12-29 23:50 H.J. Lu
2023-12-29 23:50 ` [PATCH 2/2] x86: Append "#pass" to APX tests H.J. Lu
2024-01-04 9:33 ` [PATCH 1/2] x86: Don't use .insn with '/' Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: H.J. Lu @ 2023-12-29 23:50 UTC (permalink / raw)
To: binutils
'/' starts a comment for some targets. Use .byte instead of .insn with
'/'.
* testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s: Use .byte
instead of .insn with '/'.
---
gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
index fde6736e9b2..61ed8824428 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
+++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
@@ -39,11 +39,11 @@ _start:
.insn EVEX.L0.NP.0f38.W1 0xf5, %rax, (%rax,%rbx){1to8}, %rcx
#{evex} inc %rax %rbx EVEX.vvvv != 1111 && EVEX.ND = 0.
- .insn EVEX.L0.NP.M4.W1 0xff/0, (%rax,%rcx), %rbx
+ .byte 0x62, 0xf4, 0xe4, 0x08, 0xff, 0x04, 0x08
# pop2 %rax, %r8 set EVEX.ND=0.
- .insn EVEX.L0.M4.W0 0x8f/0, %rax, %r8
+ .byte 0x62, 0xf4, 0x3c, 0x08, 0x8f, 0xc0
.byte 0xff, 0xff, 0xff
# pop2 %rax, %r8 set EVEX.vvvv = 1111.
.insn EVEX.L0.M4.W0 0x8f, %rax, {rn-sae},%r8
# pop2 %r8, %r8.
- .insn EVEX.L0.M4.W0 0x8f/0, %r8,{rn-sae}, %r8
+ .byte 0x62, 0xd4, 0x3c, 0x18, 0x8f, 0xc0
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] x86: Append "#pass" to APX tests
2023-12-29 23:50 [PATCH 1/2] x86: Don't use .insn with '/' H.J. Lu
@ 2023-12-29 23:50 ` H.J. Lu
2024-01-04 9:35 ` Jan Beulich
2024-01-04 9:33 ` [PATCH 1/2] x86: Don't use .insn with '/' Jan Beulich
1 sibling, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2023-12-29 23:50 UTC (permalink / raw)
To: binutils
Append "#pass" to APX tests for targets which pad text sections with NOPs.
* testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d: Append
"#pass".
* testsuite/gas/i386/x86-64-apx-ndd-optimize.d: Likewise.
* testsuite/gas/i386/x86-64-apx-ndd.d: Likewise.
* testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d: Likewise.
* testsuite/gas/i386/x86-64-apx-pushp-popp.d: Likewise.
---
gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d | 1 +
gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d | 1 +
gas/testsuite/gas/i386/x86-64-apx-ndd.d | 1 +
gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d | 1 +
gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d | 1 +
5 files changed, 5 insertions(+)
diff --git a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d
index 3bfb5dec202..57bdf64c858 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d
@@ -39,3 +39,4 @@ Disassembly of section .text:
[ ]*[a-f0-9]+:[ ]+62 74 7c 18 8f c0[ ]+pop2 %rax,\(bad\)
[ ]*[a-f0-9]+:[ ]+62 d4 3c 18 8f[ ]+\(bad\)
[ ]*[a-f0-9]+:[ ]+c0[ ]+.*
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d b/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d
index 48f0f1ceee3..773ceea686c 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d
@@ -130,3 +130,4 @@ Disassembly of section .text:
\s*[a-f0-9]+:\s*62 74 3e 18 66 c0 adox %eax,%r8d,%r8d
\s*[a-f0-9]+:\s*62 d4 7e 18 66 c7 adox %r15d,%eax,%eax
\s*[a-f0-9]+:\s*67 f3 0f 38 f6 04 0a adox \(%edx,%ecx,1\),%eax
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-ndd.d b/gas/testsuite/gas/i386/x86-64-apx-ndd.d
index 73410606ce3..36d5c738e46 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-ndd.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-ndd.d
@@ -158,3 +158,4 @@ Disassembly of section .text:
\s*[a-f0-9]+:\s*62 c4 3c 18 32 04 07 xor \(%r15,%rax,1\),%r16b,%r8b
\s*[a-f0-9]+:\s*62 c4 3d 18 33 04 07 xor \(%r15,%rax,1\),%r16w,%r8w
\s*[a-f0-9]+:\s*62 fc 5c 10 83 34 83 11 xorl \$0x11,\(%r19,%rax,4\),%r20d
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d
index 44e3e96a5df..018a0e838dc 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d
@@ -12,3 +12,4 @@ Disassembly of section \.text:
\s*[a-f0-9]+:\s*d5 19 57[ ]+pushp r31
\s*[a-f0-9]+:\s*d5 08 58[ ]+popp rax
\s*[a-f0-9]+:\s*d5 19 5f[ ]+popp r31
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d
index b20e5ba9a35..a81f4838529 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d
@@ -12,3 +12,4 @@ Disassembly of section \.text:
\s*[a-f0-9]+:\s*d5 19 57[ ]+pushp %r31
\s*[a-f0-9]+:\s*d5 08 58[ ]+popp %rax
\s*[a-f0-9]+:\s*d5 19 5f[ ]+popp %r31
+#pass
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] x86: Don't use .insn with '/'
2023-12-29 23:50 [PATCH 1/2] x86: Don't use .insn with '/' H.J. Lu
2023-12-29 23:50 ` [PATCH 2/2] x86: Append "#pass" to APX tests H.J. Lu
@ 2024-01-04 9:33 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2024-01-04 9:33 UTC (permalink / raw)
To: H.J. Lu; +Cc: binutils
On 30.12.2023 00:50, H.J. Lu wrote:
> '/' starts a comment for some targets. Use .byte instead of .insn with
> '/'.
>
> * testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s: Use .byte
> instead of .insn with '/'.
Nack. The proper approach is to pass --divide to gas for such tests. I've
made very clear during review of the APX series that _wherever possible_
the more descriptive .insn should be used in preference to .byte.
Jan
> --- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> @@ -39,11 +39,11 @@ _start:
> .insn EVEX.L0.NP.0f38.W1 0xf5, %rax, (%rax,%rbx){1to8}, %rcx
>
> #{evex} inc %rax %rbx EVEX.vvvv != 1111 && EVEX.ND = 0.
> - .insn EVEX.L0.NP.M4.W1 0xff/0, (%rax,%rcx), %rbx
> + .byte 0x62, 0xf4, 0xe4, 0x08, 0xff, 0x04, 0x08
> # pop2 %rax, %r8 set EVEX.ND=0.
> - .insn EVEX.L0.M4.W0 0x8f/0, %rax, %r8
> + .byte 0x62, 0xf4, 0x3c, 0x08, 0x8f, 0xc0
> .byte 0xff, 0xff, 0xff
> # pop2 %rax, %r8 set EVEX.vvvv = 1111.
> .insn EVEX.L0.M4.W0 0x8f, %rax, {rn-sae},%r8
> # pop2 %r8, %r8.
> - .insn EVEX.L0.M4.W0 0x8f/0, %r8,{rn-sae}, %r8
> + .byte 0x62, 0xd4, 0x3c, 0x18, 0x8f, 0xc0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] x86: Append "#pass" to APX tests
2023-12-29 23:50 ` [PATCH 2/2] x86: Append "#pass" to APX tests H.J. Lu
@ 2024-01-04 9:35 ` Jan Beulich
0 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2024-01-04 9:35 UTC (permalink / raw)
To: H.J. Lu; +Cc: binutils
On 30.12.2023 00:50, H.J. Lu wrote:
> Append "#pass" to APX tests for targets which pad text sections with NOPs.
>
> * testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d: Append
> "#pass".
> * testsuite/gas/i386/x86-64-apx-ndd-optimize.d: Likewise.
> * testsuite/gas/i386/x86-64-apx-ndd.d: Likewise.
> * testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d: Likewise.
> * testsuite/gas/i386/x86-64-apx-pushp-popp.d: Likewise.
It's interesting that you found a need for this, when I'm sure I made a
comment to this effect during review (somewhere in the series, but
obviously applicable throughout). When approving, you didn't check that
all review comments were addressed, did you?
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-04 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-29 23:50 [PATCH 1/2] x86: Don't use .insn with '/' H.J. Lu
2023-12-29 23:50 ` [PATCH 2/2] x86: Append "#pass" to APX tests H.J. Lu
2024-01-04 9:35 ` Jan Beulich
2024-01-04 9:33 ` [PATCH 1/2] x86: Don't use .insn with '/' Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).