From: "Frager, Neal" <neal.frager@amd.com>
To: Alan Modra <amodra@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
"eager@eagercon.com" <eager@eagercon.com>,
"eager@eagerm.com" <eager@eagerm.com>,
"nickc@redhat.com" <nickc@redhat.com>,
"Hatle, Mark" <mark.hatle@amd.com>,
"Erkiaga Elorza, Ibai" <ibai.erkiaga-elorza@amd.com>
Subject: Re: [PATCH v6 1/2] opcodes: microblaze: Add new bit-field instructions
Date: Fri, 20 Oct 2023 06:28:05 +0000 [thread overview]
Message-ID: <C81E5FBF-99E4-4DB2-AA31-5934D32DA0CA@amd.com> (raw)
In-Reply-To: <ZTGf6/i+bfAxw7K2@squeak.grove.modra.org>
Hi Alan,
> Le 19 oct. 2023 à 23:30, Alan Modra <amodra@gmail.com> a écrit :
>
> On Thu, Oct 19, 2023 at 01:20:03PM +0000, Frager, Neal wrote:
>> Could you please test the following patch? On my side, it resolves the issue you are reporting.
>>
>> https://patchwork.sourceware.org/project/binutils/patch/20231019113740.2071556-1-neal.frager@amd.com/
>
> It does. I saw the email yesterday and thought, "good, he's fixed the
> obvious NUM_STRBUFS bug which was the source of the abort, and also
> the .short thing".
>
> --
> Alan Modra
> Australia Development Lab, IBM
The original patch I submitted was just copy pasting from our meta-xilinx patch set. I am actually quite surprised such a bug exists since AMD has been shipping a microblaze toolchain with this bug in it for a few years now.
And now that I am looking more closely at the microblaze-opc.h file, I think there are probably quite a few issues with disassembly and the objdump utility which need fixing.
If you catch any other issues, please let me know, as I would like to get this cleaned up.
Best regards,
Neal Frager
AMD
prev parent reply other threads:[~2023-10-20 6:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 7:28 Neal Frager
2023-10-13 7:28 ` [PATCH v6 2/2] gas: testsuite: microblaze: Add new bit-field tests Neal Frager
2023-10-17 22:58 ` Michael Eager
2023-10-15 16:30 ` [PATCH v6 1/2] opcodes: microblaze: Add new bit-field instructions Michael Eager
2023-10-15 16:48 ` Frager, Neal
2023-10-19 3:40 ` Alan Modra
2023-10-19 3:53 ` Alan Modra
2023-10-19 6:40 ` Frager, Neal
2023-10-19 10:23 ` Alan Modra
2023-10-19 13:20 ` Frager, Neal
2023-10-19 21:30 ` Alan Modra
2023-10-20 6:28 ` Frager, Neal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C81E5FBF-99E4-4DB2-AA31-5934D32DA0CA@amd.com \
--to=neal.frager@amd.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=eager@eagercon.com \
--cc=eager@eagerm.com \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=mark.hatle@amd.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).