Re: [PATCH v6 1/2] opcodes: microblaze: Add new bit-field instructions

["Frager, Neal" <neal.frager@amd.com>]

Hi Alan,


> Le 19 oct. 2023 à 05:53, Alan Modra <amodra@gmail.com> a écrit :
> 
> On Thu, Oct 19, 2023 at 02:10:41PM +1030, Alan Modra wrote:
>>> On Sun, Oct 15, 2023 at 04:48:29PM +0000, Frager, Neal wrote:
>>> In any case, thank you for your review, fixing this issue and committing the patch!
>> 
>> Commit bb0d05ff74fd caused
>> FAIL: objdump -S
>> FAIL: objdump --source-comment
>> on microblaze-linux-gnu.
> 
> Assembling and attempting to disassemble this
> .text
> .long 0x65005f5f
> should give something to look at.  I see
> 
> $ binutils/objdump -d xxx.o
> xxx.o:     file format elf32-microblaze
> 
> 
> Disassembly of section .text:
> 
> 00000000 <.text>:
> Aborted (core dumped)
> 

Thank you for sharing this.  I believe I know the root cause.  These new instructions start with the most significant byte 0x64.  I think the disassembler code is ignoring bit 24 and treating 0x65 as an instruction with bad parameters.

I am confident I can fix it.  I just need to get in front my a PC.

I will send you a patch that fixes this shortly.

Thanks for sharing this!

Best regards,
Neal Frager
AMD

> 
> --
> Alan Modra
> Australia Development Lab, IBM