public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Frager, Neal" <neal.frager@amd.com>
To: Alan Modra <amodra@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
	"eager@eagercon.com" <eager@eagercon.com>,
	"eager@eagerm.com" <eager@eagerm.com>,
	"nickc@redhat.com" <nickc@redhat.com>
Subject: RE: [PATCH v6 1/2] opcodes: microblaze: Add new bit-field instructions
Date: Thu, 19 Oct 2023 13:20:03 +0000	[thread overview]
Message-ID: <CH2PR12MB5004A1983A9F12C1A36EE821F0D4A@CH2PR12MB5004.namprd12.prod.outlook.com> (raw)
In-Reply-To: <ZTCoMC0x2HiyhH/n@squeak.grove.modra.org>

Hi Alan,

> > In any case, thank you for your review, fixing this issue and committing the patch!
> 
> Commit bb0d05ff74fd caused
> FAIL: objdump -S
> FAIL: objdump --source-comment
> on microblaze-linux-gnu.

> Assembling and attempting to disassemble this  .text  .long 0x65005f5f should give something to look at.  I see

> $ binutils/objdump -d xxx.o
>xxx.o:     file format elf32-microblaze


> Disassembly of section .text:

> 00000000 <.text>:
> Aborted (core dumped)

Could you please test the following patch?  On my side, it resolves the issue you are reporting.

https://patchwork.sourceware.org/project/binutils/patch/20231019113740.2071556-1-neal.frager@amd.com/

Thank you for finding and reporting this issue!

Best regards,
Neal Frager
AMD

  parent reply	other threads:[~2023-10-19 13:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13  7:28 Neal Frager
2023-10-13  7:28 ` [PATCH v6 2/2] gas: testsuite: microblaze: Add new bit-field tests Neal Frager
2023-10-17 22:58   ` Michael Eager
2023-10-15 16:30 ` [PATCH v6 1/2] opcodes: microblaze: Add new bit-field instructions Michael Eager
2023-10-15 16:48   ` Frager, Neal
2023-10-19  3:40     ` Alan Modra
2023-10-19  3:53       ` Alan Modra
2023-10-19  6:40         ` Frager, Neal
2023-10-19 10:23           ` Alan Modra
2023-10-19 13:20         ` Frager, Neal [this message]
2023-10-19 21:30           ` Alan Modra
2023-10-20  6:28             ` Frager, Neal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR12MB5004A1983A9F12C1A36EE821F0D4A@CH2PR12MB5004.namprd12.prod.outlook.com \
    --to=neal.frager@amd.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=eager@eagercon.com \
    --cc=eager@eagerm.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).