Re: [PATCH 01/14] Add support for the Zvbb ISA extension.

["Christoph Müllner" <christoph.muellner@vrull.eu>]

On Fri, Jun 30, 2023 at 7:51 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote:
> > From: Christoph Müllner <christoph.muellner@vrull.eu>
> >
> > Zvbb is part of the vector crypto extensions.
> >
> > This extension adds the following instructions:
> > - vandn.[vv,vx]
> > - vbrev.v
> > - vbrev8.v
> > - vrev8.v
> > - vclz.v
> > - vctz.v
> > - vcpop.v
> > - vrol.[vv,vx]
> > - vror.[vv,vx,vi]
> > - vwsll.[vv,vx,vi]
> >
> > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> > [Updated to newest version of RISC-V spec]
> > Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> > ---
> >   bfd/elfxx-riscv.c              |  5 ++++
> >   gas/config/tc-riscv.c          | 13 +++++++++
> >   gas/testsuite/gas/riscv/zvbb.d | 43 +++++++++++++++++++++++++++++
> >   gas/testsuite/gas/riscv/zvbb.s | 34 +++++++++++++++++++++++
> >   include/opcode/riscv-opc.h     | 50 ++++++++++++++++++++++++++++++++++
> >   include/opcode/riscv.h         |  5 ++++
> >   opcodes/riscv-dis.c            |  4 +++
> >   opcodes/riscv-opc.c            | 18 ++++++++++++
> >   8 files changed, 172 insertions(+)
> >   create mode 100644 gas/testsuite/gas/riscv/zvbb.d
> >   create mode 100644 gas/testsuite/gas/riscv/zvbb.s
> This needs appropriate ChangeLog entries as well as an update to the
> binutils/NEWS file.  With those missing pieces this will be OK for the
> trunk.

I will provide that:
* Adding ChangLog entries to the commit messages
* Adding a commit that updates binutils/NEWS

I will send a new version on the list within the next hour.

>
> Sometimes I'm willing to cobble together ChangeLogs, but with 14 patches
> in the kit, I'm not going to have the time.  If a suitable ChangeLog and
> NEWS file is provided today, I can go ahead and push it to the trunk.  I
> might be able to do that Sat/Sun as well, but I can't commit to that.
>
> I don't offhand know Nick's policy WRT patches going into a release
> branch.  So while I can ACK this for the trunk with a suitable
> ChangeLog/NEWS file entry, I don't know if that ACK will apply to the
> upcoming 2.41 branch if this doesn't get pushed to the trunk before Nick
> makes the branch (Sunday, July 2).
>
>
> Jeff