Re: [PATCH 09/14] Allow nested implications for extensions.

["Christoph Müllner" <christoph.muellner@vrull.eu>]

On Fri, Jun 30, 2023 at 10:45 PM Jeff Law via Binutils
<binutils@sourceware.org> wrote:
>
>
>
> On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote:
> > Certain extensions require two levels of implications.  For example,
> > zvkng implies zvkn and zvkn implies zvkned.  Enabling zvkng should also
> > enable zvkned.
> >
> > This patch fixes this behavior.
> >
> > Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> > ---
> >   bfd/elfxx-riscv.c | 16 ++++++++++++++--
> >   1 file changed, 14 insertions(+), 2 deletions(-)
> No problem with the actual code.  I would suggest a comment explicitly
> stating this only allows two levels rather than arbitrary levels of nesting.

If I read the resulting code correctly, then arbitrary nesting should
be possible.
Whenever an implicit subset is found and added, `finished` will be set to false,
`t` will be reset to the initial value and the inner loop will terminate.
The outer loop will start over because `finished` is false.
Do I miss something?

BR
Christoph

>
> As with the others, it needs ChangeLog and NEWS entries.
>
> With those changes it'll be fine for the trunk.
>
> Thanks,
> jeff