Re: [PATCH 0/4] RISC-V: Implement TLS Descriptors.

[Nelson Chu <nelson@rivosinc.com>]

[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]

Hi,

Before the reviewing, I think you still should have test cases for each
patch to make sure everything is correct in the binutils, and helps people
understand what the patches try to resolve what problem or support what
features.  In general, the regressions in binutils, gcc and glibc are
seperate.  Besides, each patch should at least have the ChangLogs in the
commit message.

Thanks
Nelson

On Fri, Aug 18, 2023 at 2:10 AM Tatsuyuki Ishi via Binutils <
binutils@sourceware.org> wrote:

> This patchset implements TLS Descriptors (TLSDESC) for RISC-V targets, per
> the specification draft at [1].
>
> This patchset is based on top of [2].
>
> No regression in binutils and gcc tests for rv64gc, tested alongside the
> gcc and glibc implementation (will be posted shortly).
>
> This contribution is made on behalf of Blue Whale Systems, which has
> copyright assignment on file with the FSF.
>
> [1]: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/373
> [2]: https://sourceware.org/pipermail/binutils/2023-August/129075.html
>
> Tatsuyuki Ishi (4):
>   RISC-V: Add TLSDESC reloc definitions.
>   RISC-V: Add assembly support for TLSDESC.
>   RISC-V: Define and use GOT entry size constants for TLS.
>   RISC-V: Initial ld.bfd support for TLSDESC.
>
>  bfd/bfd-in2.h                              |   4 +
>  bfd/elfnn-riscv.c                          | 105 ++++++++++++++++++---
>  bfd/elfxx-riscv.c                          |  75 ++++++++++++++-
>  bfd/libbfd.h                               |   4 +
>  bfd/reloc.c                                |   8 ++
>  gas/config/tc-riscv.c                      |  18 +++-
>  include/elf/riscv.h                        |   5 +
>


>  ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp |   2 +
>

This doesn't work, seems still not adding any test cases.


>  opcodes/riscv-opc.c                        |   1 +
>  9 files changed, 201 insertions(+), 21 deletions(-)
>
> --
> 2.41.0
>
>