public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Cui, Lili" <lili.cui@intel.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH v3 0/9] Support Intel APX EGPR
Date: Thu, 7 Dec 2023 08:17:15 +0000	[thread overview]
Message-ID: <SJ0PR11MB56004426612B25E578904E689E8BA@SJ0PR11MB5600.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR11MB56001F2C2AC215C1C9A2B2649EB8A@SJ0PR11MB5600.namprd11.prod.outlook.com>

Hi H.J,

Could you help review these APX patches? There are 11 patches in total.

[PATCH] Clean reg class and base_reg for input output operand (%dx). (for legacy)
[PATCH 1/9] Make const_1_mode print $1 in AT&T syntax. (for legacy)
[PATCH v3 2/9] Support APX GPR32 with rex2 prefix.
[PATCH v3 3/9] Created an empty EVEX_MAP4_ sub-table for EVEX instructions.
[PATCH v3 4/9] Support APX GPR32 with extend evex prefix.
[PATCH v3 5/9] Add tests for APX GPR32 with extend evex prefix.
[PATCH v3 6/9] Support APX NDD.
[PATCH v3 7/9] Support APX Push2/Pop2.
[PATCH] Support APX PUSHP/POPP.
[PATCH v3 8/9] Support APX NDD optimized encoding.
[PATCH v3 9/9] Support APX JMPABS for disassembler.

There are 3 patches that need to be updated. Lin and I will post later.
 [PATCH v3 2/9] Support APX GPR32 with rex2 prefix
 [PATCH] Support APX PUSHP/POPP
 [PATCH v3 9/9] Support APX JMPABS for disassembler

Thanks,
Lili.

> -----Original Message-----
> From: Cui, Lili <lili.cui@intel.com>
> Sent: Friday, November 24, 2023 2:56 PM
> To: Beulich, Jan <JBeulich@suse.com>
> Cc: Lu, Hongjiu <hongjiu.lu@intel.com>; binutils@sourceware.org
> Subject: [PATCH v3 0/9] Support Intel APX EGPR
> 
> 
> This is V3 of all APX patches.
> 1. Created a patch to make const_1_mode print $1 in AT&T syntax.
> 2. How to print the rex2 prefix needs to be discussed later.
> 3. After NF patch, need to add tests for pfx macros emitting {evex} in
> noreg64.s.
> 
> Cui, Lili (5):
>   Make const_1_mode print $1 in AT&T syntax
>   Support APX GPR32 with rex2 prefix
>   Created an empty EVEX_MAP4_ sub-table for EVEX instructions.
>   Support APX GPR32 with extend evex prefix
>   Add tests for APX GPR32 with extend evex prefix
> 
> Hu, Lin1 (2):
>   Support APX NDD optimized encoding.
>   Support APX JMPABS for disassembler
> 
> Mo, Zewei (1):
>   Support APX Push2/Pop2
> 
> konglin1 (1):
>   Support APX NDD
> 
> 
> Thanks,
> Lili.
>  gas/config/tc-i386.c                          | 472 +++++++++++--
>  gas/doc/c-i386.texi                           |   6 +-
>  gas/testsuite/gas/i386/apx-push2pop2-inval.l  |   5 +
>  gas/testsuite/gas/i386/apx-push2pop2-inval.s  |   9 +
>  gas/testsuite/gas/i386/i386.exp               |   1 +
>  .../i386/ilp32/x86-64-opcode-inval-intel.d    |  47 +-
>  .../gas/i386/ilp32/x86-64-opcode-inval.d      |  47 +-
>  gas/testsuite/gas/i386/intel.d                |   6 +-
>  gas/testsuite/gas/i386/lfence-load.d          |   2 +-
>  gas/testsuite/gas/i386/noreg16-data32.d       |  32 +-
>  gas/testsuite/gas/i386/noreg16.d              |  32 +-
>  gas/testsuite/gas/i386/noreg32-data16.d       |  32 +-
>  gas/testsuite/gas/i386/noreg32.d              |  32 +-
>  gas/testsuite/gas/i386/noreg64-data16.d       |  32 +-
>  gas/testsuite/gas/i386/noreg64-rex64.d        |  32 +-
>  gas/testsuite/gas/i386/noreg64.d              |  32 +-
>  gas/testsuite/gas/i386/opcode-suffix.d        |   6 +-
>  gas/testsuite/gas/i386/opcode.d               |  10 +-
>  .../gas/i386/x86-64-apx-egpr-inval.l          | 203 ++++++
>  .../gas/i386/x86-64-apx-egpr-inval.s          | 210 ++++++
>  .../gas/i386/x86-64-apx-egpr-promote-inval.l  |  20 +  .../gas/i386/x86-64-apx-
> egpr-promote-inval.s  |  29 +  gas/testsuite/gas/i386/x86-64-apx-evex-egpr.d |
> 20 +  gas/testsuite/gas/i386/x86-64-apx-evex-egpr.s |  21 +
>  .../gas/i386/x86-64-apx-evex-promoted-bad.d   |  34 +
>  .../gas/i386/x86-64-apx-evex-promoted-bad.s   |  36 +
>  .../gas/i386/x86-64-apx-evex-promoted-intel.d | 318 +++++++++
>  .../gas/i386/x86-64-apx-evex-promoted.d       | 318 +++++++++
>  .../gas/i386/x86-64-apx-evex-promoted.s       | 314 +++++++++
>  .../gas/i386/x86-64-apx-jmpabs-intel.d        |  11 +
>  .../gas/i386/x86-64-apx-jmpabs-inval.d        |  40 ++
>  .../gas/i386/x86-64-apx-jmpabs-inval.s        |  15 +
>  gas/testsuite/gas/i386/x86-64-apx-jmpabs.d    |  11 +
>  gas/testsuite/gas/i386/x86-64-apx-jmpabs.s    |   5 +
>  .../gas/i386/x86-64-apx-ndd-optimize.d        | 130 ++++
>  .../gas/i386/x86-64-apx-ndd-optimize.s        | 123 ++++
>  gas/testsuite/gas/i386/x86-64-apx-ndd.d       | 160 +++++
>  gas/testsuite/gas/i386/x86-64-apx-ndd.s       | 155 +++++
>  .../gas/i386/x86-64-apx-push2pop2-intel.d     |  42 ++
>  .../gas/i386/x86-64-apx-push2pop2-inval.l     |  13 +
>  .../gas/i386/x86-64-apx-push2pop2-inval.s     |  17 +
>  gas/testsuite/gas/i386/x86-64-apx-push2pop2.d |  42 ++
> gas/testsuite/gas/i386/x86-64-apx-push2pop2.s |  39 ++
>  gas/testsuite/gas/i386/x86-64-apx-rex2.d      |  83 +++
>  gas/testsuite/gas/i386/x86-64-apx-rex2.s      |  86 +++
>  gas/testsuite/gas/i386/x86-64-evex.d          |   2 +-
>  gas/testsuite/gas/i386/x86-64-inval-pseudo.l  |   6 +
>  gas/testsuite/gas/i386/x86-64-inval-pseudo.s  |   4 +
>  gas/testsuite/gas/i386/x86-64-lfence-load.d   |   2 +-
>  .../gas/i386/x86-64-opcode-inval-intel.d      |  26 +-
>  gas/testsuite/gas/i386/x86-64-opcode-inval.d  |  26 +-
>  gas/testsuite/gas/i386/x86-64-opcode-inval.s  |   4 -
>  gas/testsuite/gas/i386/x86-64-opcode.d        |   6 +-
>  gas/testsuite/gas/i386/x86-64-pseudos-bad.l   |  59 +-
>  gas/testsuite/gas/i386/x86-64-pseudos-bad.s   |  58 ++
>  gas/testsuite/gas/i386/x86-64-pseudos.d       |  63 ++
>  gas/testsuite/gas/i386/x86-64-pseudos.s       |  65 ++
>  gas/testsuite/gas/i386/x86-64.exp             |  17 +-
>  include/opcode/i386.h                         |   2 +
>  opcodes/i386-dis-evex-len.h                   |  10 +
>  opcodes/i386-dis-evex-prefix.h                |  66 ++
>  opcodes/i386-dis-evex-reg.h                   |  71 ++
>  opcodes/i386-dis-evex-w.h                     |  10 +
>  opcodes/i386-dis-evex-x86-64.h                |  60 ++
>  opcodes/i386-dis-evex.h                       | 347 +++++++++-
>  opcodes/i386-dis.c                            | 644 +++++++++++++-----
>  opcodes/i386-gen.c                            |  57 +-
>  opcodes/i386-opc.h                            |  30 +-
>  opcodes/i386-opc.tbl                          | 210 ++++--
>  opcodes/i386-reg.tbl                          |  64 ++
>  70 files changed, 4669 insertions(+), 570 deletions(-)  create mode 100644
> gas/testsuite/gas/i386/apx-push2pop2-inval.l
>  create mode 100644 gas/testsuite/gas/i386/apx-push2pop2-inval.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-egpr-inval.l
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.l
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-evex-egpr.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-evex-egpr.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-evex-promoted-
> bad.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-evex-promoted-
> intel.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-evex-promoted.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-evex-promoted.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-jmpabs-intel.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-jmpabs.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-jmpabs.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-ndd.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-ndd.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-push2pop2-intel.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-push2pop2-inval.l
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-push2pop2-inval.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-push2pop2.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-push2pop2.s
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-rex2.d
>  create mode 100644 gas/testsuite/gas/i386/x86-64-apx-rex2.s
>  create mode 100644 opcodes/i386-dis-evex-x86-64.h
> 
> --
> 2.25.1


  reply	other threads:[~2023-12-07  8:17 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 11:29 [PATCH v2 0/8] " Cui, Lili
2023-11-02 11:29 ` [PATCH 1/8] Support APX GPR32 with rex2 prefix Cui, Lili
2023-11-02 17:05   ` Jan Beulich
2023-11-03  6:20     ` Cui, Lili
2023-11-03 13:05     ` Jan Beulich
2023-11-03 14:19   ` Jan Beulich
2023-11-06 15:20     ` Cui, Lili
2023-11-06 16:08       ` Jan Beulich
2023-11-07  8:16         ` Cui, Lili
2023-11-07 10:43           ` Jan Beulich
2023-11-07 15:31             ` Cui, Lili
2023-11-07 15:43               ` Jan Beulich
2023-11-07 15:53                 ` Cui, Lili
2023-11-06 15:02   ` Jan Beulich
2023-11-07  8:06     ` Cui, Lili
2023-11-07 10:20       ` Jan Beulich
2023-11-07 14:32         ` Cui, Lili
2023-11-07 15:08           ` Jan Beulich
2023-11-06 15:39   ` Jan Beulich
2023-11-09  8:02     ` Cui, Lili
2023-11-09 10:52       ` Jan Beulich
2023-11-09 13:27         ` Cui, Lili
2023-11-09 15:22           ` Jan Beulich
2023-11-10  7:11             ` Cui, Lili
2023-11-10  9:14               ` Jan Beulich
2023-11-10  9:21                 ` Jan Beulich
2023-11-10 12:38                   ` Cui, Lili
2023-12-14 10:13                   ` Cui, Lili
2023-12-18 15:24                     ` Jan Beulich
2023-12-18 16:23                       ` H.J. Lu
2023-11-10  9:47                 ` Cui, Lili
2023-11-10  9:57                   ` Jan Beulich
2023-11-10 12:05                     ` Cui, Lili
2023-11-10 12:35                       ` Jan Beulich
2023-11-13  0:18                         ` Cui, Lili
2023-11-02 11:29 ` [PATCH 2/8] Created an empty EVEX_MAP4_ sub-table for EVEX instructions Cui, Lili
2023-11-02 11:29 ` [PATCH 3/8] Support APX GPR32 with extend evex prefix Cui, Lili
2023-11-02 11:29 ` [PATCH 4/8] Add tests for " Cui, Lili
2023-11-08  9:11   ` Jan Beulich
2023-11-15 14:56     ` Cui, Lili
2023-11-16  9:17       ` Jan Beulich
2023-11-16 15:34     ` Cui, Lili
2023-11-16 16:50       ` Jan Beulich
2023-11-17 12:42         ` Cui, Lili
2023-11-17 14:38           ` Jan Beulich
2023-11-22 13:40             ` Cui, Lili
2023-11-02 11:29 ` [PATCH 5/8] Support APX NDD Cui, Lili
2023-11-08 10:39   ` Jan Beulich
2023-11-20  1:19     ` Cui, Lili
2023-11-08 11:13   ` Jan Beulich
2023-11-20 12:36     ` Cui, Lili
2023-11-20 16:33       ` Jan Beulich
2023-11-22  7:46         ` Cui, Lili
2023-11-22  8:47           ` Jan Beulich
2023-11-22 10:45             ` Cui, Lili
2023-11-23 10:57               ` Jan Beulich
2023-11-23 12:14                 ` Cui, Lili
2023-11-24  6:56                 ` [PATCH v3 0/9] Support Intel APX EGPR Cui, Lili
2023-12-07  8:17                   ` Cui, Lili [this message]
2023-12-07  8:33                     ` Cui, Lili
2023-11-09  9:37   ` [PATCH 5/8] Support APX NDD Jan Beulich
2023-11-20  1:33     ` Cui, Lili
2023-11-20  8:19       ` Jan Beulich
2023-11-20 12:54         ` Cui, Lili
2023-11-20 16:43           ` Jan Beulich
2023-11-02 11:29 ` [PATCH 6/8] Support APX Push2/Pop2 Cui, Lili
2023-11-08 11:44   ` Jan Beulich
2023-11-08 12:52     ` Jan Beulich
2023-11-22  5:48     ` Cui, Lili
2023-11-22  8:53       ` Jan Beulich
2023-11-22 12:26         ` Cui, Lili
2023-11-09  9:57   ` Jan Beulich
2023-11-02 11:29 ` [PATCH 7/8] Support APX NDD optimized encoding Cui, Lili
2023-11-09 10:36   ` Jan Beulich
2023-11-10  5:43     ` Hu, Lin1
2023-11-10  9:54       ` Jan Beulich
2023-11-14  2:28         ` Hu, Lin1
2023-11-14 10:50           ` Jan Beulich
2023-11-15  2:52             ` Hu, Lin1
2023-11-15  8:57               ` Jan Beulich
2023-11-15  2:59             ` [PATCH][v3] " Hu, Lin1
2023-11-15  9:34               ` Jan Beulich
2023-11-17  7:24                 ` Hu, Lin1
2023-11-17  9:47                   ` Jan Beulich
2023-11-20  3:28                     ` Hu, Lin1
2023-11-20  8:34                       ` Jan Beulich
2023-11-14  2:58         ` [PATCH 1/2] Reorder APX insns in i386.tbl Hu, Lin1
2023-11-14 11:20           ` Jan Beulich
2023-11-15  1:49             ` Hu, Lin1
2023-11-15  8:52               ` Jan Beulich
2023-11-17  3:27                 ` Hu, Lin1
2023-11-02 11:29 ` [PATCH 8/8] Support APX JMPABS Cui, Lili
2023-11-09 12:59   ` Jan Beulich
2023-11-14  3:26     ` Hu, Lin1
2023-11-14 11:15       ` Jan Beulich
2023-11-24  5:40         ` Hu, Lin1
2023-11-24  7:21           ` Jan Beulich
2023-11-27  2:16             ` Hu, Lin1
2023-11-27  8:03               ` Jan Beulich
2023-11-27  8:46                 ` Hu, Lin1
2023-11-27  8:54                   ` Jan Beulich
2023-11-27  9:03                     ` Hu, Lin1
2023-11-27 10:32                       ` Jan Beulich
2023-12-04  7:33                         ` Hu, Lin1
2023-11-02 13:22 ` [PATCH v2 0/8] Support Intel APX EGPR Jan Beulich
2023-11-03 16:42   ` Cui, Lili
2023-11-06  7:30     ` Jan Beulich
2023-11-06 14:20       ` Cui, Lili
2023-11-06 14:44         ` Jan Beulich
2023-11-06 16:03           ` Cui, Lili
2023-11-06 16:10             ` Jan Beulich
2023-11-07  1:53               ` Cui, Lili
2023-11-07 10:11                 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR11MB56004426612B25E578904E689E8BA@SJ0PR11MB5600.namprd11.prod.outlook.com \
    --to=lili.cui@intel.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).