* Move bfd_init to bfd.c
@ 2023-01-09 23:18 Alan Modra
2023-01-10 9:47 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Alan Modra @ 2023-01-09 23:18 UTC (permalink / raw)
To: binutils
init.c contains just one function that doesn't do much. Move it to
bfd.c and give it something to do, initialising static state. So far
the only initialisation is for bfd.c static variables.
The idea behind reinitialising state is to see whether some set of
flaky oss-fuzz crashes go away. oss-fuzz stresses binutils in ways
that can't occur in reality, feeding multiple testcases into the
internals of binutils. So one testcase may affect the result of the
next testcase.
* init.c: Delete file. Move bfd_init to..
* bfd.c (bfd_init): ..here. Init static variables.
* Makefile.am (BFD32_LIBS): Remove init.lo.
(BFD32_LIBS_CFILES, BFD_H_FILES): Remove init.c.
* doc/local.mk: Remove mention of init.texi and init.c.
* Makefile.in: Regenerate.
* bfd-in2.h: Regenerate.
* po/SRC-POTFILES.in: Regenerate.
diff --git a/bfd/Makefile.am b/bfd/Makefile.am
index 75d21db88d1..a745372c0a4 100644
--- a/bfd/Makefile.am
+++ b/bfd/Makefile.am
@@ -77,7 +77,7 @@ BFD_H = bfd.h
BFD32_LIBS = \
archive.lo archures.lo bfd.lo bfdio.lo bfdwin.lo cache.lo \
coff-bfd.lo compress.lo corefile.lo elf-properties.lo format.lo \
- hash.lo init.lo libbfd.lo linker.lo merge.lo opncls.lo reloc.lo \
+ hash.lo libbfd.lo linker.lo merge.lo opncls.lo reloc.lo \
section.lo simple.lo stab-syms.lo stabs.lo syms.lo targets.lo \
binary.lo ihex.lo srec.lo tekhex.lo verilog.lo
@@ -86,7 +86,7 @@ BFD64_LIBS = archive64.lo
BFD32_LIBS_CFILES = \
archive.c archures.c bfd.c bfdio.c bfdwin.c cache.c coff-bfd.c \
compress.c corefile.c elf-properties.c format.c hash.c \
- init.c libbfd.c linker.c merge.c opncls.c reloc.c \
+ libbfd.c linker.c merge.c opncls.c reloc.c \
section.c simple.c stab-syms.c stabs.c syms.c targets.c \
binary.c ihex.c srec.c tekhex.c verilog.c
@@ -923,7 +923,7 @@ stmp-bfd-h: bfd-in3.h
rm -f bfd-tmp.h
touch stmp-bfd-h
-BFD_H_FILES = bfd-in.h init.c opncls.c libbfd.c \
+BFD_H_FILES = bfd-in.h opncls.c libbfd.c \
bfdio.c bfdwin.c section.c archures.c reloc.c \
syms.c bfd.c archive.c corefile.c targets.c format.c \
linker.c simple.c compress.c
diff --git a/bfd/Makefile.in b/bfd/Makefile.in
index 0b0bb1a950e..1e0c2dcae1e 100644
--- a/bfd/Makefile.in
+++ b/bfd/Makefile.in
@@ -186,10 +186,9 @@ LTLIBRARIES = $(bfdlib_LTLIBRARIES) $(noinst_LTLIBRARIES)
am__DEPENDENCIES_1 =
am__objects_1 = archive.lo archures.lo bfd.lo bfdio.lo bfdwin.lo \
cache.lo coff-bfd.lo compress.lo corefile.lo elf-properties.lo \
- format.lo hash.lo init.lo libbfd.lo linker.lo merge.lo \
- opncls.lo reloc.lo section.lo simple.lo stab-syms.lo stabs.lo \
- syms.lo targets.lo binary.lo ihex.lo srec.lo tekhex.lo \
- verilog.lo
+ format.lo hash.lo libbfd.lo linker.lo merge.lo opncls.lo \
+ reloc.lo section.lo simple.lo stab-syms.lo stabs.lo syms.lo \
+ targets.lo binary.lo ihex.lo srec.lo tekhex.lo verilog.lo
am_libbfd_la_OBJECTS = $(am__objects_1)
libbfd_la_OBJECTS = $(am_libbfd_la_OBJECTS)
AM_V_lt = $(am__v_lt_@AM_V@)
@@ -546,7 +545,7 @@ BFD_H = bfd.h
BFD32_LIBS = \
archive.lo archures.lo bfd.lo bfdio.lo bfdwin.lo cache.lo \
coff-bfd.lo compress.lo corefile.lo elf-properties.lo format.lo \
- hash.lo init.lo libbfd.lo linker.lo merge.lo opncls.lo reloc.lo \
+ hash.lo libbfd.lo linker.lo merge.lo opncls.lo reloc.lo \
section.lo simple.lo stab-syms.lo stabs.lo syms.lo targets.lo \
binary.lo ihex.lo srec.lo tekhex.lo verilog.lo
@@ -554,7 +553,7 @@ BFD64_LIBS = archive64.lo
BFD32_LIBS_CFILES = \
archive.c archures.c bfd.c bfdio.c bfdwin.c cache.c coff-bfd.c \
compress.c corefile.c elf-properties.c format.c hash.c \
- init.c libbfd.c linker.c merge.c opncls.c reloc.c \
+ libbfd.c linker.c merge.c opncls.c reloc.c \
section.c simple.c stab-syms.c stabs.c syms.c targets.c \
binary.c ihex.c srec.c tekhex.c verilog.c
@@ -1216,7 +1215,7 @@ libbfd_la_LIBADD = `cat ofiles` @SHARED_LIBADD@ $(LIBDL) $(ZLIB) $(ZSTD_LIBS) ..
# everything else starts using libtool. FIXME.
noinst_LIBRARIES = libbfd.a
libbfd_a_SOURCES =
-BFD_H_FILES = bfd-in.h init.c opncls.c libbfd.c \
+BFD_H_FILES = bfd-in.h opncls.c libbfd.c \
bfdio.c bfdwin.c section.c archures.c reloc.c \
syms.c bfd.c archive.c corefile.c targets.c format.c \
linker.c simple.c compress.c
@@ -1263,7 +1262,6 @@ DOCFILES = \
doc/elf.texi \
doc/format.texi \
doc/hash.texi \
- doc/init.texi \
doc/libbfd.texi \
doc/linker.texi \
doc/mmo.texi \
@@ -1296,13 +1294,12 @@ SRCPROT = $(srcdir)/archive.c $(srcdir)/archures.c \
$(srcdir)/bfdio.c $(srcdir)/bfdwin.c \
$(srcdir)/opncls.c $(srcdir)/reloc.c \
$(srcdir)/section.c $(srcdir)/syms.c \
- $(srcdir)/targets.c $(srcdir)/init.c
+ $(srcdir)/targets.c
SRCIPROT = $(srcdir)/cache.c $(srcdir)/libbfd.c \
$(srcdir)/bfdio.c $(srcdir)/bfdwin.c \
$(srcdir)/reloc.c $(srcdir)/cpu-h8300.c \
- $(srcdir)/archures.c \
- $(srcdir)/init.c
+ $(srcdir)/archures.c
TEXIDIR = $(srcdir)/../texinfo/fsf
info_TEXINFOS = doc/bfd.texi
@@ -1682,7 +1679,6 @@ distclean-compile:
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/i386lynx.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/i386msdos.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/ihex.Plo@am__quote@
-@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/init.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/irix-core.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libbfd.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/linker.Plo@am__quote@
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index aeb8d5de7b9..bb2b30200dc 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -1,8 +1,8 @@
/* DO NOT EDIT! -*- buffer-read-only: t -*- This file is automatically
- generated from "bfd-in.h", "init.c", "opncls.c", "libbfd.c",
- "bfdio.c", "bfdwin.c", "section.c", "archures.c", "reloc.c",
- "syms.c", "bfd.c", "archive.c", "corefile.c", "targets.c", "format.c",
- "linker.c", "simple.c" and "compress.c".
+ generated from "bfd-in.h", "opncls.c", "libbfd.c", "bfdio.c",
+ "bfdwin.c", "section.c", "archures.c", "reloc.c", "syms.c", "bfd.c",
+ "archive.c", "corefile.c", "targets.c", "format.c", "linker.c",
+ "simple.c" and "compress.c".
Run "make headers" in your build bfd/ to regenerate. */
/* Main header file for the bfd library -- portable access to object files.
@@ -488,13 +488,6 @@ startswith (const char *str, const char *prefix)
{
return strncmp (str, prefix, strlen (prefix)) == 0;
}
-/* Extracted from init.c. */
-unsigned int bfd_init (void);
-
-
-/* Value returned by bfd_init. */
-
-#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
/* Extracted from opncls.c. */
/* Set to N to open the next N BFDs using an alternate id space. */
extern unsigned int bfd_use_reserved_id;
@@ -7263,6 +7256,11 @@ bfd_vma bfd_emul_get_commonpagesize (const char *);
char *bfd_demangle (bfd *, const char *, int);
+unsigned int bfd_init (void);
+
+/* Value returned by bfd_init. */
+#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
+
/* Extracted from archive.c. */
symindex bfd_get_next_mapent
(bfd *abfd, symindex previous, carsym **sym);
diff --git a/bfd/bfd.c b/bfd/bfd.c
index 9cbb674b989..1d1c4498938 100644
--- a/bfd/bfd.c
+++ b/bfd/bfd.c
@@ -696,9 +696,9 @@ CODE_FRAGMENT
.
*/
-static bfd_error_type bfd_error = bfd_error_no_error;
-static bfd *input_bfd = NULL;
-static bfd_error_type input_error = bfd_error_no_error;
+static bfd_error_type bfd_error;
+static bfd *input_bfd;
+static bfd_error_type input_error;
const char *const bfd_errmsgs[] =
{
@@ -2605,3 +2605,34 @@ _bfd_get_link_info (bfd *abfd)
return elf_link_info (abfd);
}
+
+/*
+FUNCTION
+ bfd_init
+
+SYNOPSIS
+ unsigned int bfd_init (void);
+
+DESCRIPTION
+ This routine must be called before any other BFD function to
+ initialize magical internal data structures.
+ Returns a magic number, which may be used to check
+ that the bfd library is configured as expected by users.
+
+.{* Value returned by bfd_init. *}
+.#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
+.
+*/
+
+unsigned int
+bfd_init (void)
+{
+ bfd_error = bfd_error_no_error;
+ input_bfd = NULL;
+ input_error = bfd_error_no_error;
+ _bfd_error_program_name = NULL;
+ _bfd_error_internal = error_handler_fprintf;
+ _bfd_assert_handler = _bfd_default_assert_handler;
+
+ return BFD_INIT_MAGIC;
+}
diff --git a/bfd/doc/local.mk b/bfd/doc/local.mk
index cf2b479c1c9..41ab89fc6d8 100644
--- a/bfd/doc/local.mk
+++ b/bfd/doc/local.mk
@@ -32,7 +32,6 @@ DOCFILES = \
%D%/elf.texi \
%D%/format.texi \
%D%/hash.texi \
- %D%/init.texi \
%D%/libbfd.texi \
%D%/linker.texi \
%D%/mmo.texi \
@@ -64,13 +63,12 @@ SRCPROT = $(srcdir)/archive.c $(srcdir)/archures.c \
$(srcdir)/bfdio.c $(srcdir)/bfdwin.c \
$(srcdir)/opncls.c $(srcdir)/reloc.c \
$(srcdir)/section.c $(srcdir)/syms.c \
- $(srcdir)/targets.c $(srcdir)/init.c
+ $(srcdir)/targets.c
SRCIPROT = $(srcdir)/cache.c $(srcdir)/libbfd.c \
$(srcdir)/bfdio.c $(srcdir)/bfdwin.c \
$(srcdir)/reloc.c $(srcdir)/cpu-h8300.c \
- $(srcdir)/archures.c \
- $(srcdir)/init.c
+ $(srcdir)/archures.c
TEXIDIR = $(srcdir)/../texinfo/fsf
diff --git a/bfd/init.c b/bfd/init.c
index eee9891b1b5..bcae3cbdb99 100644
--- a/bfd/init.c
+++ b/bfd/init.c
@@ -33,29 +33,3 @@ SUBSECTION
These are the functions that handle initializing a BFD.
*/
-/*
-FUNCTION
- bfd_init
-
-SYNOPSIS
- unsigned int bfd_init (void);
-
-DESCRIPTION
- This routine must be called before any other BFD function to
- initialize magical internal data structures.
- Returns a magic number, which may be used to check
- that the bfd library is configured as expected by users.
-.
-.{* Value returned by bfd_init. *}
-.
-.#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
-*/
-
-/* Actually, there is currently nothing for this function to do.
- However, someday it may be needed, so keep it around. */
-
-unsigned int
-bfd_init (void)
-{
- return BFD_INIT_MAGIC;
-}
diff --git a/bfd/po/SRC-POTFILES.in b/bfd/po/SRC-POTFILES.in
index 26d5a2ce25d..a127ac0904c 100644
--- a/bfd/po/SRC-POTFILES.in
+++ b/bfd/po/SRC-POTFILES.in
@@ -284,7 +284,6 @@ i386bsd.c
i386lynx.c
i386msdos.c
ihex.c
-init.c
irix-core.c
libaout.h
libbfd.c
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Move bfd_init to bfd.c
2023-01-09 23:18 Move bfd_init to bfd.c Alan Modra
@ 2023-01-10 9:47 ` Jan Beulich
2023-01-10 9:57 ` Luis Machado
2023-01-10 10:11 ` Alan Modra
0 siblings, 2 replies; 6+ messages in thread
From: Jan Beulich @ 2023-01-10 9:47 UTC (permalink / raw)
To: Alan Modra; +Cc: binutils
On 10.01.2023 00:18, Alan Modra via Binutils wrote:
> init.c contains just one function that doesn't do much. Move it to
> bfd.c and give it something to do, initialising static state. So far
> the only initialisation is for bfd.c static variables.
>
> The idea behind reinitialising state is to see whether some set of
> flaky oss-fuzz crashes go away. oss-fuzz stresses binutils in ways
> that can't occur in reality, feeding multiple testcases into the
> internals of binutils. So one testcase may affect the result of the
> next testcase.
>
> * init.c: Delete file. Move bfd_init to..
> * bfd.c (bfd_init): ..here. Init static variables.
> * Makefile.am (BFD32_LIBS): Remove init.lo.
> (BFD32_LIBS_CFILES, BFD_H_FILES): Remove init.c.
> * doc/local.mk: Remove mention of init.texi and init.c.
If I'm not mistaken this should also have touched bfd.texi to remove
the inclusion of init.texi?
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Move bfd_init to bfd.c
2023-01-10 9:47 ` Jan Beulich
@ 2023-01-10 9:57 ` Luis Machado
2023-01-10 10:14 ` Alan Modra
2023-01-10 10:11 ` Alan Modra
1 sibling, 1 reply; 6+ messages in thread
From: Luis Machado @ 2023-01-10 9:57 UTC (permalink / raw)
To: Jan Beulich, Alan Modra; +Cc: binutils
On 1/10/23 09:47, Jan Beulich via Binutils wrote:
> On 10.01.2023 00:18, Alan Modra via Binutils wrote:
>> init.c contains just one function that doesn't do much. Move it to
>> bfd.c and give it something to do, initialising static state. So far
>> the only initialisation is for bfd.c static variables.
>>
>> The idea behind reinitialising state is to see whether some set of
>> flaky oss-fuzz crashes go away. oss-fuzz stresses binutils in ways
>> that can't occur in reality, feeding multiple testcases into the
>> internals of binutils. So one testcase may affect the result of the
>> next testcase.
>>
>> * init.c: Delete file. Move bfd_init to..
>> * bfd.c (bfd_init): ..here. Init static variables.
>> * Makefile.am (BFD32_LIBS): Remove init.lo.
>> (BFD32_LIBS_CFILES, BFD_H_FILES): Remove init.c.
>> * doc/local.mk: Remove mention of init.texi and init.c.
>
> If I'm not mistaken this should also have touched bfd.texi to remove
> the inclusion of init.texi?
>
> Jan
>
I seem to be getting:
../../../repos/binutils-gdb/bfd/doc/bfd.texi:246: @include: could not find init.texi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Move bfd_init to bfd.c
2023-01-10 9:47 ` Jan Beulich
2023-01-10 9:57 ` Luis Machado
@ 2023-01-10 10:11 ` Alan Modra
1 sibling, 0 replies; 6+ messages in thread
From: Alan Modra @ 2023-01-10 10:11 UTC (permalink / raw)
To: Jan Beulich; +Cc: binutils
On Tue, Jan 10, 2023 at 10:47:25AM +0100, Jan Beulich wrote:
> On 10.01.2023 00:18, Alan Modra via Binutils wrote:
> > init.c contains just one function that doesn't do much. Move it to
> > bfd.c and give it something to do, initialising static state. So far
> > the only initialisation is for bfd.c static variables.
> >
> > The idea behind reinitialising state is to see whether some set of
> > flaky oss-fuzz crashes go away. oss-fuzz stresses binutils in ways
> > that can't occur in reality, feeding multiple testcases into the
> > internals of binutils. So one testcase may affect the result of the
> > next testcase.
> >
> > * init.c: Delete file. Move bfd_init to..
> > * bfd.c (bfd_init): ..here. Init static variables.
> > * Makefile.am (BFD32_LIBS): Remove init.lo.
> > (BFD32_LIBS_CFILES, BFD_H_FILES): Remove init.c.
> > * doc/local.mk: Remove mention of init.texi and init.c.
>
> If I'm not mistaken this should also have touched bfd.texi to remove
> the inclusion of init.texi?
Yes, I just found the bad news from the buildbot.
Commit b1c95bc4dd73 resulted in
...bfd.texi:246: @include: could not find init.texi
which went unnoticed due to not building in a clean directory.
This fixes the problem by moving bfd_init earlier, giving it a
doc node, and stitching the nodes back together.
* bfd.c (bfd_init): Move earlier. Give it a doc inode.
Adjust other inodes to suit.
* doc/bfd.texi: Don't include init.texi. Adjust nodes to suit.
* bfd-in2.h: Regenerate.
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index bb2b30200dc..b6e417f26ec 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -7105,6 +7105,11 @@ typedef void (*bfd_assert_handler_type) (const char *bfd_formatmsg,
bfd_assert_handler_type bfd_set_assert_handler (bfd_assert_handler_type);
+unsigned int bfd_init (void);
+
+/* Value returned by bfd_init. */
+#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
+
long bfd_get_reloc_upper_bound (bfd *abfd, asection *sect);
long bfd_canonicalize_reloc
@@ -7256,11 +7261,6 @@ bfd_vma bfd_emul_get_commonpagesize (const char *);
char *bfd_demangle (bfd *, const char *, int);
-unsigned int bfd_init (void);
-
-/* Value returned by bfd_init. */
-#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
-
/* Extracted from archive.c. */
symindex bfd_get_next_mapent
(bfd *abfd, symindex previous, carsym **sym);
diff --git a/bfd/bfd.c b/bfd/bfd.c
index 1d1c4498938..c59e31d99e2 100644
--- a/bfd/bfd.c
+++ b/bfd/bfd.c
@@ -643,7 +643,7 @@ CODE_FRAGMENT
\f
/*
INODE
-Error reporting, Miscellaneous, typedef bfd, BFD front end
+Error reporting, Initialization, typedef bfd, BFD front end
SECTION
Error reporting
@@ -1628,10 +1628,44 @@ bfd_set_assert_handler (bfd_assert_handler_type pnew)
_bfd_assert_handler = pnew;
return pold;
}
+
+/*
+INODE
+Initialization, Miscellaneous, Error reporting, BFD front end
+
+FUNCTION
+ bfd_init
+
+SYNOPSIS
+ unsigned int bfd_init (void);
+
+DESCRIPTION
+ This routine must be called before any other BFD function to
+ initialize magical internal data structures.
+ Returns a magic number, which may be used to check
+ that the bfd library is configured as expected by users.
+
+.{* Value returned by bfd_init. *}
+.#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
+.
+*/
+
+unsigned int
+bfd_init (void)
+{
+ bfd_error = bfd_error_no_error;
+ input_bfd = NULL;
+ input_error = bfd_error_no_error;
+ _bfd_error_program_name = NULL;
+ _bfd_error_internal = error_handler_fprintf;
+ _bfd_assert_handler = _bfd_default_assert_handler;
+
+ return BFD_INIT_MAGIC;
+}
\f
/*
INODE
-Miscellaneous, Memory Usage, Error reporting, BFD front end
+Miscellaneous, Memory Usage, Initialization, BFD front end
SECTION
Miscellaneous
@@ -2605,34 +2639,3 @@ _bfd_get_link_info (bfd *abfd)
return elf_link_info (abfd);
}
-
-/*
-FUNCTION
- bfd_init
-
-SYNOPSIS
- unsigned int bfd_init (void);
-
-DESCRIPTION
- This routine must be called before any other BFD function to
- initialize magical internal data structures.
- Returns a magic number, which may be used to check
- that the bfd library is configured as expected by users.
-
-.{* Value returned by bfd_init. *}
-.#define BFD_INIT_MAGIC (sizeof (struct bfd_section))
-.
-*/
-
-unsigned int
-bfd_init (void)
-{
- bfd_error = bfd_error_no_error;
- input_bfd = NULL;
- input_error = bfd_error_no_error;
- _bfd_error_program_name = NULL;
- _bfd_error_internal = error_handler_fprintf;
- _bfd_assert_handler = _bfd_default_assert_handler;
-
- return BFD_INIT_MAGIC;
-}
diff --git a/bfd/doc/bfd.texi b/bfd/doc/bfd.texi
index 7374e37f8cf..f348710845f 100644
--- a/bfd/doc/bfd.texi
+++ b/bfd/doc/bfd.texi
@@ -198,9 +198,9 @@ IEEE-695.
@menu
* typedef bfd::
* Error reporting::
+* Initialization::
* Miscellaneous::
* Memory Usage::
-* Initialization::
* Sections::
* Symbols::
* Archives::
@@ -219,7 +219,7 @@ IEEE-695.
@include bfdt.texi
@include bfdio.texi
-@node Memory Usage, Initialization, Miscellaneous, BFD front end
+@node Memory Usage, Sections, Miscellaneous, BFD front end
@section Memory Usage
BFD keeps all of its internal structures in obstacks. There is one obstack
per open BFD file, into which the current state is stored. When a BFD is
@@ -242,10 +242,7 @@ select the greediest open BFD, close it to reclaim the memory, perform
some operation and reopen the BFD again, to get a fresh copy of the data
structures.
-@node Initialization, Sections, Memory Usage, BFD front end
-@include init.texi
-
-@node Sections, Symbols, Initialization, BFD front end
+@node Sections, Symbols, Memory Usage, BFD front end
@include section.texi
@node Symbols, Archives, Sections, BFD front end
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Move bfd_init to bfd.c
2023-01-10 9:57 ` Luis Machado
@ 2023-01-10 10:14 ` Alan Modra
2023-01-10 13:13 ` Luis Machado
0 siblings, 1 reply; 6+ messages in thread
From: Alan Modra @ 2023-01-10 10:14 UTC (permalink / raw)
To: Luis Machado; +Cc: Jan Beulich, binutils
On Tue, Jan 10, 2023 at 09:57:36AM +0000, Luis Machado wrote:
> I seem to be getting:
>
> ../../../repos/binutils-gdb/bfd/doc/bfd.texi:246: @include: could not find init.texi
Should be fixed now. Sorry for the inconvenience.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Move bfd_init to bfd.c
2023-01-10 10:14 ` Alan Modra
@ 2023-01-10 13:13 ` Luis Machado
0 siblings, 0 replies; 6+ messages in thread
From: Luis Machado @ 2023-01-10 13:13 UTC (permalink / raw)
To: Alan Modra; +Cc: Jan Beulich, binutils
On 1/10/23 10:14, Alan Modra wrote:
> On Tue, Jan 10, 2023 at 09:57:36AM +0000, Luis Machado wrote:
>> I seem to be getting:
>>
>> ../../../repos/binutils-gdb/bfd/doc/bfd.texi:246: @include: could not find init.texi
>
> Should be fixed now. Sorry for the inconvenience.
>
No worries. Thanks for fixing it.
Buildbots seems to be going green again.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-10 13:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09 23:18 Move bfd_init to bfd.c Alan Modra
2023-01-10 9:47 ` Jan Beulich
2023-01-10 9:57 ` Luis Machado
2023-01-10 10:14 ` Alan Modra
2023-01-10 13:13 ` Luis Machado
2023-01-10 10:11 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).