From: Indu Bhagat <indu.bhagat@oracle.com>
To: Jens Remus <jremus@linux.ibm.com>, binutils@sourceware.org
Cc: Andreas Krebbel <krebbel@linux.ibm.com>
Subject: Re: [PATCH v3 06/15] gas: Skip SFrame FDE if CFI specifies non-FP/SP base register
Date: Thu, 18 Apr 2024 00:40:30 -0700 [thread overview]
Message-ID: <ae282205-db6a-46a1-9864-9e3ea888542c@oracle.com> (raw)
In-Reply-To: <20240412144718.4191286-7-jremus@linux.ibm.com>
On 4/12/24 07:47, Jens Remus wrote:
> Do not generate SFrame FDE if DWARF CFI directives .cfi_def_cfa or
> .cfi_def_cfa_register specify a CFA base register number other than
> the architecture-specific stack-pointer (SP) or frame-pointer (FP)
> register numbers.
>
> This also causes the assembler to print a warning message, so that
> skipping of the SFrame FDE does not occur silently.
>
> Update the generic ld SFrame test case to be architecture independent.
> Do not use CFI directive .cfi_def_cfa, as the specified CFA base
> register number is not a valid SP/FP register number on all
> architectures. An invalid SP/FP register number will now cause the
> assembler to print a warning message and skip SFrame FDE generation.
> Remove the offending CFI directive, that cannot be coded architecture-
> independent, as the test case requires SFrame information to be
> generated. This was reported by the Linaro-TCWG-CI for AArch64.
>
> gas/
> * gen-sframe.c: Skip SFrame generation if CFI specifies
> non-FP/SP base register.
>
> ld/testsuite/
> * ld-sframe/discard.s: Update generic SFrame test case to be
> architecture independent.
>
OK.
Thanks
> Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
> Reviewed-by: Indu Bhagat <indu.bhagat@oracle.com>
> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
> ---
>
> Notes (jremus):
> Changes v2 -> v3:
> - Corrected formatting of ChangeLog in commit message.
>
> Changes v1 -> v2:
> - Update generic SFrame test case to be architecture independent to
> resolve generic ld SFrame test case failure reported by
> Linaro-TCWG-CI for AArch64. It would fail similar on s390x.
>
> Without this patch the assembler would erroneously generate bad SFrame
> information for the s390-specific SFrame error test cases 1 and 2, that
> get introduced by patch "s390: Initial support to generate .sframe from
> CFI directives in assembler".
>
> gas/gen-sframe.c | 13 +++++++++++--
> ld/testsuite/ld-sframe/discard.s | 1 -
> 2 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c
> index d35baaac54b2..1269b2b77c54 100644
> --- a/gas/gen-sframe.c
> +++ b/gas/gen-sframe.c
> @@ -986,7 +986,11 @@ sframe_xlate_do_def_cfa (struct sframe_xlate_ctx *xlate_ctx,
> get_dw_fde_start_addrS (xlate_ctx->dw_fde));
> }
> /* Define the current CFA rule to use the provided register and
> - offset. */
> + offset. However, if the register is not FP/SP, skip creating
> + SFrame stack trace info for the function. */
> + if (cfi_insn->u.r != SFRAME_CFA_SP_REG
> + && cfi_insn->u.r != SFRAME_CFA_FP_REG)
> + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */
> sframe_fre_set_cfa_base_reg (cur_fre, cfi_insn->u.ri.reg);
> sframe_fre_set_cfa_offset (cur_fre, cfi_insn->u.ri.offset);
> cur_fre->merge_candidate = false;
> @@ -1004,9 +1008,14 @@ sframe_xlate_do_def_cfa_register (struct sframe_xlate_ctx *xlate_ctx,
> struct sframe_row_entry *last_fre = xlate_ctx->last_fre;
> /* Get the scratchpad FRE. This FRE will eventually get linked in. */
> struct sframe_row_entry *cur_fre = xlate_ctx->cur_fre;
> +
> gas_assert (cur_fre);
> /* Define the current CFA rule to use the provided register (but to
> - keep the old offset). */
> + keep the old offset). However, if the register is not FP/SP,
> + skip creating SFrame stack trace info for the function. */
> + if (cfi_insn->u.r != SFRAME_CFA_SP_REG
> + && cfi_insn->u.r != SFRAME_CFA_FP_REG)
> + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */
> sframe_fre_set_cfa_base_reg (cur_fre, cfi_insn->u.ri.reg);
> sframe_fre_set_cfa_offset (cur_fre, last_fre->cfa_offset);
> cur_fre->merge_candidate = false;
> diff --git a/ld/testsuite/ld-sframe/discard.s b/ld/testsuite/ld-sframe/discard.s
> index a438b42bffa1..5591a50d486a 100644
> --- a/ld/testsuite/ld-sframe/discard.s
> +++ b/ld/testsuite/ld-sframe/discard.s
> @@ -5,7 +5,6 @@
> foo:
> .cfi_startproc
> .cfi_def_cfa_offset 16
> - .cfi_def_cfa 7, 8
> .cfi_endproc
>
> .globl _start
next prev parent reply other threads:[~2024-04-18 7:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 14:47 [PATCH v3 00/15] sframe: Enhancements to SFrame info generation Jens Remus
2024-04-12 14:47 ` [PATCH v3 01/15] x86: Remove unused SFrame CFI RA register variable Jens Remus
2024-04-12 14:47 ` [PATCH v3 02/15] gas: Enhance arch-specific SFrame configuration descriptions Jens Remus
2024-04-18 7:39 ` Indu Bhagat
2024-05-03 12:30 ` Jens Remus
2024-04-12 14:47 ` [PATCH v3 03/15] readelf/objdump: Dump SFrame CFA fixed FP and RA offsets Jens Remus
2024-04-18 7:39 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 04/15] readelf/objdump: Display SFrame fixed RA offset as 'f' in dump Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 05/15] gas: Print DWARF call frame insn name in SFrame warning message Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 06/15] gas: Skip SFrame FDE if CFI specifies non-FP/SP base register Jens Remus
2024-04-18 7:40 ` Indu Bhagat [this message]
2024-04-12 14:47 ` [PATCH v3 07/15] gas: Warn if SFrame FDE is skipped due to non-default return column Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 08/15] gas: Refactor SFrame CFI opcode DW_CFA_register processing Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 09/15] gas: User readable warnings if SFrame FDE is not generated Jens Remus
2024-04-18 20:33 ` Indu Bhagat
2024-05-03 12:30 ` Jens Remus
2024-05-03 23:41 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 10/15] gas: Skip SFrame FDE if FP without RA on stack Jens Remus
2024-04-16 13:14 ` Jens Remus
2024-04-17 23:56 ` Indu Bhagat
2024-04-18 10:27 ` Jens Remus
2024-04-18 20:35 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 11/15] gas: Skip SFrame FDE if .cfi_window_save Jens Remus
2024-04-18 20:36 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 12/15] gas: Don't skip SFrame FDE if .cfi_register specifies RA w/o tracking Jens Remus
2024-04-18 20:36 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 13/15] gas: Don't skip SFrame FDE if .cfi_register specifies SP register Jens Remus
2024-04-18 20:37 ` Indu Bhagat
2024-04-19 13:13 ` Jens Remus
2024-04-23 8:15 ` Indu Bhagat
2024-04-25 22:22 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 14/15] gas: Test predicate whether SFrame RA tracking is used Jens Remus
2024-04-18 20:37 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 15/15] gas: Validate SFrame RA tracking and fixed RA offset Jens Remus
2024-04-18 20:38 ` Indu Bhagat
2024-05-03 16:40 ` Jens Remus
2024-05-04 0:22 ` Indu Bhagat
2024-05-06 11:41 ` Jens Remus
2024-05-06 14:39 ` Jens Remus
2024-05-16 20:45 ` Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae282205-db6a-46a1-9864-9e3ea888542c@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=jremus@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).