From: Indu Bhagat <indu.bhagat@oracle.com>
To: Jens Remus <jremus@linux.ibm.com>, binutils@sourceware.org
Cc: Andreas Krebbel <krebbel@linux.ibm.com>
Subject: Re: [PATCH v3 08/15] gas: Refactor SFrame CFI opcode DW_CFA_register processing
Date: Thu, 18 Apr 2024 00:40:50 -0700 [thread overview]
Message-ID: <b52a3859-75c1-411b-81d7-86e92353e9b1@oracle.com> (raw)
In-Reply-To: <20240412144718.4191286-9-jremus@linux.ibm.com>
On 4/12/24 07:47, Jens Remus wrote:
> Refactor SFrame processing of CFI opcode DW_CFA_register into a separate
> function. This harmonizes the CFI opcode processing.
>
> While at it reword the comment on CFI opcodes that are not processed.
>
> This is a purely mechanical change.
>
> gas/
> * gen-sframe.c (sframe_do_cfi_insn, sframe_xlate_do_register):
> Refactor SFrame CFI opcode DW_CFA_register processing.
>
OK.
Thanks
> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
> ---
>
> Notes (jremus):
> Changes v2 -> v3:
> - New patch.
>
> gas/gen-sframe.c | 37 ++++++++++++++++++++++++++-----------
> 1 file changed, 26 insertions(+), 11 deletions(-)
>
> diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c
> index fe8b24906c1b..f47f51c7a354 100644
> --- a/gas/gen-sframe.c
> +++ b/gas/gen-sframe.c
> @@ -1108,6 +1108,28 @@ sframe_xlate_do_val_offset (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED,
> return SFRAME_XLATE_OK;
> }
>
> +/* Translate DW_CFA_register into SFrame context.
> + Return SFRAME_XLATE_OK if success. */
> +
> +static int
> +sframe_xlate_do_register (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED,
> + struct cfi_insn_data *cfi_insn)
> +{
> + /* Previous value of register1 is register2. However, if the specified
> + register1 is not interesting (SP, FP, or RA reg), the current DW_CFA_register
> + instruction can be safely skipped without sacrificing the asynchronicity of
> + stack trace information. */
> + if (cfi_insn->u.rr.reg1 == SFRAME_CFA_SP_REG
> +#ifdef SFRAME_FRE_RA_TRACKING
> + || (cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG)
> +#endif
> + || cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG)
> + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */
> +
> + /* Safe to skip. */
> + return SFRAME_XLATE_OK;
> +}
> +
> /* Translate DW_CFA_remember_state into SFrame context.
> Return SFRAME_XLATE_OK if success. */
>
> @@ -1296,19 +1318,12 @@ sframe_do_cfi_insn (struct sframe_xlate_ctx *xlate_ctx,
> case DW_CFA_GNU_window_save:
> err = sframe_xlate_do_gnu_window_save (xlate_ctx, cfi_insn);
> break;
> - /* Other CFI opcodes are not processed at this time.
> - These do not impact the coverage of the basic stack tracing
> - information as conveyed in the SFrame format.
> - - DW_CFA_register,
> - - etc. */
> case DW_CFA_register:
> - if (cfi_insn->u.rr.reg1 == SFRAME_CFA_SP_REG
> -#ifdef SFRAME_FRE_RA_TRACKING
> - || cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG
> -#endif
> - || cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG)
> - err = SFRAME_XLATE_ERR_NOTREPRESENTED;
> + err = sframe_xlate_do_register (xlate_ctx, cfi_insn);
> break;
> + /* Following CFI opcodes are not processed at this time.
> + These do not impact the coverage of the basic stack tracing
> + information as conveyed in the SFrame format. */
> case DW_CFA_undefined:
> case DW_CFA_same_value:
> break;
next prev parent reply other threads:[~2024-04-18 7:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 14:47 [PATCH v3 00/15] sframe: Enhancements to SFrame info generation Jens Remus
2024-04-12 14:47 ` [PATCH v3 01/15] x86: Remove unused SFrame CFI RA register variable Jens Remus
2024-04-12 14:47 ` [PATCH v3 02/15] gas: Enhance arch-specific SFrame configuration descriptions Jens Remus
2024-04-18 7:39 ` Indu Bhagat
2024-05-03 12:30 ` Jens Remus
2024-04-12 14:47 ` [PATCH v3 03/15] readelf/objdump: Dump SFrame CFA fixed FP and RA offsets Jens Remus
2024-04-18 7:39 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 04/15] readelf/objdump: Display SFrame fixed RA offset as 'f' in dump Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 05/15] gas: Print DWARF call frame insn name in SFrame warning message Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 06/15] gas: Skip SFrame FDE if CFI specifies non-FP/SP base register Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 07/15] gas: Warn if SFrame FDE is skipped due to non-default return column Jens Remus
2024-04-18 7:40 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 08/15] gas: Refactor SFrame CFI opcode DW_CFA_register processing Jens Remus
2024-04-18 7:40 ` Indu Bhagat [this message]
2024-04-12 14:47 ` [PATCH v3 09/15] gas: User readable warnings if SFrame FDE is not generated Jens Remus
2024-04-18 20:33 ` Indu Bhagat
2024-05-03 12:30 ` Jens Remus
2024-05-03 23:41 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 10/15] gas: Skip SFrame FDE if FP without RA on stack Jens Remus
2024-04-16 13:14 ` Jens Remus
2024-04-17 23:56 ` Indu Bhagat
2024-04-18 10:27 ` Jens Remus
2024-04-18 20:35 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 11/15] gas: Skip SFrame FDE if .cfi_window_save Jens Remus
2024-04-18 20:36 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 12/15] gas: Don't skip SFrame FDE if .cfi_register specifies RA w/o tracking Jens Remus
2024-04-18 20:36 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 13/15] gas: Don't skip SFrame FDE if .cfi_register specifies SP register Jens Remus
2024-04-18 20:37 ` Indu Bhagat
2024-04-19 13:13 ` Jens Remus
2024-04-23 8:15 ` Indu Bhagat
2024-04-25 22:22 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 14/15] gas: Test predicate whether SFrame RA tracking is used Jens Remus
2024-04-18 20:37 ` Indu Bhagat
2024-04-12 14:47 ` [PATCH v3 15/15] gas: Validate SFrame RA tracking and fixed RA offset Jens Remus
2024-04-18 20:38 ` Indu Bhagat
2024-05-03 16:40 ` Jens Remus
2024-05-04 0:22 ` Indu Bhagat
2024-05-06 11:41 ` Jens Remus
2024-05-06 14:39 ` Jens Remus
2024-05-16 20:45 ` Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52a3859-75c1-411b-81d7-86e92353e9b1@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=jremus@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).