From: Nick Clifton <nickc@redhat.com>
To: Will Hawkins <hawkinsw@obs.cr>, binutils@sourceware.org
Subject: Re: [PATCH 0/1] objdump: Add callx support for BPF CPU v1
Date: Mon, 12 Feb 2024 17:01:34 +0000 [thread overview]
Message-ID: <b9995c67-a234-4dcf-b715-061e8e8c5217@redhat.com> (raw)
In-Reply-To: <20240209180734.443763-1-hawkinsw@obs.cr>
Hi Will,
> First time patch submitter but long time GNU enthusiast. Thank you for
> all the work that you all do to maintain these vital pieces of software
> for the community.
Welcome on board and thank you contributing.
> I tried very hard to follow best practices for creating this patch
> submission but I am sure that I did something wrong. Please let me know
> what I can do differently or better.
No, no, what you did was excellent. My only suggestions is that
with your v2 patch you consider adding a new assembler test (or
extending an already existing one) that checks that the instruction
can be assembled and then disassembled. For example you might
like to add it to gas/testsuite/gas/bpf/call.s (and the associated
call.d file for the disassembly).
Cheers
Nick
prev parent reply other threads:[~2024-02-12 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 18:07 Will Hawkins
2024-02-09 18:07 ` [PATCH 1/1] " Will Hawkins
2024-02-10 4:47 ` Hans-Peter Nilsson
2024-02-10 6:13 ` Will Hawkins
2024-02-11 23:26 ` Will Hawkins
2024-02-12 17:01 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9995c67-a234-4dcf-b715-061e8e8c5217@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=hawkinsw@obs.cr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).