* [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c'
@ 2024-04-22 9:35 Victor Do Nascimento
2024-04-22 12:26 ` Christophe Lyon
2024-04-23 12:13 ` Richard Earnshaw (lists)
0 siblings, 2 replies; 3+ messages in thread
From: Victor Do Nascimento @ 2024-04-22 9:35 UTC (permalink / raw)
To: binutils; +Cc: richard.earnshaw, nickc, Victor Do Nascimento
Fix integer value being returned from boolean function, as introduced
in `aarch64: Remove asserts from operand qualifier decoders [PR31595]'.
---
opcodes/aarch64-dis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
index b70e6da9eb7..e1c3f557874 100644
--- a/opcodes/aarch64-dis.c
+++ b/opcodes/aarch64-dis.c
@@ -1038,7 +1038,7 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED,
return false;
info->qualifier = get_sreg_qualifier_from_value (value);
if (info->qualifier == AARCH64_OPND_QLF_ERR)
- return 0;
+ return false;
}
return true;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c'
2024-04-22 9:35 [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c' Victor Do Nascimento
@ 2024-04-22 12:26 ` Christophe Lyon
2024-04-23 12:13 ` Richard Earnshaw (lists)
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Lyon @ 2024-04-22 12:26 UTC (permalink / raw)
To: Victor Do Nascimento; +Cc: binutils, richard.earnshaw, nickc
Hi Victor,
On Mon, 22 Apr 2024 at 11:35, Victor Do Nascimento
<victor.donascimento@arm.com> wrote:
>
> Fix integer value being returned from boolean function, as introduced
> in `aarch64: Remove asserts from operand qualifier decoders [PR31595]'.
> ---
> opcodes/aarch64-dis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
> index b70e6da9eb7..e1c3f557874 100644
> --- a/opcodes/aarch64-dis.c
> +++ b/opcodes/aarch64-dis.c
> @@ -1038,7 +1038,7 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED,
> return false;
> info->qualifier = get_sreg_qualifier_from_value (value);
> if (info->qualifier == AARCH64_OPND_QLF_ERR)
> - return 0;
> + return false;
> }
>
> return true;
> --
> 2.34.1
>
I'd say this counts as 'obvious' ?
Thanks,
Christophe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c'
2024-04-22 9:35 [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c' Victor Do Nascimento
2024-04-22 12:26 ` Christophe Lyon
@ 2024-04-23 12:13 ` Richard Earnshaw (lists)
1 sibling, 0 replies; 3+ messages in thread
From: Richard Earnshaw (lists) @ 2024-04-23 12:13 UTC (permalink / raw)
To: Victor Do Nascimento, binutils; +Cc: nickc
On 22/04/2024 10:35, Victor Do Nascimento wrote:
> Fix integer value being returned from boolean function, as introduced
> in `aarch64: Remove asserts from operand qualifier decoders [PR31595]'.
> ---
> opcodes/aarch64-dis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
> index b70e6da9eb7..e1c3f557874 100644
> --- a/opcodes/aarch64-dis.c
> +++ b/opcodes/aarch64-dis.c
> @@ -1038,7 +1038,7 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED,
> return false;
> info->qualifier = get_sreg_qualifier_from_value (value);
> if (info->qualifier == AARCH64_OPND_QLF_ERR)
> - return 0;
> + return false;
> }
>
> return true;
OK, thanks.
R.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-23 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22 9:35 [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c' Victor Do Nascimento
2024-04-22 12:26 ` Christophe Lyon
2024-04-23 12:13 ` Richard Earnshaw (lists)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).