* [PATCH] RISC-V: as_warn() already emits a newline
@ 2023-02-16 8:56 Jan Beulich
2023-02-20 2:46 ` Nelson Chu
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2023-02-16 8:56 UTC (permalink / raw)
To: Binutils; +Cc: Palmer Dabbelt, Andrew Waterman, Jim Wilson, Nelson Chu
Therefore there shouldn't be any at the end of the format string.
--- a/gas/config/tc-riscv.c
+++ b/gas/config/tc-riscv.c
@@ -4179,7 +4179,7 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
}
else
{
- as_warn (_("unrecognized .option directive: %s\n"), name);
+ as_warn (_("unrecognized .option directive: %s"), name);
}
*input_line_pointer = ch;
demand_empty_rest_of_line ();
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] RISC-V: as_warn() already emits a newline
2023-02-16 8:56 [PATCH] RISC-V: as_warn() already emits a newline Jan Beulich
@ 2023-02-20 2:46 ` Nelson Chu
0 siblings, 0 replies; 2+ messages in thread
From: Nelson Chu @ 2023-02-20 2:46 UTC (permalink / raw)
To: Jan Beulich; +Cc: Binutils, Palmer Dabbelt, Andrew Waterman, Jim Wilson
OK, thanks for fixing this.
Nelson
On Thu, Feb 16, 2023 at 4:56 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> Therefore there shouldn't be any at the end of the format string.
>
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -4179,7 +4179,7 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
> }
> else
> {
> - as_warn (_("unrecognized .option directive: %s\n"), name);
> + as_warn (_("unrecognized .option directive: %s"), name);
> }
> *input_line_pointer = ch;
> demand_empty_rest_of_line ();
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-20 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-16 8:56 [PATCH] RISC-V: as_warn() already emits a newline Jan Beulich
2023-02-20 2:46 ` Nelson Chu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).