From: "Martin Liška" <mliska@suse.cz>
To: Mark Wielaard <mark@klomp.org>
Cc: buildbot@sourceware.org
Subject: Re: [RFC,PATCH] containers: extract bb-start.sh to a file and reuse it
Date: Sun, 19 Jun 2022 09:12:12 +0200 [thread overview]
Message-ID: <2c76b4a2-861e-159b-2239-8ae54d5ea114@suse.cz> (raw)
In-Reply-To: <Yq4xfSTSLr5Hwybr@wildebeest.org>
On 6/18/22 22:11, Mark Wielaard wrote:
> Hi Martin,
>
> On Sat, Jun 18, 2022 at 08:35:06PM +0200, Martin Liška wrote:
>>> I like this. But we cannot simply COPY in the bb-start.sh file.
>>> Because it isn't available on the container host. The
>>> DockerLatentWorker only sents the Container file. But we could fetch
>>> it from the git repo using:
>>>
>>> RUN wget -O /home/builder/bb-start.sh \
>>> 'https://sourceware.org/git/?p=builder.git;a=blob_plain;f=builder/containers/bb-start.sh' \
>>> && chmod 755 /home/builder/bb-start.sh
>>
>> Good, I've done that and pushed to main.
>>
>> However, I see an error now:
>> https://builder.sourceware.org/buildbot/#/builders/97/builds/248
>>
>> Can you please check buildbot master log files in order to investigate what's wrong?
>
> The issue was that there were now both a RUN wget && chmod and a COPY
> in the Container files. Removing the COPY seems to have made it work again.
Oh, what a stupid mistake I've made.
Thanks for the fix!
Martin
>
> Cheers,
>
> Mark
prev parent reply other threads:[~2022-06-19 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 9:17 Martin Liška
2022-06-18 15:47 ` Mark Wielaard
2022-06-18 18:35 ` Martin Liška
2022-06-18 18:38 ` Martin Liška
2022-06-18 20:11 ` Mark Wielaard
2022-06-19 7:12 ` Martin Liška [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c76b4a2-861e-159b-2239-8ae54d5ea114@suse.cz \
--to=mliska@suse.cz \
--cc=buildbot@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).