Re: [PATCH 4/6] autoregen.py: Use autoreconf in most GCC directories

[Mark Wielaard <mark@klomp.org>]

Hi (adding Jakub and Ian to CC),

On Mon, 2024-04-15 at 13:42 +0200, Mark Wielaard wrote:
> On Fri, 2024-04-12 at 20:05 +0000, Christophe Lyon wrote:
> > Add most of GCC's subdirectories to AUTORECONF_DIRS, since 'autoreconf
> > -f' works for them.
> > [...]
> >  # these directories are known to can be re-generatable with a simple autoreconf
> >  # without special -I flags
> >  AUTORECONF_DIRS = [
> > +    # binutils-gdb subdirs
> >      "gdb",
> >      "gdbserver",
> >      "gdbsupport",
> >      "gnulib",
> > +
> > +    # gcc subdirs
> > +    "c++tools", # No aclocal.m4
> > +    #"gcc", # No Makefile.am
> > +    #"fixincludes", # autoreconf complains about GCC_AC_FUNC_MMAP_BLACKLIST
> > +    "gnattools", # No aclocal.m4
> > +    "gotools",
> 
> Oddly this now generates:
> https://builder.sourceware.org/buildbot/#/builders/269/builds/4325
> 
> Entering directory /home/builder/shared/bb3/worker/gcc-
> autoregen/build/gnattools
> + autoreconf-2.69 -f
> 
> [... where before it was just autoconf-2.69 -f ...]
> 
> diff --git a/gotools/Makefile.in b/gotools/Makefile.in
> index 36c2ec2abd3..f40883c39be 100644
> --- a/gotools/Makefile.in
> +++ b/gotools/Makefile.in
> @@ -704,8 +704,8 @@ distclean-generic:
>  maintainer-clean-generic:
>  	@echo "This command is intended for maintainers to use"
>  	@echo "it deletes files that may require special tools to
> rebuild."
> -@NATIVE_FALSE@install-exec-local:
>  @NATIVE_FALSE@uninstall-local:
> +@NATIVE_FALSE@install-exec-local:
>  clean: clean-am
>  
>  clean-am: clean-binPROGRAMS clean-generic clean-noinstPROGRAMS \
> 
> This started with:
> https://gcc.gnu.org/cgit/gcc/commit/?id=f7c8fa7280c85cbdea45be9c09f36123ff16a78a
> 
> Inline 'gcc/rust/Make-lang.in:RUST_LDFLAGS' into single user
> 	gcc/rust/
> 	* Make-lang.in (RUST_LDFLAGS): Inline into single user.
> 
> Which doesn't really make sense, since that doesn't touch gotools at
> all...
> 
> I am not sure why.

Looks like this is just random/non-deterministic.
Jakub has a patch here:
https://inbox.sourceware.org/gcc-patches/Zh0grrP%2FMPu3pXbC@tucnak/T/#u

Cheers,

Mark