Re: [PATCH 0/6] autoregen.py: Improve support for GCC

[Christophe Lyon <christophe.lyon@linaro.org>]

On Mon, 15 Apr 2024 at 00:33, Mark Wielaard <mark@klomp.org> wrote:
>
> Hi Christophe,
>
> On Fri, Apr 12, 2024 at 08:05:53PM +0000, Christophe Lyon wrote:
> > I looked into more details to improve autoregen.py's support for GCC.
> >
> > I noticed that autoreconf works well in most directories, so this
> > patch series adds most GCC subdirs to AUTORECONF_DIRS.
>
> Nice, that simplifies things.
>
> > Following that, I noticed that quite a few more subdirs from
> > binutils-gdb can also be regenerated using autoreconf, so add them to
> > AUTORECONF_DIRS.
>
> Ack.
>
> > In addition, add support for autogen, to regenerate the top-level
> > Makefile.in.
>
> I added autogen to the Containerfile-autotools to make sure it is
> available. I assume the version doesn't matter.

I did not see any mention of a version number in the generated files,
so I assumed it doesn't matter.

>
> > There are still some peculiarities with some subdirs, so there are
> > probably some fixes to make in binutils, gdb and gcc.  We can update
> > this script when that is the case.
> >
> > Also, this script should probably be copied into contrib/ for the
> > benefit of the projects.
>
> Yes, that would be good. Do binutils-gdb/gcc share a contrib dir?
> We could pick up the script from there, we don't necessary need to
> have it in the builder.git itself.

There's a contrib dir in both binutils-gdb and gcc, though gcc's has
many more utilities.
dg-extraact-results.{py,sh} have the same contents, while mklog.py is
not the same in the two repos: the version in binutils-gdb wasn't
updated since it was first copied from the gcc repo.

I suspect the same sync issue would/will happen with autoregen.py, but
still I think it would help developers of both projects to have it in
contrib rather than in builder.git (which I think most people don't
know about).

>
> > Christophe Lyon (6):
> >   auroregen.py: Check AC_CONFIG_MACRO_DIR instead of
> >     AC_CONFIG_MACRO_DIRS
> >   autoregen.py: Move comment...
> >   autoregen.py: Flush all print commands
> >   autoregen.py: Use autoreconf in most GCC directories
> >   autoregen.py: Add support for autogen
> >   autoregen.py: Add binutils directories to AUTORECONF_DIRS
>
> Applied all of them.
>
Thanks!

Christophe

> Thanks,
>
> Mark