Re: [PATCH 3/6] autoregen.py: Flush all print commands

[Christophe Lyon <christophe.lyon@linaro.org>]

On Mon, 15 Apr 2024 at 04:09, Simon Marchi <simark@simark.ca> wrote:
>
>
>
> On 2024-04-12 16:05, Christophe Lyon wrote:
> > For consistency and easier debug of traces
> > ---
> >  builder/containers/autoregen.py | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/builder/containers/autoregen.py b/builder/containers/autoregen.py
> > index 6e341e2..c52a524 100755
> > --- a/builder/containers/autoregen.py
> > +++ b/builder/containers/autoregen.py
> > @@ -56,7 +56,7 @@ AUTORECONF_DIRS = [
> >  #
> >  # Print the command on stdout prior to running it.
> >  def run_shell(cmd: str):
> > -    print(f"+ {cmd}")
> > +    print(f"+ {cmd}", flush=True)
> >      res = subprocess.run(
> >          f"{cmd}",
> >          shell=True,
> > @@ -105,7 +105,7 @@ run_shell(f"{AUTOMAKE_BIN} --version")
> >  run_shell(f"{ACLOCAL_BIN} --version")
> >  run_shell(f"{AUTOHEADER_BIN} --version")
> >
> > -print(f"Extra environment: {EXTRA_ENV}")
> > +print(f"Extra environment: {EXTRA_ENV}", flush=True)
> >
> >  config_folders: list[Path] = []
> >  repo_root = Path.cwd()
>
> Can you clarify when/where/why that's needed?  I would expect the stdout
> stream to be flushed when there is an end-of-line (which print() does).
>

I'm not quite sure now.... I think I was annoyed when looking at
builds in progress on the sourceware buildbot.

> Simon