Re: [PATCH 0/4] v3 of: Option handling: add documentation URLs

* Re: [PATCH 0/4] v3 of: Option handling: add documentation URLs
       [not found] ` <20231214150143.3305661-1-dmalcolm@redhat.com>
@ 2023-12-15  0:59   ` Mark Wielaard
  2023-12-15 14:47     ` David Malcolm
  2024-01-04 14:57     ` CI for "Option handling: add documentation URLs" David Malcolm
  0 siblings, 2 replies; 14+ messages in thread
From: Mark Wielaard @ 2023-12-15  0:59 UTC (permalink / raw)
  To: David Malcolm; +Cc: Joseph Myers, Tobias Burnus, gcc-patches, buildbot

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

Hi David,

On Thu, Dec 14, 2023 at 10:01:39AM -0500, David Malcolm wrote:
> > Once your patch is in please feel free to sent an email to
> > buildbot@sourceware.org
> > https://sourceware.org/mailman/listinfo/buildbot
> > And we'll add the above build steps and update the autotools
> > Containerfile to include the fortran (gfortran?) and d (gdc?) build
> > dependencies.
> 
> Joseph: it seems that we have a way to add CI for this.
> 
> I refreshed the patches and successfully bootstrapped & regrtested them
> on x86_64-pc-linux-gnu; here's the v3 version of them.
> 
> Are these OK for trunk, assuming I followup with adding CI for this?
> (that said, I disappear for the rest of 2023 at the end of this week, so
> I'd work on the CI in early January)

I will be around next week to fixup any CI issues.
But once you commit this we can immediate activate the check.

I have attached a patch for the gcc-autoregen builder to also do
regenerate-opt-urls. Since it is a --disable-bootstrap build and uses
ccache it should take just a few minutes. So can be done on every
commit.

Note that with you patch applied to master it does flag and generate
the attached diff (I assume that is expected).

Cheers,

Mark

[-- Attachment #2: 0001-Add-regenerate-opt-urls-to-gcc-autoregen.patch --]
[-- Type: text/plain, Size: 2985 bytes --]

From 83914698dfb77a85496e93e3faa5de9131347cb8 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Fri, 15 Dec 2023 01:43:27 +0100
Subject: [PATCH] Add regenerate-opt-urls to gcc-autoregen

Add gcc build dependencies and ccacheto Containerfile-autotools.
Add regenerate_opt_urls steps to gcc_autoregen_factory.
---
 builder/containers/Containerfile-autotools |  2 ++
 builder/master.cfg                         | 34 ++++++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/builder/containers/Containerfile-autotools b/builder/containers/Containerfile-autotools
index 1099986..8cc8a22 100644
--- a/builder/containers/Containerfile-autotools
+++ b/builder/containers/Containerfile-autotools
@@ -7,6 +7,8 @@ RUN apt-get update && \
     apt-get upgrade -y && \
     apt-get install -y \
       build-essential libtool perl python3-minimal bash \
+      libmpc-dev libgmp-dev libmpfr-dev gdc texinfo flex \
+      ccache \
       make git \
       gettext \
       m4 pkg-config \
diff --git a/builder/master.cfg b/builder/master.cfg
index 04c54da..0e5ce62 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1200,6 +1200,35 @@ git_diff_step = steps.ShellCommand(
         name="git diff",
         haltOnFailure=True)
 
+# Note that the name of the default workdir is 'build'
+# 'build' is the name of the source checkout (yes, confusing).
+# So this creates 'build/objdir'.
+gcc_build_mkdir_step = steps.ShellCommand(
+        command=['mkdir', '-p', 'objdir'],
+        name='mkdir objdir',
+        haltOnFailure=True)
+
+gcc_configure_opt_urls_step = steps.Configure(
+        workdir='build/objdir',
+        command=["../configure",
+                 "--disable-multilib",
+                 "--disable-bootstrap",
+                 "--enable-languages=c,d,fortran"],
+        name="configure",
+        haltOnFailure=True)
+
+gcc_make_html_step = steps.Compile(
+        workdir='build/objdir',
+        command=['make', util.Interpolate('-j%(prop:ncpus)s'), 'html'],
+        name='make html',
+        haltOnFailure=True)
+
+gcc_make_regenerate_opt_urls_step = steps.Compile(
+        workdir='build/objdir/gcc',
+        command=['make', 'regenerate-opt-urls'],
+        name='make regenerate-opt-urls',
+        haltOnFailure=True)
+
 # Generic make clean step to be run at the end of a build
 make_clean_step = steps.ShellCommand(
         command=["make", "clean"],
@@ -3454,6 +3483,11 @@ gcc_autoregen_factory = util.BuildFactory()
 gcc_autoregen_factory.addStep(gcc_git_step)
 gcc_autoregen_factory.addStep(autoregen_step)
 gcc_autoregen_factory.addStep(git_diff_step)
+gcc_autoregen_factory.addStep(gcc_build_mkdir_step)
+gcc_autoregen_factory.addStep(gcc_configure_opt_urls_step)
+gcc_autoregen_factory.addStep(gcc_make_html_step)
+gcc_autoregen_factory.addStep(gcc_make_regenerate_opt_urls_step)
+gcc_autoregen_factory.addStep(git_diff_step)
 
 gcc_autoregen_builder = util.BuilderConfig(
         name="gcc-autoregen",
-- 
2.39.3


[-- Attachment #3: opt.urls.diff --]
[-- Type: text/plain, Size: 12644 bytes --]

diff --git a/gcc/analyzer/analyzer.opt.urls b/gcc/analyzer/analyzer.opt.urls
index 9f7d33ff434..5fcab720582 100644
--- a/gcc/analyzer/analyzer.opt.urls
+++ b/gcc/analyzer/analyzer.opt.urls
@@ -48,6 +48,9 @@ UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-free-of-non-heap)
 Wanalyzer-imprecise-fp-arithmetic
 UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-imprecise-fp-arithmetic)
 
+Wanalyzer-infinite-loop
+UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-infinite-loop)
+
 Wanalyzer-infinite-recursion
 UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-infinite-recursion)
 
@@ -111,6 +114,9 @@ UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-tainted-offset)
 Wanalyzer-tainted-size
 UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-tainted-size)
 
+Wanalyzer-undefined-behavior-strtok
+UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-undefined-behavior-strtok)
+
 Wanalyzer-use-after-free
 UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-use-after-free)
 
@@ -138,6 +144,9 @@ UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-write-to-string-liter
 Wanalyzer-use-of-uninitialized-value
 UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-use-of-uninitialized-value)
 
+Wanalyzer-symbol-too-complex
+UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-symbol-too-complex)
+
 Wanalyzer-too-complex
 UrlSuffix(gcc/Static-Analyzer-Options.html#index-Wanalyzer-too-complex)
 
diff --git a/gcc/c-family/c.opt.urls b/gcc/c-family/c.opt.urls
index 8fccbc77ea3..cb4c2e24685 100644
--- a/gcc/c-family/c.opt.urls
+++ b/gcc/c-family/c.opt.urls
@@ -103,6 +103,9 @@ LangUrlSuffix_D(gdc/Warnings.html#index-Wall)
 Walloca
 UrlSuffix(gcc/Warning-Options.html#index-Walloca) LangUrlSuffix_D(gdc/Warnings.html#index-Walloca)
 
+Walloc-size
+UrlSuffix(gcc/Warning-Options.html#index-Walloc-size)
+
 Walloc-size-larger-than=
 UrlSuffix(gcc/Warning-Options.html#index-Walloc-size-larger-than_003d)
 
@@ -154,8 +157,8 @@ UrlSuffix(gcc/Warning-Options.html#index-Wbuiltin-declaration-mismatch) LangUrlS
 Wbuiltin-macro-redefined
 UrlSuffix(gcc/Warning-Options.html#index-Wbuiltin-macro-redefined)
 
-Wc11-c2x-compat
-UrlSuffix(gcc/Warning-Options.html#index-Wc11-c2x-compat)
+Wc11-c23-compat
+UrlSuffix(gcc/Warning-Options.html#index-Wc11-c23-compat)
 
 Wc90-c99-compat
 UrlSuffix(gcc/Warning-Options.html#index-Wc90-c99-compat)
@@ -193,6 +196,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wc_002b_002b20-extensions)
 Wc++23-extensions
 UrlSuffix(gcc/Warning-Options.html#index-Wc_002b_002b23-extensions)
 
+Wc++26-extensions
+UrlSuffix(gcc/Warning-Options.html#index-Wc_002b_002b26-extensions)
+
 Wcast-function-type
 UrlSuffix(gcc/Warning-Options.html#index-Wcast-function-type)
 
@@ -256,6 +262,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wdate-time)
 Wdeclaration-after-statement
 UrlSuffix(gcc/Warning-Options.html#index-Wdeclaration-after-statement)
 
+Wdeclaration-missing-parameter-type
+UrlSuffix(gcc/Warning-Options.html#index-Wdeclaration-missing-parameter-type)
+
 Wdelete-incomplete
 UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wdelete-incomplete)
 
@@ -649,6 +658,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wno-old-style-definition)
 Wopenacc-parallelism
 UrlSuffix(gcc/Warning-Options.html#index-Wno-openacc-parallelism)
 
+Wopenmp
+UrlSuffix(gcc/Warning-Options.html#index-Wno-openmp)
+
 Wopenmp-simd
 UrlSuffix(gcc/Warning-Options.html#index-Wno-openmp-simd)
 
@@ -726,6 +738,9 @@ UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wno-register)
 Wreorder
 UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wno-reorder)
 
+Wreturn-mismatch
+UrlSuffix(gcc/Warning-Options.html#index-Wno-return-mismatch)
+
 Wreturn-type
 UrlSuffix(gcc/Warning-Options.html#index-Wno-return-type)
 
@@ -1014,6 +1029,9 @@ UrlSuffix(gcc/Inline.html#index-fno-default-inline)
 fdiagnostics-show-template-tree
 UrlSuffix(gcc/Diagnostic-Message-Formatting-Options.html#index-fdiagnostics-show-template-tree)
 
+fdiagnostics-all-candidates
+UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-fdiagnostics-all-candidates)
+
 fdirectives-only
 UrlSuffix(gcc/Preprocessor-Options.html#index-fdirectives-only)
 
@@ -1068,6 +1086,9 @@ UrlSuffix(gcc/C-Dialect-Options.html#index-fgnu89-inline)
 fhosted
 UrlSuffix(gcc/C-Dialect-Options.html#index-fhosted)
 
+fimmediate-escalation
+UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-fimmediate-escalation)
+
 ; skipping UrlSuffix for 'fimplement-inlines' due to multiple URLs:
 ;   duplicate: 'gcc/C_002b_002b-Dialect-Options.html#index-fimplement-inlines'
 ;   duplicate: 'gcc/C_002b_002b-Interface.html#index-fno-implement-inlines-1'
@@ -1181,16 +1202,16 @@ fobjc-nilcheck
 UrlSuffix(gcc/Objective-C-and-Objective-C_002b_002b-Dialect-Options.html#index-fobjc-nilcheck)
 
 fopenacc
-UrlSuffix(gcc/C-Dialect-Options.html#index-fopenacc)
+UrlSuffix(gcc/C-Dialect-Options.html#index-fopenacc) LangUrlSuffix_Fortran(gfortran/Fortran-Dialect-Options.html#index-fopenacc)
 
 fopenacc-dim=
 UrlSuffix(gcc/C-Dialect-Options.html#index-fopenacc-dim)
 
 fopenmp
-UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp)
+UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp) LangUrlSuffix_Fortran(gfortran/Fortran-Dialect-Options.html#index-fopenmp)
 
 fopenmp-simd
-UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp-simd)
+UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp-simd) LangUrlSuffix_Fortran(gfortran/Fortran-Dialect-Options.html#index-fopenmp-simd)
 
 foperator-names
 UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-fno-operator-names)
diff --git a/gcc/common.opt.urls b/gcc/common.opt.urls
index 407c86018fc..4cb2d7dc628 100644
--- a/gcc/common.opt.urls
+++ b/gcc/common.opt.urls
@@ -123,6 +123,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wframe-larger-than_003d)
 Wfree-nonheap-object
 UrlSuffix(gcc/Warning-Options.html#index-Wfree-nonheap-object)
 
+Whardened
+UrlSuffix(gcc/Warning-Options.html#index-Whardened)
+
 Wimplicit-fallthrough
 UrlSuffix(gcc/Warning-Options.html#index-Wimplicit-fallthrough)
 
@@ -540,6 +543,9 @@ UrlSuffix(gcc/Diagnostic-Message-Formatting-Options.html#index-fdiagnostics-colo
 fdiagnostics-color=
 UrlSuffix(gcc/Diagnostic-Message-Formatting-Options.html#index-fdiagnostics-color)
 
+fdiagnostics-json-formatting
+UrlSuffix(gcc/Diagnostic-Message-Formatting-Options.html#index-fdiagnostics-json-formatting)
+
 fdiagnostics-urls=
 UrlSuffix(gcc/Diagnostic-Message-Formatting-Options.html#index-fdiagnostics-urls)
 
@@ -733,6 +739,9 @@ UrlSuffix(gcc/Optimize-Options.html#index-fstore-merging)
 fguess-branch-probability
 UrlSuffix(gcc/Optimize-Options.html#index-fguess-branch-probability)
 
+fhardened
+UrlSuffix(gcc/Instrumentation-Options.html#index-fhardened)
+
 fharden-compares
 UrlSuffix(gcc/Instrumentation-Options.html#index-fharden-compares)
 
@@ -787,6 +796,12 @@ UrlSuffix(gcc/Optimize-Options.html#index-finline-functions-called-once)
 finline-limit=
 UrlSuffix(gcc/Optimize-Options.html#index-finline-limit)
 
+finline-stringops
+UrlSuffix(gcc/Optimize-Options.html#index-finline-stringops)
+
+finline-stringops=
+UrlSuffix(gcc/Optimize-Options.html#index-finline-stringops)
+
 fcf-protection
 UrlSuffix(gcc/Instrumentation-Options.html#index-fcf-protection)
 
@@ -1315,6 +1330,21 @@ UrlSuffix(gcc/Optimize-Options.html#index-fstrict-aliasing)
 fstrict-overflow
 UrlSuffix(gcc/Code-Gen-Options.html#index-fstrict-overflow)
 
+fstrub=strict
+UrlSuffix(gcc/Instrumentation-Options.html#index-fstrub_003dstrict)
+
+fstrub=relaxed
+UrlSuffix(gcc/Instrumentation-Options.html#index-fstrub_003drelaxed)
+
+fstrub=all
+UrlSuffix(gcc/Instrumentation-Options.html#index-fstrub_003dall)
+
+fstrub=at-calls
+UrlSuffix(gcc/Instrumentation-Options.html#index-fstrub_003dat-calls)
+
+fstrub=internal
+UrlSuffix(gcc/Instrumentation-Options.html#index-fstrub_003dinternal)
+
 fsync-libcalls
 UrlSuffix(gcc/Code-Gen-Options.html#index-fsync-libcalls)
 
diff --git a/gcc/config/aarch64/aarch64.opt.urls b/gcc/config/aarch64/aarch64.opt.urls
index 82882fee064..ab0d26c1857 100644
--- a/gcc/config/aarch64/aarch64.opt.urls
+++ b/gcc/config/aarch64/aarch64.opt.urls
@@ -67,6 +67,9 @@ UrlSuffix(gcc/AArch64-Options.html#index-mlow-precision-sqrt)
 mlow-precision-div
 UrlSuffix(gcc/AArch64-Options.html#index-mlow-precision-div)
 
+mearly-ra=
+UrlSuffix(gcc/AArch64-Options.html#index-mearly-ra)
+
 msve-vector-bits=
 UrlSuffix(gcc/AArch64-Options.html#index-msve-vector-bits)
 
diff --git a/gcc/config/i386/i386.opt.urls b/gcc/config/i386/i386.opt.urls
index 6ee69e35a61..9b988fd6996 100644
--- a/gcc/config/i386/i386.opt.urls
+++ b/gcc/config/i386/i386.opt.urls
@@ -158,10 +158,10 @@ mvect8-ret-in-mem
 UrlSuffix(gcc/x86-Options.html#index-mvect8-ret-in-mem)
 
 mrecip
-UrlSuffix(gcc/x86-Options.html#index-mrecip-1)
+UrlSuffix(gcc/x86-Options.html#index-mrecip-2)
 
 mrecip=
-UrlSuffix(gcc/x86-Options.html#index-mrecip-1)
+UrlSuffix(gcc/x86-Options.html#index-mrecip-2)
 
 mcld
 UrlSuffix(gcc/x86-Options.html#index-mcld)
@@ -600,3 +600,12 @@ UrlSuffix(gcc/x86-Options.html#index-mapxf)
 musermsr
 UrlSuffix(gcc/x86-Options.html#index-musermsr)
 
+mavx10.1-256
+UrlSuffix(gcc/x86-Options.html#index-mavx10_002e1-256)
+
+mavx10.1-512
+UrlSuffix(gcc/x86-Options.html#index-mavx10_002e1-512)
+
+mavx10.1
+UrlSuffix(gcc/x86-Options.html#index-mavx10_002e1)
+
diff --git a/gcc/config/loongarch/loongarch.opt.urls b/gcc/config/loongarch/loongarch.opt.urls
index fbf0b53b969..c78bbfea2da 100644
--- a/gcc/config/loongarch/loongarch.opt.urls
+++ b/gcc/config/loongarch/loongarch.opt.urls
@@ -51,9 +51,11 @@ UrlSuffix(gcc/LoongArch-Options.html#index-mexplicit-relocs-1)
 mexplicit-relocs
 UrlSuffix(gcc/LoongArch-Options.html#index-mexplicit-relocs-1)
 
-; skipping UrlSuffix for 'mrecip' due to finding no URLs
+mrecip
+UrlSuffix(gcc/LoongArch-Options.html#index-mrecip)
 
-; skipping UrlSuffix for 'mrecip=' due to finding no URLs
+mrecip=
+UrlSuffix(gcc/LoongArch-Options.html#index-mrecip)
 
 ; skipping UrlSuffix for 'mcmodel=' due to finding no URLs
 
diff --git a/gcc/config/riscv/riscv.opt.urls b/gcc/config/riscv/riscv.opt.urls
index 66838491010..e1ab96658ea 100644
--- a/gcc/config/riscv/riscv.opt.urls
+++ b/gcc/config/riscv/riscv.opt.urls
@@ -74,6 +74,9 @@ UrlSuffix(gcc/RISC-V-Options.html#index-mstack-protector-guard-offset-2)
 misa-spec=
 UrlSuffix(gcc/RISC-V-Options.html#index-misa-spec)
 
+mmovcc
+UrlSuffix(gcc/RISC-V-Options.html#index-mmovcc)
+
 minline-atomics
 UrlSuffix(gcc/RISC-V-Options.html#index-minline-atomics)
 
diff --git a/gcc/config/rs6000/rs6000.opt.urls b/gcc/config/rs6000/rs6000.opt.urls
index fdc33fc759b..28bf073c6cf 100644
--- a/gcc/config/rs6000/rs6000.opt.urls
+++ b/gcc/config/rs6000/rs6000.opt.urls
@@ -78,10 +78,10 @@ mxl-compat
 UrlSuffix(gcc/RS_002f6000-and-PowerPC-Options.html#index-mxl-compat)
 
 mrecip
-UrlSuffix(gcc/RS_002f6000-and-PowerPC-Options.html#index-mrecip)
+UrlSuffix(gcc/RS_002f6000-and-PowerPC-Options.html#index-mrecip-1)
 
 mrecip=
-UrlSuffix(gcc/RS_002f6000-and-PowerPC-Options.html#index-mrecip)
+UrlSuffix(gcc/RS_002f6000-and-PowerPC-Options.html#index-mrecip-1)
 
 mrecip-precision
 UrlSuffix(gcc/RS_002f6000-and-PowerPC-Options.html#index-mrecip-precision)
diff --git a/gcc/fortran/lang.opt.urls b/gcc/fortran/lang.opt.urls
index a7d9bdc142c..e335b42e357 100644
--- a/gcc/fortran/lang.opt.urls
+++ b/gcc/fortran/lang.opt.urls
@@ -82,6 +82,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wmissing-include-dirs)
 Wopenacc-parallelism
 UrlSuffix(gcc/Warning-Options.html#index-Wno-openacc-parallelism)
 
+Wopenmp
+UrlSuffix(gcc/Warning-Options.html#index-Wno-openmp)
+
 Wopenmp-simd
 UrlSuffix(gcc/Warning-Options.html#index-Wno-openmp-simd)
 
@@ -107,16 +110,19 @@ ff2c
 LangUrlSuffix_Fortran(gfortran/Code-Gen-Options.html#index-ff2c)
 
 fopenacc
-UrlSuffix(gcc/C-Dialect-Options.html#index-fopenacc)
+UrlSuffix(gcc/C-Dialect-Options.html#index-fopenacc) LangUrlSuffix_Fortran(gfortran/Fortran-Dialect-Options.html#index-fopenacc)
 
 fopenacc-dim=
 UrlSuffix(gcc/C-Dialect-Options.html#index-fopenacc-dim)
 
 fopenmp
-UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp)
+UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp) LangUrlSuffix_Fortran(gfortran/Fortran-Dialect-Options.html#index-fopenmp)
 
 fopenmp-simd
-UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp-simd)
+UrlSuffix(gcc/C-Dialect-Options.html#index-fopenmp-simd) LangUrlSuffix_Fortran(gfortran/Fortran-Dialect-Options.html#index-fopenmp-simd)
+
+fopenmp-allocators
+LangUrlSuffix_Fortran(gfortran/Fortran-Dialect-Options.html#index-fopenmp-allocators)
 
 fpreprocessed
 UrlSuffix(gcc/Preprocessor-Options.html#index-fpreprocessed)

^ permalink raw reply	[flat|nested] 14+ messages in thread