public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: Usha Gupta <gusha2960@gmail.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: cgen <cgen@sourceware.org>
Subject: Re: Help needed for porting opcodes for CISC architecture
Date: Mon, 17 Feb 2014 09:11:00 -0000	[thread overview]
Message-ID: <CACFh0TxXt9cB1zx29aTx1+6zdOdQ1yaHQ0ejpHsamxrwpHtXKg@mail.gmail.com> (raw)
In-Reply-To: <y0mlhxipscw.fsf@fche.csb>

Thanks Frank.

I have got instructions upto 4 bytes being correctly assembled.

I was initially using simplification macro "dnf " for defining
instruction fields which does not allows specifying word-length and
word-offset.
The problem is resolved by specifying instruction fields using
define-ifield where I could define the total length of the instruction
where this specific instruction field is used .

For 5-byte  insns, since opcode  doesn't fit in CGEN_INSN_INT which is
defined in include/opcode/cgen.h as unsigned int , I changed it to
"unsigned long long". Is there a cleaner way to achieve this?
The instructions seem to get assembled but the bytes are not arranged
in the correct order (as defined by the instruction fields used).

Say I have an 16-bit unsigned immediate xy and a 8-bit signed
immediate n and my instruction format looks like this
0--7     8---------15  16-------23    24--31  32---------39
IIIIIIII    yyyyyyyy   xxxxxxxx     IIIIIIII     nnnnnnnn

I have defined instruction fields as
f-op1- 0,8 (0-7 bits)
f-op2 - 24,8 (24-31 bits)
f-uimm16 - 8,16 (8-23 bits)
f-simm8 - 32,8 (32-39 bits)

On seeing  the disassembly, I find that both the opcodes are placed
contiguously (in 0-15 bits) and also the hi8 of 16-bit unsigned
immediate is filled with junk value.
Similar issue is seen when 16 bit immediate value is used in 24/32 bit
insns. Target is little-endian (in case that matters here).
Am I doing something wrong here?

> Presumably those IIIII's don't overlap - i.e., the hardware can tell
> from the first byte that it's a 2-byte instruction (and more opcode
> bits need to be fetched).  In cgen, instruction opcodes need not be
> single fields nor contiguous; just specify one ifield per unique
> opcode piece.

Following example shows instruction formats with overlap
1-byte instruction:
 IIIIIrrr - 5 bits opcode , 3 bits for register operand

2-byte instruction:
 IIIIIsss IIIIIttt - 5-bit opcode, 3-bit register  operand (source),
5-bit opcode, 3-bit register operand (destination)

I could not find a common bit pattern to identify the insn length. Can
this be handled using CGEN?

Thanks in advance.

Regards,
Usha Gupta

      reply	other threads:[~2014-02-17  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 17:35 Usha Gupta
2014-02-10 21:31 ` Frank Ch. Eigler
2014-02-17  9:11   ` Usha Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACFh0TxXt9cB1zx29aTx1+6zdOdQ1yaHQ0ejpHsamxrwpHtXKg@mail.gmail.com \
    --to=gusha2960@gmail.com \
    --cc=cgen@sourceware.org \
    --cc=fche@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).