[ITA] giflib

[ITA] giflib

[Lemures Lemniscati]

Hi!


ITA for giflib, which has been maintained by Yaakov [1].


Now, the latest upstream of giflib is 5.2.1 [2].


A new candidate cygport file is placed at [3].
And, it's been tested on Cygwin Scallywag CI [4].


Some files for building come from Fedora 36:
  https://src.fedoraproject.org/rpms/giflib/raw/f36/f/CMakeLists.txt
  https://src.fedoraproject.org/rpms/giflib/raw/f36/f/giflib_coverity.patch
  https://src.fedoraproject.org/rpms/giflib/raw/f36/f/giflib_html-docs-consistent-ids.patch
  https://src.fedoraproject.org/rpms/giflib/raw/f36/f/giflib_quantize.patch


Generated package files are placed at [5] and [6]:

* giflib-5.2.1-1.tar.xz
* libgif-devel-5.2.1-1.tar.xz
* libgif7-5.2.1-1.tar.xz

* giflib-5.2.1-1-src.tar.xz
* giflib-debuginfo-5.2.1-1.tar.xz


[1]: https://cygwin.com/git/?p=git/cygwin-packages/giflib.git
[2]: https://sourceforge.net/projects/giflib/files/
[3]: https://github.com/cygwin-lem/giflib-cygport/tree/n_5.2.1-1
[4]: https://cygwin.com/cgi-bin2/jobs.cgi?id=4253
[5]: https://cygwin-lem.github.io/giflib-cygport/
[6]: https://github.com/cygwin-lem/giflib-cygport/tree/n_5.2.1-1_gh-pages


Regards, 

Lem

Re: [ITA] giflib

[Jon Turney]

On 29/05/2022 12:45, Lemures Lemniscati wrote:
> Hi!
> 
> 
> ITA for giflib, which has been maintained by Yaakov [1].

Thanks. I added this to your authorized packages.

Small comments on the .cygport:

> # Patch files whose names are in a default style of 'git format-patch'
> PATCH_URI+=$(\
>   find -maxdepth 1 -type f -name '[0-9][0-9][0-9][0-9]-*.patch' \
>   | sort \
> )

Hmm... there's probably a case to be made that this is something that 
cygport should be doing automatically.

It would certainly help with noticing when patches are removed from 
PATCH_URI but not from the source package repo...

> 
> BUILD_REQUIRES="\
>   cmake\
>   ninja\
> "

I don't think these need to be listed because they are implied by the 
respective inherits.

Certainly, if things are working as intended, scallywag can infer that.

Re: [ITA] giflib

[Lemures Lemniscati]

On Sun, 29 May 2022 17:12:03 +0100, Jon Turney
> On 29/05/2022 12:45, Lemures Lemniscati wrote:
> > ITA for giflib, which has been maintained by Yaakov [1].
> 
> Thanks. I added this to your authorized packages.

Thank you!


> Small comments on the .cygport:
> 
> > # Patch files whose names are in a default style of 'git format-patch'
> > PATCH_URI+=$(\
> >   find -maxdepth 1 -type f -name '[0-9][0-9][0-9][0-9]-*.patch' \
> >   | sort \
> > )
> 
> Hmm... there's probably a case to be made that this is something that cygport should be doing automatically.
> 
> It would certainly help with noticing when patches are removed from PATCH_URI but not from the source package repo...

This is an adhoc code.
I'm apt to be lazy to edit PATCH_URI for locally prepared patches... :).
In this case, I locally prepared patches because I didn't know how to
get the patches from the upstream URIs.


> > BUILD_REQUIRES="\
> >   cmake\
> >   ninja\
> > "
> 
> I don't think these need to be listed because they are implied by the respective inherits.
> 
> Certainly, if things are working as intended, scallywag can infer that.

I confirmed that it works without BUILD_REQUIRES (https://cygwin.com/cgi-bin2/jobs.cgi?id=4261).
I'll remove it.

Thank you.

Lem