public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* setup and colons in filenames
@ 2017-10-25 15:50 Ken Brown
  2017-10-25 19:23 ` Jon Turney
  0 siblings, 1 reply; 18+ messages in thread
From: Ken Brown @ 2017-10-25 15:50 UTC (permalink / raw)
  To: cygwin-apps

This is a followup to the thread started here:

   https://cygwin.com/ml/cygwin-patches/2017-q4/msg00012.html

Currently setup's parse_filename is not correctly parsing filenames in 
/etc/setup/installed.db that contain colons, as explained in the above 
thread.  It would be easy to fix this by just ripping out the 'base' 
function, except for the fact that parse_filename is called by 
ScanFindVisitor::visitFile.

I don't know enough about WIN32_FIND_DATA to know whether the call to 
'base' is needed for that use of parse_filename.  If so, is it safe to 
skip all colons in that setting, since we're dealing with Win32 
filenames and they don't see the colons in Cygwin filenames?

Do we need two versions of parse_filename, one that calls base and one 
that doesn't?

Ken

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2017-10-27 16:28 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-25 15:50 setup and colons in filenames Ken Brown
2017-10-25 19:23 ` Jon Turney
2017-10-25 20:16   ` Corinna Vinschen
2017-10-25 20:36     ` Jon Turney
2017-10-25 21:00       ` Corinna Vinschen
2017-10-26 16:14         ` Jon Turney
2017-10-26 16:14   ` Jon Turney
2017-10-26 17:04     ` Ken Brown
2017-10-26 17:20       ` Jon Turney
2017-10-26 17:42     ` Achim Gratz
2017-10-26 17:49       ` Jon Turney
2017-10-26 18:25         ` Achim Gratz
2017-10-27  8:47           ` Corinna Vinschen
2017-10-27 10:40             ` Achim Gratz
2017-10-27 13:44               ` Jon Turney
2017-10-27 15:20                 ` Ken Brown
2017-10-27 16:28                   ` Corinna Vinschen
2017-10-27 13:43           ` Jon Turney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).