From: Jon Turney <jon.turney@dronecode.org.uk>
To: Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] Use automake (v5)
Date: Tue, 20 Apr 2021 21:15:41 +0100 [thread overview]
Message-ID: <5d7176f9-8d82-9b2c-4717-fdc5041d95ce@dronecode.org.uk> (raw)
In-Reply-To: <20210420201326.4876-1-jon.turney@dronecode.org.uk>
On 20/04/2021 21:13, Jon Turney wrote:
> For ease of reviewing, this patch doesn't contain changes to generated
> files which would be made by running ./autogen.sh.
Sorry about getting distracted from this. To summarize what I believe
were the outstanding issues with v3 [1]:
[1] https://cygwin.com/pipermail/cygwin-patches/2020q4/010827.html
* 'INCLUDES' is the old name for 'AM_CPPFLAGS' warning from autogen.sh
I plan to clean this up in a future patch
* 'ps$(EXEEXT)' previously defined' warning from autogen.sh
It seems to be a shortcoming of automake that there's no way to suppress
just that warning.
One possible solution is build ps.exe with a different name and rename
it while installing, but I think that is counter-productive (in the
sense that it trades this warning for making the build more complex to
understand)
* some object files are in a unexpected places in the build file
hierarchy (compared to naive expectations and/or the non-automake build)
I'm not sure if this is merely an aesthetic issue, or if there are
problems this causes.
next prev parent reply other threads:[~2021-04-20 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 20:13 Jon Turney
2021-04-20 20:15 ` Jon Turney [this message]
2021-04-21 16:40 ` Corinna Vinschen
2021-04-22 11:57 ` Corinna Vinschen
2021-04-26 15:03 ` Corinna Vinschen
2021-04-27 15:54 ` Jon Turney
2021-04-27 15:50 ` Jon Turney
2021-04-27 16:52 ` Ken Brown
2021-04-27 17:00 ` Ken Brown
2021-04-27 18:32 ` Jon Turney
2021-05-02 15:28 ` Jon Turney
2021-05-02 18:25 ` Brian Inglis
2021-05-03 10:40 ` Corinna Vinschen
2021-05-03 10:43 ` Corinna Vinschen
2021-05-04 18:12 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7176f9-8d82-9b2c-4717-fdc5041d95ce@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).