Re: [PATCH] Use automake (v5)

[Jon Turney <jon.turney@dronecode.org.uk>]

On 03/05/2021 11:43, Corinna Vinschen wrote:
> On May  2 16:28, Jon Turney wrote:
>> On 20/04/2021 21:13, Jon Turney wrote:
>>> For ease of reviewing, this patch doesn't contain changes to generated
>>> files which would be made by running ./autogen.sh.
>>
>> Some possible items of future work I noted:
>>
>> * Documentation is now always built (rather than dangerously ignoring any
>> errors)
>>
>> Although this is half-arsed at the moment, as we don't require the
>> documentation tools at configure time, we'll just fail when the rules are
>> executed if they are missing.
>>
>> Perhaps there should be explicit configuration to build documentation or
>> not?
> 
> `make doc'?

Yeah, that's probably the right thing to do.

[...]
>> * 'make our include directories absolute so we don't have to worry about
>> making them relative to the subdirectory we happen to be building in' is
>> sufficiently obscure that it at least deserves a comment.
> 
> I'm not sure I understand... -v, please?

Yeah, that's why it needs comment :)

realdirpath() in winsup/configure.ac makes paths absolute (and canonical)

Therefore we can use things set with it (AC_CYGWIN_INCLUDES, 
target_builddir, winsup_srcdir) in Makefile.am in arbitrarily deep 
subdirectories, and things just happen to work (which wouldn't be the 
case if they contained relative paths)

It's all a hangover from when it used to be even more complex (see 
commit 39e8d907), and looking at this again, this could probably be 
cleaned-up some more (perhaps using $top_builddir, $top_srcdir?).