From: Jon Turney <jon.turney@dronecode.org.uk>
To: Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] Use automake (v5)
Date: Sun, 2 May 2021 16:28:58 +0100 [thread overview]
Message-ID: <d4964f52-518e-205b-c44f-02bea6a225d6@dronecode.org.uk> (raw)
In-Reply-To: <20210420201326.4876-1-jon.turney@dronecode.org.uk>
On 20/04/2021 21:13, Jon Turney wrote:
> For ease of reviewing, this patch doesn't contain changes to generated
> files which would be made by running ./autogen.sh.
Some possible items of future work I noted:
* Documentation is now always built (rather than dangerously ignoring
any errors)
Although this is half-arsed at the moment, as we don't require the
documentation tools at configure time, we'll just fail when the rules
are executed if they are missing.
Perhaps there should be explicit configuration to build documentation or
not?
* Use AM_V_GEN to silence (most?) custom rules
* -Wimplicit-fallthrough, -Werror could (should?) be set in top-level
Makefile.am.common, rather than individual subdirs
* Some custom rules have multiple outputs and workarounds to ensure the
rule only runs once
Ideally these would be re-written using make 4.3 'grouped targets', but
perhaps not yet...
* Some custom rules could be simplified
e.g. mkvers.sh generates version.cc and winver.rc, then runs windres on
windver.rc
* 'make our include directories absolute so we don't have to worry about
making them relative to the subdirectory we happen to be building in' is
sufficiently obscure that it at least deserves a comment.
* Rather than a huge list of --replace options to mkimport inline in the
Makefile, it might be more sensible to augment that tool the read a list
of replacement names from a file, and put them there.
next prev parent reply other threads:[~2021-05-02 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 20:13 Jon Turney
2021-04-20 20:15 ` Jon Turney
2021-04-21 16:40 ` Corinna Vinschen
2021-04-22 11:57 ` Corinna Vinschen
2021-04-26 15:03 ` Corinna Vinschen
2021-04-27 15:54 ` Jon Turney
2021-04-27 15:50 ` Jon Turney
2021-04-27 16:52 ` Ken Brown
2021-04-27 17:00 ` Ken Brown
2021-04-27 18:32 ` Jon Turney
2021-05-02 15:28 ` Jon Turney [this message]
2021-05-02 18:25 ` Brian Inglis
2021-05-03 10:40 ` Corinna Vinschen
2021-05-03 10:43 ` Corinna Vinschen
2021-05-04 18:12 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4964f52-518e-205b-c44f-02bea6a225d6@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).